From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Agustin Martin Newsgroups: gmane.emacs.bugs Subject: bug#16800: 24.3; flyspell works slow on very short words at the end of big file Date: Sun, 9 Mar 2014 18:36:55 +0100 Message-ID: References: <83ios72j8b.fsf@gnu.org> <20140222185511.GA23643@openwall.com> <838ut23lo9.fsf@gnu.org> <20140223195659.GA23581@openwall.com> <20140223230251.GA30257@openwall.com> <20140224160317.GA2475@openwall.com> <20140226203202.GA23749@agmartin.aq.upm.es> <20140228114545.GA8669@agmartin.aq.upm.es> <83fvn3wj3m.fsf@gnu.org> <20140301214427.GA14106@openwall.com> <83ob1ptfr3.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=14dae9473ba3e97f5e04f42feef9 X-Trace: ger.gmane.org 1394386626 22962 80.91.229.3 (9 Mar 2014 17:37:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 9 Mar 2014 17:37:06 +0000 (UTC) To: Aleksey Cherepanov , 16800@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 09 18:37:14 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WMhf0-0008G4-Du for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Mar 2014 18:37:14 +0100 Original-Received: from localhost ([::1]:44862 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMhez-0006eu-UC for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Mar 2014 13:37:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMhet-0006ec-2o for bug-gnu-emacs@gnu.org; Sun, 09 Mar 2014 13:37:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WMheo-0003h3-LB for bug-gnu-emacs@gnu.org; Sun, 09 Mar 2014 13:37:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMheo-0003gz-HW for bug-gnu-emacs@gnu.org; Sun, 09 Mar 2014 13:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WMheo-0000XS-2m for bug-gnu-emacs@gnu.org; Sun, 09 Mar 2014 13:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Agustin Martin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Mar 2014 17:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16800 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16800-submit@debbugs.gnu.org id=B16800.13943866192060 (code B ref 16800); Sun, 09 Mar 2014 17:37:02 +0000 Original-Received: (at 16800) by debbugs.gnu.org; 9 Mar 2014 17:36:59 +0000 Original-Received: from localhost ([127.0.0.1]:58323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WMhek-0000X6-LJ for submit@debbugs.gnu.org; Sun, 09 Mar 2014 13:36:58 -0400 Original-Received: from mail-lb0-f175.google.com ([209.85.217.175]:58132) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WMhei-0000Ww-VP for 16800@debbugs.gnu.org; Sun, 09 Mar 2014 13:36:57 -0400 Original-Received: by mail-lb0-f175.google.com with SMTP id w7so4063564lbi.34 for <16800@debbugs.gnu.org>; Sun, 09 Mar 2014 10:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=V3jzbsIgtb7fmzpOyxG8KcbWgDRo51+OY8qKL8XHhU4=; b=AMUniXwXYAzaiSXA1vS9mGFF1wkNQQrHRH2yojvPWIY4okfVKCoF1fRYlKiKuwwKCI E4NUXi1T2F3yssq415iM7MvXlXzk/WANxs6CktPRgg66azHRfnUdxqJOpdajdeInLVER doy60u/GglNLr4PdssbgiJA20Hh3fbASpBCQ1Mfc6GsKyuM36oaAQTupoGKX3jMWOxuQ 6FFYGZiJs+8dYVMmrGK03JdLYTxgEwC4zFUA4W0CktZJPZQOFpZSpNQmu45lx9ZJkSkk pMyqQmwdDczEnzptFhDV1LfmhL5RGLYKe6Tj1yqYZs4EB8mJMy/Nvh2yecU21YgPr2kP QLqQ== X-Received: by 10.112.22.196 with SMTP id g4mr9385lbf.47.1394386615761; Sun, 09 Mar 2014 10:36:55 -0700 (PDT) Original-Received: by 10.112.201.165 with HTTP; Sun, 9 Mar 2014 10:36:55 -0700 (PDT) In-Reply-To: <83ob1ptfr3.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86685 Archived-At: --14dae9473ba3e97f5e04f42feef9 Content-Type: text/plain; charset=ISO-8859-1 2014-03-02 4:56 GMT+01:00 Eli Zaretskii : > > Date: Sun, 2 Mar 2014 01:44:27 +0400 > > From: Aleksey Cherepanov > > Cc: Agustin Martin , 16800@debbugs.gnu.org > > > > We could try to limit execution time. Though checks for that could > > slow down the search. > > Exactly. > I see other problem with that, it is not deterministic, since the limit depends on system load. I have mixed feelings about changing current default from unlimited, but I slowly changing my mind towards having a big but not unlimited value as default. On the one hand, not putting limits in default value looks nicer, but on the other that may have a non negligible impact in performance for really huge files, as Eli points out. Alexey's one-liner is 30000 lines and 2.4e6 chars size. While new code seems to work for it, I'd put the limit somewhere lower, no more than 1e6. This should be huge enough for any practical use and for anyone to notice the difference. Regards, -- Agustin --14dae9473ba3e97f5e04f42feef9 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
2014= -03-02 4:56 GMT+01:00 Eli Zaretskii <eliz@gnu.org>:
> Date: Sun, 2 Mar 2014 01:44:27 +0400
> From: Aleksey Cherepanov <aleksey.4erepanov@gmail.com>
> Cc: Agustin Martin <agustin.martin@hispalinux.es>, 16800@debbugs.gnu.org
>
> We could try to limit execution time. Though che= cks for that could
> slow down the search.

Exactly.

I see other problem with= that, it is not deterministic, since the limit depends on system load.
=
I have mixed feelings about changing current default from un= limited, but I slowly changing my mind towards having=A0 a big but not unli= mited value as default.

On the one hand, not putting limits in default value looks n= icer, but on the other that may have a non negligible impact in performance= for really huge files, as Eli points out.

Alexey's o= ne-liner is 30000 lines and 2.4e6 chars size. While new code seems to work = for it, I'd put the limit somewhere lower, no more than 1e6. This shoul= d be huge enough for any practical use and for anyone to notice the differe= nce.

Regards,

--
Agustin

--14dae9473ba3e97f5e04f42feef9--