From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alexander Shukaev Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] ImageMagick Support on Windows Date: Wed, 15 Oct 2014 11:27:36 +0200 Message-ID: References: <83siis71xq.fsf@gnu.org> <83siiq6e3v.fsf@gnu.org> <83r3ya65t0.fsf@gnu.org> <83h9z56fwy.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c234e814b438050572bebb X-Trace: ger.gmane.org 1413365273 32581 80.91.229.3 (15 Oct 2014 09:27:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Oct 2014 09:27:53 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 15 11:27:46 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XeKry-0002uw-DO for ged-emacs-devel@m.gmane.org; Wed, 15 Oct 2014 11:27:46 +0200 Original-Received: from localhost ([::1]:43160 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeKry-00064H-0Z for ged-emacs-devel@m.gmane.org; Wed, 15 Oct 2014 05:27:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeKrt-00061k-Hd for emacs-devel@gnu.org; Wed, 15 Oct 2014 05:27:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XeKrs-0006xa-Gv for emacs-devel@gnu.org; Wed, 15 Oct 2014 05:27:41 -0400 Original-Received: from mail-la0-x22c.google.com ([2a00:1450:4010:c03::22c]:51021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeKrq-0006vt-BM; Wed, 15 Oct 2014 05:27:38 -0400 Original-Received: by mail-la0-f44.google.com with SMTP id hs14so680333lab.31 for ; Wed, 15 Oct 2014 02:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=dG9FRb9y5Ar0fY7mj4ziej97JIKJ/lTd7pr0zAl4Jvs=; b=caE4nqlu+nyVhFpIe2IQWQBymv3iRHKgEEGd5rNug7c/lgzgHxDpSVreYTPeY5dNlu 6tEOUFUlmsV4GPTALujlLfBgcuwZTRP2DuR597FYfkzNWMaibOSF52mWY8iT3yYtLMU3 spK2gj+gi0ZYPgU9hB72LAWUiFkaB/APhlFz53yYLhM5crA3gW8ikPqNGDIs7kP7z0Vq lhye1VXRb2Kv0RQ1eU3XK6MH1t4QMB8a4MtKJjrUZwMK1yQmeRd6M7ukWHBYJiAqrzwj 5hR9sjOxLhO6brfCq8NQWJBom0S9mzE0LEiaNiYAMrGYsKklvmNSVkiDvBKMQ6p7g8I2 Ddhg== X-Received: by 10.112.173.69 with SMTP id bi5mr2427563lbc.61.1413365256989; Wed, 15 Oct 2014 02:27:36 -0700 (PDT) Original-Received: by 10.112.202.106 with HTTP; Wed, 15 Oct 2014 02:27:36 -0700 (PDT) In-Reply-To: <83h9z56fwy.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:175393 Archived-At: --001a11c234e814b438050572bebb Content-Type: text/plain; charset=UTF-8 > > Can you run this command under GDB, and see exactly where it crashes, > and why? I, personally, usually don't use GDB to find out causes of crashing on Windows, i.e. I either infer them from the code or find it out through logging facilities. The main reason why I almost never use GDB on Windows is the following output: Program received signal SIGSEGV, Segmentation fault. 0x0000000000000000 in ?? () which actually conveys no information at all. The crash often goes deep to some Windows system DLLs and therefore cannot be traced by GDB. This is exactly the case this time once again. We cannot rely on GDB now... I'm not sure I see where image.el needs to load image libraries. Could you point out where you think that happens? (Running temacs > under GDB will surely tell, btw.) If you rename the ImageMagick DLLs > to some other names, or remove them from PATH, does the Emacs build > succeed? It should not necessarily load images. It can do some initialization stuff involving ImageMagick calls. For instance, I have already found that commenting out: (imagemagick-register-types) in the very bottom of "image.el" prevents the crash and "temacs.exe" continues to function properly. Are you sure that you have pointed out all the spots that should be patched and that we didn't miss any of them? Please, since you know the internals better, think of what we could miss patching, it really feels like a zero pointer somewhere or something alike. In any case, now you know that it all starts from the "(imagemagick-register-types)" call. Tomorrow I'm leaving for 2 weeks vacation, so I can continue only when I'm back. I'm still available today for discussions. --001a11c234e814b438050572bebb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Can you run this command under GDB, and see exactly where it c= rashes,
and why?

I, personally, usually don= 9;t use GDB to find out causes of crashing on Windows, i.e. I either infer = them from the code or find it out through logging facilities. The main reas= on why I almost never use GDB on Windows is the following output:

Program received signal SIGSEGV, Segmentation fault.
<= div>0x0000000000000000 in ?? ()

which actually con= veys no information at all. The crash often goes deep to some Windows syste= m DLLs and therefore cannot be traced by GDB. This is exactly the case this= time once again. We cannot rely on GDB now...

I'm not sure I see where image.el needs to load image li= braries.
Could you point out where you think that happens?=C2=A0 (Running temacs
under GDB will surely tell, btw.)=C2=A0 If you rename the ImageMagick DLLs<= br> to some other names, or remove them from PATH, does the Emacs build
succeed?
=C2=A0
It should not necessarily load i= mages. It can do some initialization stuff involving ImageMagick calls. For= instance, I have already found that commenting out:

(imagemagick-register-types)

in the = very bottom of "image.el" prevents the crash and "temacs.exe= " continues to function properly.

Are you sur= e that you have pointed out all the spots that should be patched and that w= e didn't miss any of them? Please, since you know the internals better,= think of what we could miss patching, it really feels like a zero pointer = somewhere or something alike. In any case, now you know that it all starts = from the "(imagemagick-register-types)" call.

Tomorrow I'm leaving for 2 weeks vacation, so I can continue only= when I'm back. I'm still available today for discussions.
--001a11c234e814b438050572bebb--