From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alexander Shukaev Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] ImageMagick Support on Windows Date: Tue, 14 Oct 2014 12:17:33 +0200 Message-ID: References: <83siis71xq.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e0158b7ead6f68905055f5252 X-Trace: ger.gmane.org 1413281875 27215 80.91.229.3 (14 Oct 2014 10:17:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 14 Oct 2014 10:17:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 14 12:17:47 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XdzAn-0004Fl-5P for ged-emacs-devel@m.gmane.org; Tue, 14 Oct 2014 12:17:45 +0200 Original-Received: from localhost ([::1]:37546 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XdzAm-00066J-Ls for ged-emacs-devel@m.gmane.org; Tue, 14 Oct 2014 06:17:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XdzAj-00066C-9h for emacs-devel@gnu.org; Tue, 14 Oct 2014 06:17:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XdzAi-0005NI-5u for emacs-devel@gnu.org; Tue, 14 Oct 2014 06:17:41 -0400 Original-Received: from mail-lb0-x233.google.com ([2a00:1450:4010:c04::233]:48761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XdzAd-0005MI-Cw; Tue, 14 Oct 2014 06:17:35 -0400 Original-Received: by mail-lb0-f179.google.com with SMTP id l4so7887112lbv.10 for ; Tue, 14 Oct 2014 03:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=3PKW3SqQ13D6vfc2U0CbFADFb/NMe1nivfby1Rq9Is4=; b=aZmOQPflq8SwlzjdOkMQXKKTm6d/6MQfDDn6YTPn8nEQZ8GuJtXYlj2R5XMPMU8mkp 45OjbrvDMDSwdb0CNv22+K5wXC1twcN9Kp5cuE6nIeMJceQaoZ44k6lqsPZa8OlpGqHS htVxOAbdF9OpNy3DH3vERSNkDEhHL98qPg0SkOmeWSXqKxqnzaWYKhW6CMTRHq6IJLHH VdwURFQMe87H1KnKZBT9l6Vk1dxdU8F7iAFjgEgR2SE0d40MlAB1RoIxlqLnsqM9f+La 0VOoO5VXi3yqQjkpA7LJCxXcgKP9XFIRXFOOIZTyMvhi28C7hiCLifYHiPJW+1HC9V5q Qefg== X-Received: by 10.152.36.33 with SMTP id n1mr1975627laj.95.1413281853402; Tue, 14 Oct 2014 03:17:33 -0700 (PDT) Original-Received: by 10.112.202.106 with HTTP; Tue, 14 Oct 2014 03:17:33 -0700 (PDT) In-Reply-To: <83siis71xq.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:175348 Archived-At: --089e0158b7ead6f68905055f5252 Content-Type: text/plain; charset=UTF-8 > > . configure.ac needs changes to revert IMAGEMAGICK_LIBS to empty > value, because otherwise src/Makefile will cause Emacs binary to be > linked against the ImageMagick libraries, and the resulting binary > will then refuse to start if the corresponding DLL is not available > at run time. You can see the example of how we do that with > librsvg. I'm not good at GNU Autotools stuff, sorry. Could you elaborate on this? I don't see that "IMAGEMAGICK_LIBS" would be assigned any value in " configure.ac". Nevertheless, on the linking stage I see: -lMagickWand-6.Q16HDRI -lMagickCore-6.Q16HDRI Is this what you meant? Can I just safely assign it to empty value then? . dynamic-library-alist in w32-win.el should acquire an element > required for Emacs to know which DLL(s) to look for when > ImageMagick support is first required. I assume adding something like: '(imagemagick "libMagick++-6.Q16HDRI-5") Is this correct? . If there are several ImageMagick versions out there whose DLLs are > not binary compatible, you will need to add version checking, both > on init_imagemagick_functions and in dynamic-library-alist, > similarly to what we already do with some other image libraries, > like libgif, libjpeg, etc. Well, I have no idea about that yet. I'm not a huge expert with ImageMagick. Perhaps somebody could clarify on that. --089e0158b7ead6f68905055f5252 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
=C2=A0. c= onfigure.ac needs changes to revert IMAGEMAGICK_LIBS to empty
=C2=A0= =C2=A0value, because otherwise src/Makefile will cause Emacs binary to be<= br>=C2=A0 =C2=A0linked against the ImageMagick libraries, and the resulting= binary
=C2=A0 =C2=A0will then refuse to start if the corresponding DLL = is not available
=C2=A0 =C2=A0at run time.=C2=A0 You can see the example= of how we do that with
=C2=A0 =C2=A0librsvg.

I'm not good at GNU Autotools stuff, sorry. Could you elaborate o= n this? I don't see that "IMAGEMAGICK_LIBS" would be assigned= any value in "configure.ac".= Nevertheless, on the linking stage I see:

-lMagic= kWand-6.Q16HDRI -lMagickCore-6.Q16HDRI

Is this= what you meant? Can I just safely assign it to empty value then?

=C2=A0. dynamic-library-alist in w32-win.e= l should acquire an element
=C2=A0 =C2=A0required for Emacs to know whic= h DLL(s) to look for when
=C2=A0 =C2=A0ImageMagick support is first requ= ired.

I assume adding something like:=

=C2=A0 =C2=A0 =C2=A0 =C2=A0'(imagemagick= "libMagick++-6.Q16HDRI-5")

Is thi= s correct?

=C2=A0. If there are s= everal ImageMagick versions out there whose DLLs are
=C2=A0 =C2=A0not bi= nary compatible, you will need to add version checking, both
=C2=A0 =C2= =A0on init_imagemagick_functions and in dynamic-library-alist,
=C2=A0 = =C2=A0similarly to what we already do with some other image libraries,
= =C2=A0 =C2=A0like libgif, libjpeg, etc.

Well, I have no idea about that yet. I'm not a huge expert with Imag= eMagick. Perhaps somebody could clarify on that.
--089e0158b7ead6f68905055f5252--