Bug: org export table.el [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.1/lisp/org/)]

Bug: org export table.el [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.1/lisp/org/)]

[Ulrich G. Wortmann]

[-- Attachment #1: Type: text/plain, Size: 4746 bytes --]

Dear All,

the following problem occurs reproducibly with  GNU Emacs 26.1 (see below
for details), even when starting emacs with -Q

If I use a table in my org file and convert that table to table.el the
caption is not exported into either the HTML or Latex File. Export to ASCII
works as expected. If I convert the table back to org-table format, the
Latex and HTML export of the caption work as expected. As a side note, any
other #+ expressions (e.g., Latex-Attr, Labels etc) won't be exported
either if the table is in table.el format

Expected behavior: #+CAPTION:  is being exported regardless what table
format has been selected.

#+CAPTION: Test caption on top of table.el
+---+---+---+
| 1 | 2 | 3 |
+---+---+---+
| 4 | 5 | 6 |
+---+---+---+
| 6 | 7 | 8 |
+---+---+---+

Cheers

Uli

Emacs  : GNU Emacs 26.1 (build 1, x86_64-suse-linux-gnu, GTK+ Version
3.24.1)
Package: Org mode version 9.1.9 (release_9.1.9-65-g5e4542 @
/usr/share/emacs/26.1/lisp/org/)

current state:
==============
(setq
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
     org-src-mode-configure-edit-buffer)
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-html-format-inlinetask-function
'org-html-format-inlinetask-default-function
 org-odt-format-headline-function 'org-odt-format-headline-default-function
 org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default
 org-mode-hook '(#[0 "\300\301\302\303\304$\207"
   [add-hook change-major-mode-hook org-show-block-all append
    local]
   5]
#[0 "\300\301\302\303\304$\207"
   [add-hook change-major-mode-hook org-babel-show-result-all
    append local]
   5]
org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-odt-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-bibtex-headline-format-function #[257 "\300 \236A\207" [:title] 3
"\n\n(fn ENTRY)"]
 org-latex-format-drawer-function #[514 "\207" [] 3 "\n\n(fn _ CONTENTS)"]
 org-babel-pre-tangle-hook '(save-buffer)
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe
      org-babel-header-arg-expand)
 org-ascii-format-drawer-function #[771 " \207" [] 4 "\n\n(fn NAME CONTENTS
WIDTH)"]
 org-occur-hook '(org-first-headline-recenter)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
  org-cycle-show-empty-lines
  org-optimize-window-after-visibility-change)
 org-speed-command-hook '(org-speed-command-activate
  org-babel-speed-command-activate)
 org-odt-format-inlinetask-function
'org-odt-format-inlinetask-default-function
 org-confirm-shell-link-function 'yes-or-no-p
 org-link-parameters '(("id" :follow org-id-open)
       ("rmail" :follow org-rmail-open :store
org-rmail-store-link)
       ("mhe" :follow org-mhe-open :store org-mhe-store-link)
       ("irc" :follow org-irc-visit :store org-irc-store-link)
       ("info" :follow org-info-open :export org-info-export
:store org-info-store-link)
       ("gnus" :follow org-gnus-open :store
org-gnus-store-link)
       ("docview" :follow org-docview-open :export
org-docview-export :store org-docview-store-link)
       ("bibtex" :follow org-bibtex-open :store
org-bibtex-store-link)
       ("bbdb" :follow org-bbdb-open :export org-bbdb-export
:complete org-bbdb-complete-link :store
org-bbdb-store-link)
       ("w3m" :store org-w3m-store-link) ("file+sys")
       ("file+emacs") ("doi" :follow org--open-doi-link)
       ("elisp" :follow org--open-elisp-link)
       ("file" :complete org-file-complete-link)
       ("ftp" :follow
(lambda (path) (browse-url (concat "ftp:" path))))
       ("help" :follow org--open-help-link)
       ("http" :follow
(lambda (path) (browse-url (concat "http:" path))))
       ("https" :follow
(lambda (path) (browse-url (concat "https:" path))))
       ("mailto" :follow
(lambda (path) (browse-url (concat "mailto:" path))))
       ("news" :follow
(lambda (path) (browse-url (concat "news:" path))))
       ("shell" :follow org--open-shell-link))
 org-latex-format-headline-function
'org-latex-format-headline-default-function
 org-latex-format-inlinetask-function
'org-latex-format-inlinetask-default-function
 org-html-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
 org-html-format-headline-function
'org-html-format-headline-default-function
 )
-- 

Ulrich Wortmann 416 978 7084

Associate Chair Undergraduate Affairs

Department of Earth Sciences

University of Toronto
22 Russel St., Toronto, ON, Canada, M5S 3B1

[-- Attachment #2: Type: text/html, Size: 8346 bytes --]

Re: Bug: org export table.el [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.1/lisp/org/)]

[Nicolas Goaziou]

Hello,

"Ulrich G. Wortmann" <uli.wortmann@utoronto.ca> writes:

> the following problem occurs reproducibly with  GNU Emacs 26.1 (see below
> for details), even when starting emacs with -Q
>
> If I use a table in my org file and convert that table to table.el the
> caption is not exported into either the HTML or Latex File. Export to ASCII
> works as expected. If I convert the table back to org-table format, the
> Latex and HTML export of the caption work as expected. As a side note, any
> other #+ expressions (e.g., Latex-Attr, Labels etc) won't be exported
> either if the table is in table.el format
>
> Expected behavior: #+CAPTION:  is being exported regardless what table
> format has been selected.
>
> #+CAPTION: Test caption on top of table.el
> +---+---+---+
>
> | 1 | 2 | 3 |
> +---+---+---+
> | 4 | 5 | 6 |
> +---+---+---+
> | 6 | 7 | 8 |
> +---+---+---+

Export of table.el tables is not handled by Org, but by "table.el"
library. In other words, Org keywords are expected to work only on Org
tables.

Regards,

-- 
Nicolas Goaziou

Re: Bug: org export table.el [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.1/lisp/org/)]

[Ulrich G. Wortmann]

[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]

Thanks for the feedback. Makes sense if the latex code in the tabular
environment is generated by table.el. I wonder however why the export to
ASCII produces a caption.

Cheers

Uli

On Sat, 24 Nov 2018 at 04:37 Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:

> Hello,
>
> "Ulrich G. Wortmann" <uli.wortmann@utoronto.ca> writes:
>
> > the following problem occurs reproducibly with  GNU Emacs 26.1 (see below
> > for details), even when starting emacs with -Q
> >
> > If I use a table in my org file and convert that table to table.el the
> > caption is not exported into either the HTML or Latex File. Export to
> ASCII
> > works as expected. If I convert the table back to org-table format, the
> > Latex and HTML export of the caption work as expected. As a side note,
> any
> > other #+ expressions (e.g., Latex-Attr, Labels etc) won't be exported
> > either if the table is in table.el format
> >
> > Expected behavior: #+CAPTION:  is being exported regardless what table
> > format has been selected.
> >
> > #+CAPTION: Test caption on top of table.el
> > +---+---+---+
> >
> > | 1 | 2 | 3 |
> > +---+---+---+
> > | 4 | 5 | 6 |
> > +---+---+---+
> > | 6 | 7 | 8 |
> > +---+---+---+
>
> Export of table.el tables is not handled by Org, but by "table.el"
> library. In other words, Org keywords are expected to work only on Org
> tables.
>
> Regards,
>
> --
> Nicolas Goaziou
>
-- 

Ulrich Wortmann 416 978 7084

Associate Chair Undergraduate Affairs

Department of Earth Sciences

University of Toronto
22 Russel St., Toronto, ON, Canada, M5S 3B1

[-- Attachment #2: Type: text/html, Size: 2294 bytes --]

Re: Bug: org export table.el [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.1/lisp/org/)]

[Ulrich G. Wortmann]

[-- Attachment #1: Type: text/plain, Size: 1662 bytes --]

I had a quick look at table.el

It exports only a tabular command, not a table. Is there a way to make org
wrap the

\begin{tabular}
\end{tabular}

into a regular

\begin{table}
\end{table}

This would be perfectly correct latex, and keep the export mechanism,
neatly separated

Cheers

Uli

On Sat, 24 Nov 2018 at 04:37 Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:

> Hello,
>
> "Ulrich G. Wortmann" <uli.wortmann@utoronto.ca> writes:
>
> > the following problem occurs reproducibly with  GNU Emacs 26.1 (see below
> > for details), even when starting emacs with -Q
> >
> > If I use a table in my org file and convert that table to table.el the
> > caption is not exported into either the HTML or Latex File. Export to
> ASCII
> > works as expected. If I convert the table back to org-table format, the
> > Latex and HTML export of the caption work as expected. As a side note,
> any
> > other #+ expressions (e.g., Latex-Attr, Labels etc) won't be exported
> > either if the table is in table.el format
> >
> > Expected behavior: #+CAPTION:  is being exported regardless what table
> > format has been selected.
> >
> > #+CAPTION: Test caption on top of table.el
> > +---+---+---+
> >
> > | 1 | 2 | 3 |
> > +---+---+---+
> > | 4 | 5 | 6 |
> > +---+---+---+
> > | 6 | 7 | 8 |
> > +---+---+---+
>
> Export of table.el tables is not handled by Org, but by "table.el"
> library. In other words, Org keywords are expected to work only on Org
> tables.
>
> Regards,
>
> --
> Nicolas Goaziou
>
-- 

Ulrich Wortmann 416 978 7084

Associate Chair Undergraduate Affairs

Department of Earth Sciences

University of Toronto
22 Russel St., Toronto, ON, Canada, M5S 3B1

[-- Attachment #2: Type: text/html, Size: 2549 bytes --]

Re: Bug: org export table.el [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.1/lisp/org/)]

[Nicolas Goaziou]

Hello,

"Ulrich G. Wortmann" <uli.wortmann@utoronto.ca> writes:

> I had a quick look at table.el
>
> It exports only a tabular command, not a table. Is there a way to make org
> wrap the
>
> \begin{tabular}
> \end{tabular}
>
> into a regular
>
> \begin{table}
> \end{table}
>
> This would be perfectly correct latex, and keep the export mechanism,
> neatly separated

You may want to look at `org-latex--table.el-table' and see what can be
done.

Regards,

-- 
Nicolas Goaziou

Re: Bug: org export table.el [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.1/lisp/org/)]

[Ulrich G. Wortmann]

[-- Attachment #1: Type: text/plain, Size: 3260 bytes --]

Hi Nicolas,

I know nothing about lisp, but I think I understand enough of the structure
to propose the following changes:

In my testfile, this preserves the current behavior if no #+CAPTION is
present. However, if the  #+CAPTION is not empty, the table will be
exported as float with the proper caption and label. The code needs
probably some cleanup, but I don't understand enough lisp to know what's
save to drop.

Hope this can be merged

Cheers

Uli

--- org-mode/lisp/ox-latex.el   2018-11-28 11:58:15.234232222 -0500
+++ org-mode-uliw/ox-latex.el.uliw      2018-11-28 11:57:09.057281230 -0500

@@ -3305,6 +3310,21 @@

 This function assumes TABLE has `table.el' as its `:type'
 property."
+  (let* ((caption (org-latex--caption/label-string table info))
+        (attr (org-export-read-attribute :attr_latex table))
+        ;; Determine alignment string.
+        (alignment (org-latex--align-string table info))
+        ;; Determine environment for the table: longtable, tabular...
+        (table-env (or (plist-get attr :environment)
+                       (plist-get info :latex-default-table-environment)))
+        ;; If table is a float, determine environment: table, table*
+        ;; or sidewaystable.
+        (placement
+         (or (plist-get attr :placement)
+             (format "[%s]" (plist-get info
:latex-default-figure-position))))
+        (centerp (if (plist-member attr :center) (plist-get attr :center)
+                   (plist-get info :latex-tables-centered)))
+        (caption-above-p (org-latex--caption-above-p table info)))
   (require 'table)
   ;; Ensure "*org-export-table*" buffer is empty.
   (with-current-buffer (get-buffer-create "*org-export-table*")
@@ -3332,7 +3352,16 @@
       (let ((centerp (if (plist-member attr :center) (plist-get attr
:center)
                       (plist-get info :latex-tables-centered))))
        (if (not centerp) output
-         (format "\\begin{center}\n%s\n\\end{center}" output))))))
+         (if (string= "" caption)
+             (format (concat "\\begin{center}\n"
+                             "%s\n"
+                             "\\end{center}\n") output)
+           (format (concat "\\begin{table}\n"
+                           caption
+                           "\\centering\n"
+                           "%s\n"
+                           "\\end{table}\n") output))
+         ))))))

 (defun org-latex--math-table (table info)
   "Return appropriate LaTeX code for a matrix.


On Mon, 26 Nov 2018 at 16:02 Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:

> Hello,
>
> "Ulrich G. Wortmann" <uli.wortmann@utoronto.ca> writes:
>
> > I had a quick look at table.el
> >
> > It exports only a tabular command, not a table. Is there a way to make
> org
> > wrap the
> >
> > \begin{tabular}
> > \end{tabular}
> >
> > into a regular
> >
> > \begin{table}
> > \end{table}
> >
> > This would be perfectly correct latex, and keep the export mechanism,
> > neatly separated
>
> You may want to look at `org-latex--table.el-table' and see what can be
> done.
>
> Regards,
>
> --
> Nicolas Goaziou
>
-- 

Ulrich Wortmann 416 978 7084

Associate Chair Undergraduate Affairs

Department of Earth Sciences

University of Toronto
22 Russel St., Toronto, ON, Canada, M5S 3B1

[-- Attachment #2: Type: text/html, Size: 4900 bytes --]

Re: Bug: org export table.el [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.1/lisp/org/)]

[Nicolas Goaziou]

Hello,

"Ulrich G. Wortmann" <uli.wortmann@utoronto.ca> writes:
>
> I know nothing about lisp, but I think I understand enough of the structure
> to propose the following changes:
>
> In my testfile, this preserves the current behavior if no #+CAPTION is
> present. However, if the  #+CAPTION is not empty, the table will be
> exported as float with the proper caption and label. The code needs
> probably some cleanup, but I don't understand enough lisp to know what's
> save to drop.
>
> Hope this can be merged

Thank you. I applied something similar in "next" branch (i.e., Org 9.3).

Regards,

-- 
Nicolas Goaziou

Re: Bug: org export table.el [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.1/lisp/org/)]

[Ulrich G. Wortmann]

[-- Attachment #1: Type: text/plain, Size: 4322 bytes --]

I made a few more tweaks. The function now recognizes modifiers as to which
float environment to use, and where to place the float on the page. E.g.

#+ATTR_LATEX: :environment longtable
#+ATTR_LATEX: :placment [t]

I also had a quick look at the html export code to see whether I can add
the caption text to the html export, but that is beyond my understanding of
lisp.

Below the code for org-latex--table.el-table

Cheers

Uli



(defun org-latex--table.el-table (table info)
  "Return appropriate LaTeX code for a table.el table.

TABLE is the table type element to transcode.  INFO is a plist
used as a communication channel.

This function assumes TABLE has `table.el' as its `:type'
property."
  (let* ((caption (org-latex--caption/label-string table info))
(attr (org-export-read-attribute :attr_latex table))
;; Determine alignment string.
(alignment (org-latex--align-string table info))
;; Determine environment for the table: longtable, tabular...
;;(table-env (or (plist-get attr :environment)
;; (plist-get info :latex-default-table-environment)))
;; If table is a float, determine environment: table, table*
;; or sidewaystable.
          (table-env (or (plist-get attr :environment)
(plist-get info :latex-default-table-environment)))
(float-env (unless (member table-env '("longtable" "longtabu"))
      (let ((float (plist-get attr :float)))
(cond
((and (not float) (plist-member attr :float)) nil)
((or (string= float "sidewaystable")
      (string= float "sideways")) "sidewaystable")
((string= float "multicolumn") "table*")
((or float
      (org-element-property :caption table)
      (org-string-nw-p (plist-get attr :caption)))
  "table")))))

(placement
  (or (plist-get attr :placement)
      (format "[%s]" (plist-get info :latex-default-figure-position))))
;; (centerp (if (plist-member attr :center) (plist-get attr :center)
;;     (plist-get info :latex-tables-centered)))
(caption-above-p (org-latex--caption-above-p table info)))
  (require 'table)
  ;; Ensure "*org-export-table*" buffer is empty.
  (with-current-buffer (get-buffer-create "*org-export-table*")
    (erase-buffer))
  (let ((output (with-temp-buffer
  (insert (org-element-property :value table))
  (goto-char 1)
  (re-search-forward "^[ \t]*|[^|]" nil t)
  (table-generate-source 'latex "*org-export-table*")
  (with-current-buffer "*org-export-table*"
    (org-trim (buffer-string))))))
    (kill-buffer (get-buffer "*org-export-table*"))
    ;; Remove left out comments.
    (while (string-match "^%.*\n" output)
      (setq output (replace-match "" t t output)))
    (let ((attr (org-export-read-attribute :attr_latex table)))
      (when (plist-get attr :rmlines)
;; When the "rmlines" attribute is provided, remove all hlines
;; but the the one separating heading from the table body.
(let ((n 0) (pos 0))
  (while (and (< (length output) pos)
      (setq pos (string-match "^\\\\hline\n?" output pos)))
    (cl-incf n)
    (unless (= n 2) (setq output (replace-match "" nil nil output))))))
      (let ((centerp (if (plist-member attr :center) (plist-get attr
:center)
       (plist-get info :latex-tables-centered))))
(if (not centerp) output
  (if (string= "" caption)
      (format (concat "\\begin{center}\n"
      "%s\n"
      "\\end{center}\n") output)
    (format (concat "\\begin{"table-env"}" placement"\n"
    caption
    "\\centering\n"
    "%s\n"
    "\\end{"table-env"}\n") output))
  ))))))



On Fri, 30 Nov 2018 at 15:27 Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:

> Hello,
>
> "Ulrich G. Wortmann" <uli.wortmann@utoronto.ca> writes:
> >
> > I know nothing about lisp, but I think I understand enough of the
> structure
> > to propose the following changes:
> >
> > In my testfile, this preserves the current behavior if no #+CAPTION is
> > present. However, if the  #+CAPTION is not empty, the table will be
> > exported as float with the proper caption and label. The code needs
> > probably some cleanup, but I don't understand enough lisp to know what's
> > save to drop.
> >
> > Hope this can be merged
>
> Thank you. I applied something similar in "next" branch (i.e., Org 9.3).
>
> Regards,
>
> --
> Nicolas Goaziou
>
-- 

Ulrich Wortmann 416 978 7084

Associate Chair Undergraduate Affairs

Department of Earth Sciences

University of Toronto
22 Russel St., Toronto, ON, Canada, M5S 3B1

[-- Attachment #2: Type: text/html, Size: 8490 bytes --]

Re: Bug: org export table.el [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.1/lisp/org/)]

[Nicolas Goaziou]

Hello,

"Ulrich G. Wortmann" <uli.wortmann@utoronto.ca> writes:

> I made a few more tweaks. The function now recognizes modifiers as to which
> float environment to use, and where to place the float on the page. E.g.
>
> #+ATTR_LATEX: :environment longtable
> #+ATTR_LATEX: :placment [t]

Thank you. However, I think the changes I pushed in "next" branch
already do this. Did you try them?

> I also had a quick look at the html export code to see whether I can add
> the caption text to the html export, but that is beyond my understanding of
> lisp.

I think captions are also handled in the "next" branch.

Regards,

-- 
Nicolas Goaziou

Re: Bug: org export table.el [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.1/lisp/org/)]

[Ulrich G. Wortmann]

[-- Attachment #1: Type: text/plain, Size: 988 bytes --]

no. I did not. How do checkout the "next" branch?

thx

On Mon, 3 Dec 2018 at 12:15 Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:

> Hello,
>
> "Ulrich G. Wortmann" <uli.wortmann@utoronto.ca> writes:
>
> > I made a few more tweaks. The function now recognizes modifiers as to
> which
> > float environment to use, and where to place the float on the page. E.g.
> >
> > #+ATTR_LATEX: :environment longtable
> > #+ATTR_LATEX: :placment [t]
>
> Thank you. However, I think the changes I pushed in "next" branch
> already do this. Did you try them?
>
> > I also had a quick look at the html export code to see whether I can add
> > the caption text to the html export, but that is beyond my understanding
> of
> > lisp.
>
> I think captions are also handled in the "next" branch.
>
> Regards,
>
> --
> Nicolas Goaziou
>
-- 

Ulrich Wortmann 416 978 7084

Associate Chair Undergraduate Affairs

Department of Earth Sciences

University of Toronto
22 Russel St., Toronto, ON, Canada, M5S 3B1

[-- Attachment #2: Type: text/html, Size: 1673 bytes --]

Re: Bug: org export table.el [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.1/lisp/org/)]

[Nicolas Goaziou]

Hello,

"Ulrich G. Wortmann" <uli.wortmann@utoronto.ca> writes:

> no. I did not. How do checkout the "next" branch?

You need to install Org from git, as described in the manual. Then,
before calling "make", just use "git checkout next".

Regards,

-- 
Nicolas Goaziou