From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Ryan Olson Newsgroups: gmane.emacs.bugs Subject: bug#21857: PATCH to show message after `package-install` installs successfully Date: Fri, 17 Jan 2020 11:04:22 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="126216"; mail-complaints-to="usenet@ciao.gmane.io" To: 21857@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 17 21:44:34 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1isYTp-000WkV-4Q for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jan 2020 21:44:33 +0100 Original-Received: from localhost ([::1]:34432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isYTo-0005RA-6U for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jan 2020 15:44:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48465) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isYTN-0005Af-Ad for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 15:44:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isYTK-0002Y2-Qp for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 15:44:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34222) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1isYTK-0002Xq-O9 for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 15:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1isYTK-0006Fg-NJ for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 15:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ryan Olson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jan 2020 20:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21857 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy Original-Received: via spool by 21857-submit@debbugs.gnu.org id=B21857.157929381923988 (code B ref 21857); Fri, 17 Jan 2020 20:44:02 +0000 Original-Received: (at 21857) by debbugs.gnu.org; 17 Jan 2020 20:43:39 +0000 Original-Received: from localhost ([127.0.0.1]:40194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isYSu-0006Ei-Ts for submit@debbugs.gnu.org; Fri, 17 Jan 2020 15:43:39 -0500 Original-Received: from mail-lf1-f44.google.com ([209.85.167.44]:35384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isVz5-0000Iy-Mg for 21857@debbugs.gnu.org; Fri, 17 Jan 2020 13:04:45 -0500 Original-Received: by mail-lf1-f44.google.com with SMTP id 15so19037395lfr.2 for <21857@debbugs.gnu.org>; Fri, 17 Jan 2020 10:04:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=aNAT9QrItbWQyGxGeKflTZvOtSIDTsbkO1HZHBbqtuc=; b=oIIrusdrZ8m702pmLGOeUYBdhPHbqLw4bAciJsJkKVIAIxh3lw5LL+hz7MDd0JH2dN BSC8sYBhF47BztLFbOTaMv4TaTDjQVUU2iMF2VebpqgIn3JdQYqqK0iRA5sTTt8giicq jNWm/ff4ofmdhGDFUH+LiqRUGmywqluF1+chZ4b86iLYtdJUkAfoFfcU1+HkrO4RRG1Q 4PbkSEsOTc/BynQmqP3JONrsfL5wG7J1rTuZBTWN9JoZG2Z5QOu28B2NqmrjWRX6wxls atNF7F7ncwNz+KvK0b4njs6wvxXYwKAbeA3bQAjgbHRUAEhYAuhfU/f0N5f2Wf3aJsQt VxwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=aNAT9QrItbWQyGxGeKflTZvOtSIDTsbkO1HZHBbqtuc=; b=V2WXLbFnULbFzvv7BKYqj/dtz6EXMddgCkwxu4453f0IjCg9TEMOg0mghllyF+DSd0 oJQMFHniC9PMv36H/b6S7IxoBqAXW1ibO1GKRVWGHTclu5AGZEll2XUTJZPmMIW4i1aq sEZ76wrG862ljj1V1tr39zz7USFnNnPrZc8BARRONnf1FF4lBQR52rJ2ks612Czj53Jz DXme9xsoK9YGlS6RTqZ7lqossN/yJBWZ7+/k/me8BCUuD19LP3YiBldN/XXbODveVKpC dIcU6ea0f4rhFXbrTHTMmHyxoUDVQ8+HTE2FRsk5PRed0clo/KPXIH5A2VYx+rS+fKzk MgSQ== X-Gm-Message-State: APjAAAUoApOBsqsMbmCIxvhoFAgiP27zkA6uYitYHfcE9eJGv1Yw2RPT 3EXu6QFLcqQwmx/bJa1WAfiGnYhBOedd0CXZrSpRpYuZ X-Google-Smtp-Source: APXvYqwNzTxJeRnMzu+HZ8+ZjdWd8pKUD4Oob+G9WtiwW4pA+qBkwOOOQUQyoxfqZeUdQzB6nK2bCv9EyQtYFPfH5Kg= X-Received: by 2002:a19:f10e:: with SMTP id p14mr6076602lfh.3.1579284273396; Fri, 17 Jan 2020 10:04:33 -0800 (PST) In-Reply-To: X-Mailman-Approved-At: Fri, 17 Jan 2020 15:43:33 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174767 Archived-At: Switched patch to `diff -u` variant. --- package.el.orig 2020-01-17 10:11:48.000000000 -0700 +++ package.el 2020-01-17 10:12:36.000000000 -0700 @@ -2076,7 +2076,8 @@ (package-compute-transaction () (list (list pkg)))))) (progn (package-download-transaction transaction) - (package--quickstart-maybe-refresh)) + (package--quickstart-maybe-refresh) + (message "Package `%s' installed." name)) (message "`%s' is already installed" name)))) (defun package-strip-rcs-id (str) On Fri, Jan 17, 2020 at 10:53 AM Ryan Olson wrote: > > When `package-install` function finishes successfully, this patch > (below) shows the message "Package `package-name` installed." This > matches the message that is shown with the function `package-delete`. > I feel like this solves the primary issue: messaging. After this > patch, the user should know that everything was a success. > > *** package.el.orig 2020-01-17 10:11:48.000000000 -0700 > --- package.el 2020-01-17 10:12:36.000000000 -0700 > *************** to install it but still mark it as selec > *** 2076,2082 **** > (package-compute-transaction () (list (list pkg)))))) > (progn > (package-download-transaction transaction) > ! (package--quickstart-maybe-refresh)) > (message "`%s' is already installed" name)))) > > (defun package-strip-rcs-id (str) > --- 2076,2083 ---- > (package-compute-transaction () (list (list pkg)))))) > (progn > (package-download-transaction transaction) > ! (package--quickstart-maybe-refresh) > ! (message "Package `%s' installed." name)) > (message "`%s' is already installed" name)))) > > (defun package-strip-rcs-id (str)