From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Ryan Olson Newsgroups: gmane.emacs.bugs Subject: bug#21857: PATCH to show message after `package-install` installs successfully Date: Fri, 17 Jan 2020 10:53:42 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="124657"; mail-complaints-to="usenet@ciao.gmane.io" To: 21857@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 17 21:44:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1isYTW-000WNn-WE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jan 2020 21:44:15 +0100 Original-Received: from localhost ([::1]:34428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isYTW-0005As-1X for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jan 2020 15:44:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48462) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isYTN-0005Ae-1C for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 15:44:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isYTK-0002Xf-Fu for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 15:44:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34221) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1isYTK-0002XU-DL for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 15:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1isYTK-0006FZ-B1 for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 15:44:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Ryan Olson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jan 2020 20:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21857 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy Original-Received: via spool by 21857-submit@debbugs.gnu.org id=B21857.157929381723979 (code B ref 21857); Fri, 17 Jan 2020 20:44:02 +0000 Original-Received: (at 21857) by debbugs.gnu.org; 17 Jan 2020 20:43:37 +0000 Original-Received: from localhost ([127.0.0.1]:40192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isYSs-0006Ee-Ke for submit@debbugs.gnu.org; Fri, 17 Jan 2020 15:43:36 -0500 Original-Received: from mail-lj1-f175.google.com ([209.85.208.175]:32816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isVol-0006V3-Pq for 21857@debbugs.gnu.org; Fri, 17 Jan 2020 12:54:00 -0500 Original-Received: by mail-lj1-f175.google.com with SMTP id y6so27384295lji.0 for <21857@debbugs.gnu.org>; Fri, 17 Jan 2020 09:53:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=bhkIIN0OD8W9yoG4NV/EEoU4Fuvmg8naY6EnTn5+qSM=; b=G+cMnwLkvILDEBpE0kHavnNyh+2L//SaLBIwf3GGYjWZVuPLidfCZaD7JoutdRDYGC 4f7yVFi44TRQB30OlKkOo6JkfqMkaed5Tpa6UzhF2KLvuY/R0OBTJEoirdga54Tq6Mav +0s8DaFNwzn83dZb1fIXXakETiz+qMIJ1wOp8eGd5X8GWMWj/5R1PVfhvWv/WK7RsOIX ccYf+r2Hy1pS37txOjzyxL6swcJB8nw2VTXLWb/+F/yglr4+9mONeSPVwI+KOtTuG3h5 Jia1uiJ0L+jmtNFiSNPIV6GcnRcMYL+4fZHYl9aj82wLvcM/0aesZGCReF5RZGON1xqV D7Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=bhkIIN0OD8W9yoG4NV/EEoU4Fuvmg8naY6EnTn5+qSM=; b=Sdco5rue9A/EN1KTVD3LVkOuHeNTE10zOnxnpTxe/ArWVohWfpYah7LhUClHsVoHLV STxXjEsHmWmi4fKdTh/v1FPw4koRq+TdhWzEZGQtKhMHHI3HSquiAHAVl7SovWq2t6NT Fbx/jwaEVV6oFRV3oDbIpipilKZAXwt71PsR3vXbRTI7tX9FuOIJo3Xx6Me2kknacZxI gu4uJyzydW7Rn7FBq/cPPONPPeMqBiYAQuqckmm0/THiqZa9FH6eJaDfrpC7MOrlpRxO lgA6plOka33N8UgKz42tcKliM5gnlTdjQvUFVur3TqC7fcoezT2ws3QUSjFmzpRe73bI HSJw== X-Gm-Message-State: APjAAAXQMiqvI8jTyW1Wj7suj8f6ouJ1Jt5osamr4XdQ5qaaGfBCC0wq 9yoJ5sRWgoKfg7xQycjd6VSEvDPObDCJ7tC5nCqbtCJu X-Google-Smtp-Source: APXvYqxYBaqhD17PQMiihXB3oYJRjj0+U8Dy00l1KnZg9OIhiCUc2tXa36XMEy2K0EiTs+n3WSG0wxEf5zH+kLCqqRo= X-Received: by 2002:a2e:9f17:: with SMTP id u23mr6516281ljk.112.1579283633412; Fri, 17 Jan 2020 09:53:53 -0800 (PST) X-Mailman-Approved-At: Fri, 17 Jan 2020 15:43:33 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174766 Archived-At: When `package-install` function finishes successfully, this patch (below) shows the message "Package `package-name` installed." This matches the message that is shown with the function `package-delete`. I feel like this solves the primary issue: messaging. After this patch, the user should know that everything was a success. *** package.el.orig 2020-01-17 10:11:48.000000000 -0700 --- package.el 2020-01-17 10:12:36.000000000 -0700 *************** to install it but still mark it as selec *** 2076,2082 **** (package-compute-transaction () (list (list pkg)))))) (progn (package-download-transaction transaction) ! (package--quickstart-maybe-refresh)) (message "`%s' is already installed" name)))) (defun package-strip-rcs-id (str) --- 2076,2083 ---- (package-compute-transaction () (list (list pkg)))))) (progn (package-download-transaction transaction) ! (package--quickstart-maybe-refresh) ! (message "Package `%s' installed." name)) (message "`%s' is already installed" name)))) (defun package-strip-rcs-id (str)