[MPS test] `void-function igc--collect` on scratch/igc branch (commit: `42731228d2`)

[MPS test] `void-function igc--collect` on scratch/igc branch (commit: `42731228d2`)

[Eval Exec]

Hello,

I want to help test `scratch/igc` branch on my Linux environment, then
I clone `scratch/igc` branch from
https://git.savannah.gnu.org/git/emacs.git.
the scratch/igc branch's commit ID is `42731228d24c37edb2dc848c3a74d5c932a817ef`

Then I build emacs by:
```bash
make extraclean
./autogen.sh \
  && ./configure \
  --prefix=$(realpath ../emacs-build)\
  --with-mps \
  --with-imagemagick \
  --with-modules --with-x-toolkit=lucid --without-compress-install \
  --without-toolkit-scroll-bars --with-native-compilation  --with-mailutils\
  --with-tree-sitter --with-xinput2  \
  --with-dbus  --with-native-compilation=aot \
  --with-file-notification=inotify\
  && make -j20 install
```

After build success, I notice there is an interactive command:
`igc-collect`, so I `M-x igc-collect`, then I got:

```elisp
Debugger entered--Lisp error: (void-function igc--collect)
  igc--collect()
  igc-collect()
  funcall-interactively(igc-collect)
  command-execute(igc-collect record)
  #<subr execute-extended-command>(nil "igc-collect" nil)
  ad-Advice-execute-extended-command(#<subr execute-extended-command>
nil "igc-collect" nil)
  apply(ad-Advice-execute-extended-command #<subr
execute-extended-command> (nil "igc-collect" nil))
  execute-extended-command(nil "igc-collect" nil)
  funcall-interactively(execute-extended-command nil "igc-collect" nil)
  command-execute(execute-extended-command)
```


Is this expected? Did I miss something when I building Emacs?
Thank you.

Re: [MPS test] `void-function igc--collect` on scratch/igc branch (commit: `42731228d2`)

[Eli Zaretskii]

> From: Eval Exec <execvy@gmail.com>
> Date: Mon, 5 Aug 2024 21:48:24 +0800
> 
> Then I build emacs by:
> ```bash
> make extraclean
> ./autogen.sh \
>   && ./configure \
>   --prefix=$(realpath ../emacs-build)\
>   --with-mps \
>   --with-imagemagick \
>   --with-modules --with-x-toolkit=lucid --without-compress-install \
>   --without-toolkit-scroll-bars --with-native-compilation  --with-mailutils\
>   --with-tree-sitter --with-xinput2  \
>   --with-dbus  --with-native-compilation=aot \
>   --with-file-notification=inotify\
>   && make -j20 install
> ```
> 
> After build success, I notice there is an interactive command:
> `igc-collect`, so I `M-x igc-collect`, then I got:
> 
> ```elisp
> Debugger entered--Lisp error: (void-function igc--collect)
>   igc--collect()
>   igc-collect()
>   funcall-interactively(igc-collect)
>   command-execute(igc-collect record)
>   #<subr execute-extended-command>(nil "igc-collect" nil)
>   ad-Advice-execute-extended-command(#<subr execute-extended-command>
> nil "igc-collect" nil)
>   apply(ad-Advice-execute-extended-command #<subr
> execute-extended-command> (nil "igc-collect" nil))
>   execute-extended-command(nil "igc-collect" nil)
>   funcall-interactively(execute-extended-command nil "igc-collect" nil)
>   command-execute(execute-extended-command)
> ```
> 
> 
> Is this expected? Did I miss something when I building Emacs?

You need to make sure the configure script finds the MPS library,
otherwise it will build without the new GC.

Re: [MPS test] `void-function igc--collect` on scratch/igc branch (commit: `42731228d2`)

[Eval Exec]

Thank you! After installing the mps package, the newly built Emacs now
includes the `igc--collect` function.

On Mon, Aug 5, 2024 at 11:01 PM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: Eval Exec <execvy@gmail.com>
> > Date: Mon, 5 Aug 2024 21:48:24 +0800
> >
> > Then I build emacs by:
> > ```bash
> > make extraclean
> > ./autogen.sh \
> >   && ./configure \
> >   --prefix=$(realpath ../emacs-build)\
> >   --with-mps \
> >   --with-imagemagick \
> >   --with-modules --with-x-toolkit=lucid --without-compress-install \
> >   --without-toolkit-scroll-bars --with-native-compilation  --with-mailutils\
> >   --with-tree-sitter --with-xinput2  \
> >   --with-dbus  --with-native-compilation=aot \
> >   --with-file-notification=inotify\
> >   && make -j20 install
> > ```
> >
> > After build success, I notice there is an interactive command:
> > `igc-collect`, so I `M-x igc-collect`, then I got:
> >
> > ```elisp
> > Debugger entered--Lisp error: (void-function igc--collect)
> >   igc--collect()
> >   igc-collect()
> >   funcall-interactively(igc-collect)
> >   command-execute(igc-collect record)
> >   #<subr execute-extended-command>(nil "igc-collect" nil)
> >   ad-Advice-execute-extended-command(#<subr execute-extended-command>
> > nil "igc-collect" nil)
> >   apply(ad-Advice-execute-extended-command #<subr
> > execute-extended-command> (nil "igc-collect" nil))
> >   execute-extended-command(nil "igc-collect" nil)
> >   funcall-interactively(execute-extended-command nil "igc-collect" nil)
> >   command-execute(execute-extended-command)
> > ```
> >
> >
> > Is this expected? Did I miss something when I building Emacs?
>
> You need to make sure the configure script finds the MPS library,
> otherwise it will build without the new GC.

Re: [MPS test] `void-function igc--collect` on scratch/igc branch (commit: `42731228d2`)

[Gerd Möllmann]

Eval Exec <execvy@gmail.com> writes:

> Hello,
>
> I want to help test `scratch/igc` branch on my Linux environment, then
> I clone `scratch/igc` branch from
> https://git.savannah.gnu.org/git/emacs.git.
> the scratch/igc branch's commit ID is `42731228d24c37edb2dc848c3a74d5c932a817ef`
>
> Then I build emacs by:
> ```bash
> make extraclean
> ./autogen.sh \
>   && ./configure \
>   --prefix=$(realpath ../emacs-build)\
>   --with-mps \
>   --with-imagemagick \
>   --with-modules --with-x-toolkit=lucid --without-compress-install \
>   --without-toolkit-scroll-bars --with-native-compilation  --with-mailutils\
>   --with-tree-sitter --with-xinput2  \
>   --with-dbus  --with-native-compilation=aot \
>   --with-file-notification=inotify\
>   && make -j20 install
> ```
>
> After build success, I notice there is an interactive command:
> `igc-collect`, so I `M-x igc-collect`, then I got:
>
> ```elisp
> Debugger entered--Lisp error: (void-function igc--collect)
>   igc--collect()
>   igc-collect()
>   funcall-interactively(igc-collect)
>   command-execute(igc-collect record)
>   #<subr execute-extended-command>(nil "igc-collect" nil)
>   ad-Advice-execute-extended-command(#<subr execute-extended-command>
> nil "igc-collect" nil)
>   apply(ad-Advice-execute-extended-command #<subr
> execute-extended-command> (nil "igc-collect" nil))
>   execute-extended-command(nil "igc-collect" nil)
>   funcall-interactively(execute-extended-command nil "igc-collect" nil)
>   command-execute(execute-extended-command)
> ```
>
>
> Is this expected? Did I miss something when I building Emacs?
> Thank you.

I don't get an error. What does (featurep 'mps) say? It should give t if
built with MPS.

Re: [MPS test] `void-function igc--collect` on scratch/igc branch (commit: `42731228d2`)

[Eval Exec]

The first time I built the scratch/igc branch, I didn't have the mps
package installed locally. That's why I encountered the void-function
igc--collect error. After installing mps and rebuilding the
scratch/igc branch, the igc--collect function became available, and
(featurep 'mps) returned t.

On Mon, Aug 5, 2024 at 11:04 PM Gerd Möllmann <gerd.moellmann@gmail.com> wrote:
>
> Eval Exec <execvy@gmail.com> writes:
>
> > Hello,
> >
> > I want to help test `scratch/igc` branch on my Linux environment, then
> > I clone `scratch/igc` branch from
> > https://git.savannah.gnu.org/git/emacs.git.
> > the scratch/igc branch's commit ID is `42731228d24c37edb2dc848c3a74d5c932a817ef`
> >
> > Then I build emacs by:
> > ```bash
> > make extraclean
> > ./autogen.sh \
> >   && ./configure \
> >   --prefix=$(realpath ../emacs-build)\
> >   --with-mps \
> >   --with-imagemagick \
> >   --with-modules --with-x-toolkit=lucid --without-compress-install \
> >   --without-toolkit-scroll-bars --with-native-compilation  --with-mailutils\
> >   --with-tree-sitter --with-xinput2  \
> >   --with-dbus  --with-native-compilation=aot \
> >   --with-file-notification=inotify\
> >   && make -j20 install
> > ```
> >
> > After build success, I notice there is an interactive command:
> > `igc-collect`, so I `M-x igc-collect`, then I got:
> >
> > ```elisp
> > Debugger entered--Lisp error: (void-function igc--collect)
> >   igc--collect()
> >   igc-collect()
> >   funcall-interactively(igc-collect)
> >   command-execute(igc-collect record)
> >   #<subr execute-extended-command>(nil "igc-collect" nil)
> >   ad-Advice-execute-extended-command(#<subr execute-extended-command>
> > nil "igc-collect" nil)
> >   apply(ad-Advice-execute-extended-command #<subr
> > execute-extended-command> (nil "igc-collect" nil))
> >   execute-extended-command(nil "igc-collect" nil)
> >   funcall-interactively(execute-extended-command nil "igc-collect" nil)
> >   command-execute(execute-extended-command)
> > ```
> >
> >
> > Is this expected? Did I miss something when I building Emacs?
> > Thank you.
>
> I don't get an error. What does (featurep 'mps) say? It should give t if
> built with MPS.