From: Bob Nnamtrop <bobnnamtrop@gmail.com>
To: 5805@debbugs.gnu.org
Subject: bug#5805: 23.3 abbrev-insert needs a limited save-excursion
Date: Thu, 7 Jul 2011 08:48:36 -0600 [thread overview]
Message-ID: <CAKV0tLOxECeGtoeshQvfN869M9CwiObDAg8Rxb0niLSu4HWqwg@mail.gmail.com> (raw)
In-Reply-To: <A6A1CC87D715C143988ED94326B583D301E0C9D6@BUDMLVEM09.e2k.ad.ge.com>
I agree with the original poster that a save-excursion is needed in
abbrev-expand and by making its scope limited (see below) it will not
interfere with abbrevs that want to change point. The reason I find it
annoying the way it is now is that some modes (e.g., idlwave) use
abbrev's extensively to change keywords (e.g. capitalize them). These
are defined without the leading "\". So if I am any number of lines
with only whitespace below a keyword defined in this way (e.g. endfor)
and run expand-abbrev then the point moves even if no visible change
takes place. This is a VERY common occurrence for me since in viper
mode changing from insert to vi mode runs expand-abbrev! Placing the
save-excursion just around the part of abbrev-insert that actually
expands the abbrev fixes this problem and does not limit abbrev's from
moving the point (idlwave does this extensively as well and I've
tested that it is not impacted). Here is the diff against the
abbrev.el in emacs 23.3 (note that whitespace not adjusted).
Thanks much,
Bob
--- 23.3/abbrev.el 2011-07-07 08:16:16.000000000 -0600
+++ 23.3.fix/abbrev.el 2011-07-07 08:43:24.000000000 -0600
@@ -713,6 +713,7 @@
;; If this abbrev has an expansion, delete the abbrev
;; and insert the expansion.
(when (stringp (symbol-value abbrev))
+ (save-excursion
(goto-char wordstart)
;; Insert at beginning so that markers at the end (e.g. point)
;; are preserved.
@@ -741,7 +742,7 @@
(skip-syntax-forward "^w" (1- end))
;; Change just that.
(upcase-initials-region (point) (1+ (point)))
- (goto-char end))))))
+ (goto-char end)))))))
;; Now point is at the end of the expansion and the beginning is
;; in last-abbrev-location.
(when (symbol-function abbrev)
next prev parent reply other threads:[~2011-07-07 14:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201003291206.NAA17706@ultimate.Smallworld.co.uk>
2010-03-30 16:33 ` bug#5805: Returned mail: Cannot send message within 3 days Maguire, Andrew (GE Infra, Energy)
2010-04-10 16:04 ` bug#5805: 23.1; abbrev-insert does not protext itself with save-excursion Chong Yidong
2010-04-10 17:06 ` Maguire, Andrew (GE Infra, Energy)
2010-04-10 19:10 ` Stefan Monnier
2010-04-12 11:28 ` Maguire, Andrew (GE Infra, Energy)
2010-04-12 13:31 ` Stefan Monnier
2010-04-12 15:02 ` Maguire, Andrew (GE Infra, Energy)
2010-04-12 18:13 ` Stefan Monnier
2011-07-07 14:48 ` Bob Nnamtrop [this message]
2011-07-07 20:59 ` bug#5805: 23.3 abbrev-insert needs a limited save-excursion Stefan Monnier
2011-07-07 21:46 ` Bob Nnamtrop
2011-07-08 0:02 ` Bob Nnamtrop
2011-07-08 1:03 ` Stefan Monnier
2011-07-08 14:43 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKV0tLOxECeGtoeshQvfN869M9CwiObDAg8Rxb0niLSu4HWqwg@mail.gmail.com \
--to=bobnnamtrop@gmail.com \
--cc=5805@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.