bug#62719: 30.0.50; Eglot: `consult-imenu--normalize: Unknown imenu item: nil` caused by b1f8d98a119ab8845d25d80c480cde6e385d8749

bug#62719: 30.0.50; Eglot: `consult-imenu--normalize: Unknown imenu item: nil` caused by b1f8d98a119ab8845d25d80c480cde6e385d8749

[Casey Banner]

After b1f8d98a119ab8845d25d80c480cde6e385d8749 I'm seeing the
following error when invoking consult-imenu:

`consult-imenu--normalize: Unknown imenu item: nil`.

If I build 5e5f5b28e92a3bb927bb03c783c426c6c3baeadc (the commit
before), this error goes away. The LSP I'm using is zls. I'm not sure
if this is a bug with consult (not compatible with new changes) or a
problem with the eglot imenu changes.

In GNU Emacs 30.0.50 (build 4, x86_64-w64-mingw32) of 2023-04-07 built
 on DESKTOP-EK25TL1
Repository revision: 5e5f5b28e92a3bb927bb03c783c426c6c3baeadc
Repository branch: HEAD
Windowing system distributor 'Microsoft Corp.', version 10.0.19044
System Description: Microsoft Windows 10 Pro (v10.0.2009.19044.2728)

Configured using:
 'configure --prefix=/e/dev/emacs-src --without-dbus --without-pop
 --with-native-compilation --with-cairo --with-harfbuzz --with-xml2
 --without-compress-install --with-json 'CFLAGS=-O2 -mtune=native
 -march=native -fomit-frame-pointer -ftree-vectorize'
 PKG_CONFIG_PATH=/mingw64/lib/pkgconfig:/mingw64/share/pkgconfig'

Configured features:
ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP
NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB

Important settings:
  value of $LANG: ENC
  locale-coding-system: cp1252

Major mode: Zig

Minor modes in effect:
  eglot-inlay-hints-mode: t
  eglot--managed-mode: t
  flymake-mode: t
  display-line-numbers-mode: t
  which-key-mode: t
  solaire-global-mode: t
  global-auto-revert-mode: t
  delete-selection-mode: t
  corfu-history-mode: t
  global-corfu-mode: t
  corfu-mode: t
  vertico-multiform-mode: t
  vertico-mode: t
  minibuffer-depth-indicate-mode: t
  minions-mode: t
  doom-modeline-mode: t
  all-the-icons-completion-mode: t
  popper-echo-mode: t
  popper-mode: t
  override-global-mode: t
  global-smartscan-mode: t
  smartscan-mode: t
  global-hl-line-mode: t
  gcmh-mode: t
  recentf-mode: t
  straight-use-package-mode: t
  straight-package-neutering-mode: t
  straight-symlink-emulation-mode: t
  straight-live-modifications-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

bug#62719: 30.0.50; Eglot: `consult-imenu--normalize: Unknown imenu item: nil` caused by b1f8d98a119ab8845d25d80c480cde6e385d8749

[João Távora]

Reproduced.  Having a look.

On Fri, Apr 7, 2023 at 10:31 PM Casey Banner <kcbanner@gmail.com> wrote:
>
> After b1f8d98a119ab8845d25d80c480cde6e385d8749 I'm seeing the
> following error when invoking consult-imenu:
>
> `consult-imenu--normalize: Unknown imenu item: nil`.
>
> If I build 5e5f5b28e92a3bb927bb03c783c426c6c3baeadc (the commit
> before), this error goes away. The LSP I'm using is zls. I'm not sure
> if this is a bug with consult (not compatible with new changes) or a
> problem with the eglot imenu changes.
>
> In GNU Emacs 30.0.50 (build 4, x86_64-w64-mingw32) of 2023-04-07 built
>  on DESKTOP-EK25TL1
> Repository revision: 5e5f5b28e92a3bb927bb03c783c426c6c3baeadc
> Repository branch: HEAD
> Windowing system distributor 'Microsoft Corp.', version 10.0.19044
> System Description: Microsoft Windows 10 Pro (v10.0.2009.19044.2728)
>
> Configured using:
>  'configure --prefix=/e/dev/emacs-src --without-dbus --without-pop
>  --with-native-compilation --with-cairo --with-harfbuzz --with-xml2
>  --without-compress-install --with-json 'CFLAGS=-O2 -mtune=native
>  -march=native -fomit-frame-pointer -ftree-vectorize'
>  PKG_CONFIG_PATH=/mingw64/lib/pkgconfig:/mingw64/share/pkgconfig'
>
> Configured features:
> ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP
> NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF
> TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB
>
> Important settings:
>   value of $LANG: ENC
>   locale-coding-system: cp1252
>
> Major mode: Zig
>
> Minor modes in effect:
>   eglot-inlay-hints-mode: t
>   eglot--managed-mode: t
>   flymake-mode: t
>   display-line-numbers-mode: t
>   which-key-mode: t
>   solaire-global-mode: t
>   global-auto-revert-mode: t
>   delete-selection-mode: t
>   corfu-history-mode: t
>   global-corfu-mode: t
>   corfu-mode: t
>   vertico-multiform-mode: t
>   vertico-mode: t
>   minibuffer-depth-indicate-mode: t
>   minions-mode: t
>   doom-modeline-mode: t
>   all-the-icons-completion-mode: t
>   popper-echo-mode: t
>   popper-mode: t
>   override-global-mode: t
>   global-smartscan-mode: t
>   smartscan-mode: t
>   global-hl-line-mode: t
>   gcmh-mode: t
>   recentf-mode: t
>   straight-use-package-mode: t
>   straight-package-neutering-mode: t
>   straight-symlink-emulation-mode: t
>   straight-live-modifications-mode: t
>   tooltip-mode: t
>   global-eldoc-mode: t
>   eldoc-mode: t
>   show-paren-mode: t
>   electric-indent-mode: t
>   mouse-wheel-mode: t
>   file-name-shadow-mode: t
>   global-font-lock-mode: t
>   font-lock-mode: t
>   blink-cursor-mode: t
>   column-number-mode: t
>   line-number-mode: t
>   transient-mark-mode: t
>   auto-composition-mode: t
>   auto-encryption-mode: t
>   auto-compression-mode: t
>
>
>


-- 
João Távora

bug#62719: 30.0.50; Eglot: `consult-imenu--normalize: Unknown imenu item: nil` caused by b1f8d98a119ab8845d25d80c480cde6e385d8749

[João Távora]

Should be fixed as of 9848ae17161828190cc0ba31e89ae54a2f08a2ef

The commit message mentions bug#62718 by mistake, the bug you
just reported before this one.  Oh well.  Closing anyway.

João

bug#62719: 30.0.50; Eglot: `consult-imenu--normalize: Unknown imenu item: nil` caused by b1f8d98a119ab8845d25d80c480cde6e385d8749

[Casey Banner]

Thanks for the quick fixes! I noticed my imenu contents somewhat
changed (lost the description if something is a function vs constant),
but this might be an issue with my consult-line config.

On Fri, Apr 7, 2023 at 6:01 PM João Távora <joaotavora@gmail.com> wrote:
>
> Should be fixed as of 9848ae17161828190cc0ba31e89ae54a2f08a2ef
>
> The commit message mentions bug#62718 by mistake, the bug you
> just reported before this one.  Oh well.  Closing anyway.
>
> João

bug#62719: 30.0.50; Eglot: `consult-imenu--normalize: Unknown imenu item: nil` caused by b1f8d98a119ab8845d25d80c480cde6e385d8749

[João Távora]

On Fri, Apr 7, 2023 at 11:15 PM Casey Banner <kcbanner@gmail.com> wrote:
>
> Thanks for the quick fixes! I noticed my imenu contents somewhat
> changed (lost the description if something is a function vs constant),
> but this might be an issue with my consult-line config.

This change is intentional.  The previous implementation was confusing
IMO, at least for the original imenu interface M-x imenu.
I don't use consult-line, can you show visually what has changed?  Were
you very fond of the old layout? :-)

João

bug#62719: 30.0.50; Eglot: `consult-imenu--normalize: Unknown imenu item: nil` caused by b1f8d98a119ab8845d25d80c480cde6e385d8749

[Casey Banner]

Ok, no worries! I misspoke actually, I meant to say `consult-imenu`.

I think the new interface is good! I just thought maybe some metadata
had been unintentionally lost.

I used to say something like 'Function/Renderer dispatch` where now it
says `Renderer dispatch` (ie. a struct Renderer containing a function
dispatch). I agree that showing the type of the symbol in text was a
bit confusing.

Cheers,
Casey

On Fri, Apr 7, 2023 at 6:24 PM João Távora <joaotavora@gmail.com> wrote:
>
> On Fri, Apr 7, 2023 at 11:15 PM Casey Banner <kcbanner@gmail.com> wrote:
> >
> > Thanks for the quick fixes! I noticed my imenu contents somewhat
> > changed (lost the description if something is a function vs constant),
> > but this might be an issue with my consult-line config.
>
> This change is intentional.  The previous implementation was confusing
> IMO, at least for the original imenu interface M-x imenu.
> I don't use consult-line, can you show visually what has changed?  Were
> you very fond of the old layout? :-)
>
> João