From: "Patrick J. LoPresti" <lopresti@gmail.com>
To: emacs-devel@gnu.org
Subject: [PATCH] Fix Emacs 26.3 compilation on RHEL/CentOS 5
Date: Thu, 29 Aug 2019 10:40:14 -0700 [thread overview]
Message-ID: <CAKGkousv=OLWHP1Rc58P8QoDVj+pbaKjjthVj=-Nm1vbjDyvCQ@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
Not sure whether anyone cares about supporting ancient Linux versions...
But RHEL 5.x shipped with librsvg2 2.16.1, which did not provide the
LIBSRVG_CHECK_VERSION macro.
Simple patch below allows Emacs 26.3 to compile on RHEL/CentOS 5.
- Pat
diff -u -r emacs-26.3-orig/src/image.c emacs-26.3/src/image.c
--- emacs-26.3-orig/src/image.c 2019-06-12 03:50:42.000000000 -0700
+++ emacs-26.3/src/image.c 2019-08-29 10:13:13.000000000 -0700
@@ -9313,9 +9313,11 @@
#if GNUC_PREREQ (4, 6, 0)
#pragma GCC diagnostic push
#endif
+ #if defined(LIBSRVG_CHECK_VERSION)
#if LIBRSVG_CHECK_VERSION (2, 45, 1) && GNUC_PREREQ (4, 2, 0)
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif
+ #endif
/* Parse the contents argument and fill in the rsvg_handle. */
rsvg_handle_write (rsvg_handle, (unsigned char *) contents, size, &err);
[-- Attachment #2: Type: text/html, Size: 1058 bytes --]
next reply other threads:[~2019-08-29 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 17:40 Patrick J. LoPresti [this message]
2019-08-30 4:01 ` [PATCH] Fix Emacs 26.3 compilation on RHEL/CentOS 5 Richard Stallman
2019-08-30 8:57 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKGkousv=OLWHP1Rc58P8QoDVj+pbaKjjthVj=-Nm1vbjDyvCQ@mail.gmail.com' \
--to=lopresti@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.