Re: NS port crashes when interacting with the profiler on the menu bar

[Jimmy Yuen Ho Wong <wyuenho@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2472 bytes --]

On Wed, Jun 13, 2018 at 8:57 PM, Alan Third <alan@idiocy.org> wrote:

> On Tue, Jun 12, 2018 at 09:02:35PM +0100, Jimmy Yuen Ho Wong wrote:
> > >> Case 2 repro:
> > >>
> > >> Put this into your init file:
> > >>
> > >> (set-fontset-font "fontset-default" 'unicode "Apple Color Emoji" nil
> > >> 'append)
> > >>
> > >> Crashes on start up.
> > > Again I can’t reproduce it. Do you have anything else in your init.el
> > > that might try to display an emoji or similar? In fact, you’ve got the
> > > colour emoji patch applied, right? I wonder if that changes
> > > something...
> > Yes I have MacPort's multifonts_color patch applied.
>
> It doesn’t make any difference here. It’s odd. Can you reproduce the
> crash using -Q?
>
> Do you have symbola installed?
>

I've finally isolated my problem with this code block:

(set-fontset-font "fontset-default" 'unicode "Apple Color Emoji" nil
'append)

(use-package all-the-icons
  :config
  (add-hook 'after-change-major-mode-hook
            (lambda ()
              (let* ((icon (all-the-icons-icon-for-mode major-mode))
                     (face-prop (and (stringp icon) (purecopy
(get-text-property 0 'face icon)))))
                (when (and (stringp icon) (not (string= major-mode icon))
face-prop)
                  (setq mode-name icon))))))


>
> > >> Case 3 repro:
> > >>
> > >> 1. Goto System Preferences > Keyword and turn on Show keyboard and
> emoji
> > >> viewers in menu bar.
> > >> 2. Go to emacs NS port, turn on Show Emoji & Symbols to get the emoji
> > >> viewer out, insert some Emoji
> > >> 3. Internal Error dialog pops up, Emacs caught the crash this time.
> > > This isn’t a crash, right? I’m pretty sure this is fixed in master,
> > > specifically commit 703ac3ea1c1ce381f385469a0e88bc29d3fe83c2. I think
> > > this should be easily back ported to Emacs 26 if it’s causing crashes.
> > This is a crash, but not a fatal crash, it's the Emacs NS port or Cocoa
> > caught it and popped up an Internal Error dialog. For the dialog I can
> > choose to let it crash the entire process or continue and ignore it.
>
> Two patches attached which I believe fix this in emacs-26. I think
> they’re safe. The second patch is part of commit
> 1daac66a6eedbcbfa32ab920b5c579872d989517 on master, but it adds a new
> feature, so probably shouldn’t be applied in full.
>

Ahh this works on master. Thanks!


> --
> Alan Third
>

[-- Attachment #2: Type: text/html, Size: 3785 bytes --]