From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
To: Alan Third <alan@idiocy.org>
Cc: emacs-devel@gnu.org
Subject: Re: NS port crashes when interacting with the profiler on the menu bar
Date: Fri, 15 Jun 2018 01:51:58 +0100 [thread overview]
Message-ID: <CAKDRQS46o+6zzrtSYRcJH0y+1+XHBtQVS72DrtNxN9of_YVrBQ@mail.gmail.com> (raw)
In-Reply-To: <20180613195749.GA31667@breton.holly.idiocy.org>
[-- Attachment #1: Type: text/plain, Size: 2472 bytes --]
On Wed, Jun 13, 2018 at 8:57 PM, Alan Third <alan@idiocy.org> wrote:
> On Tue, Jun 12, 2018 at 09:02:35PM +0100, Jimmy Yuen Ho Wong wrote:
> > >> Case 2 repro:
> > >>
> > >> Put this into your init file:
> > >>
> > >> (set-fontset-font "fontset-default" 'unicode "Apple Color Emoji" nil
> > >> 'append)
> > >>
> > >> Crashes on start up.
> > > Again I can’t reproduce it. Do you have anything else in your init.el
> > > that might try to display an emoji or similar? In fact, you’ve got the
> > > colour emoji patch applied, right? I wonder if that changes
> > > something...
> > Yes I have MacPort's multifonts_color patch applied.
>
> It doesn’t make any difference here. It’s odd. Can you reproduce the
> crash using -Q?
>
> Do you have symbola installed?
>
I've finally isolated my problem with this code block:
(set-fontset-font "fontset-default" 'unicode "Apple Color Emoji" nil
'append)
(use-package all-the-icons
:config
(add-hook 'after-change-major-mode-hook
(lambda ()
(let* ((icon (all-the-icons-icon-for-mode major-mode))
(face-prop (and (stringp icon) (purecopy
(get-text-property 0 'face icon)))))
(when (and (stringp icon) (not (string= major-mode icon))
face-prop)
(setq mode-name icon))))))
>
> > >> Case 3 repro:
> > >>
> > >> 1. Goto System Preferences > Keyword and turn on Show keyboard and
> emoji
> > >> viewers in menu bar.
> > >> 2. Go to emacs NS port, turn on Show Emoji & Symbols to get the emoji
> > >> viewer out, insert some Emoji
> > >> 3. Internal Error dialog pops up, Emacs caught the crash this time.
> > > This isn’t a crash, right? I’m pretty sure this is fixed in master,
> > > specifically commit 703ac3ea1c1ce381f385469a0e88bc29d3fe83c2. I think
> > > this should be easily back ported to Emacs 26 if it’s causing crashes.
> > This is a crash, but not a fatal crash, it's the Emacs NS port or Cocoa
> > caught it and popped up an Internal Error dialog. For the dialog I can
> > choose to let it crash the entire process or continue and ignore it.
>
> Two patches attached which I believe fix this in emacs-26. I think
> they’re safe. The second patch is part of commit
> 1daac66a6eedbcbfa32ab920b5c579872d989517 on master, but it adds a new
> feature, so probably shouldn’t be applied in full.
>
Ahh this works on master. Thanks!
> --
> Alan Third
>
[-- Attachment #2: Type: text/html, Size: 3785 bytes --]
next prev parent reply other threads:[~2018-06-15 0:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAKDRQS7Dz=CPF+2vbim2T1x-CePJZvETCUcS31kgKVLSOY9pcQ@mail.gmail.com>
2018-06-12 19:39 ` NS port crashes when interacting with the profiler on the menu bar Alan Third
2018-06-12 20:02 ` Jimmy Yuen Ho Wong
2018-06-13 19:57 ` Alan Third
2018-06-15 0:51 ` Jimmy Yuen Ho Wong [this message]
2018-06-16 11:45 ` Alan Third
2018-06-17 15:54 ` Jimmy Yuen Ho Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKDRQS46o+6zzrtSYRcJH0y+1+XHBtQVS72DrtNxN9of_YVrBQ@mail.gmail.com \
--to=wyuenho@gmail.com \
--cc=alan@idiocy.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.