From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Yuta Yamada Newsgroups: gmane.emacs.devel Subject: Re: new flymake: cosmetic problem on terminal emacs Date: Tue, 24 Oct 2017 03:55:47 -0700 Message-ID: References: <87po9e3jfn.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a1144ac201bd650055c48c85d" X-Trace: blaine.gmane.org 1508842567 14137 195.159.176.226 (24 Oct 2017 10:56:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 24 Oct 2017 10:56:07 +0000 (UTC) To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 24 12:56:03 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6wsD-0001QU-Hm for ged-emacs-devel@m.gmane.org; Tue, 24 Oct 2017 12:55:53 +0200 Original-Received: from localhost ([::1]:43133 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e6wsH-0004PC-Ub for ged-emacs-devel@m.gmane.org; Tue, 24 Oct 2017 06:55:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e6wsA-0004P4-EU for emacs-devel@gnu.org; Tue, 24 Oct 2017 06:55:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e6ws9-0004PH-CS for emacs-devel@gnu.org; Tue, 24 Oct 2017 06:55:50 -0400 Original-Received: from mail-qk0-x231.google.com ([2607:f8b0:400d:c09::231]:56159) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e6ws9-0004Oy-7p for emacs-devel@gnu.org; Tue, 24 Oct 2017 06:55:49 -0400 Original-Received: by mail-qk0-x231.google.com with SMTP id x82so25628164qkb.12 for ; Tue, 24 Oct 2017 03:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=NNLyCp3nfN780LHgbpVPCiQ1fYp3GGDbHwvwTJxuun0=; b=QdmrXvnXua1h/jPLzCYDhV2ACIb+W5RLr9tyjHg0iA/259p/2rhSHTq/UDU9YAMEJH B2dtAw3uadfbmPDV0iV2YZxXgOelQq1+Y1CzLghmYm/ToHZCuoFD1CMiPCvYViZ4af0M Ve4BgyZP/8g74qjUd08NfpSHXXBvji2iIwFEVoVp9bv0wDbXPYDcs9zWuPy1SomQAQw+ FSabj+4nOPv3aLgq5vGZN21L4iBMwHLTR/Oty8yCKgtu1Dur3C9CxwySq74F+BkVql/n nu4Azm9WsCoLoPTMbW3r++Y55hOdge6o53HsZrHKE00ZeaQ2Zf8F61mtPg17fta3Knys tRhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=NNLyCp3nfN780LHgbpVPCiQ1fYp3GGDbHwvwTJxuun0=; b=htmbOF0qpw36YuIMBO7gF7lcEb4pFpMTC9Xqva/NVFMV7vi68JdExzVEqVYwtvUrGs cfL+qOpPfEdkRqaxhO7h7UTjcOZ28CwHfSnuS8dWs6YBl5vl/g9qmmK+E7zsKG9qlrbf ye/o22kFt2sagLJMKnsP0vSRZFplQtzJQd+RakK6vfEBob46efW9OTQCzYaGweW8VOVx 8lYrbuNw6l6SWace02O17IRkp5ScK5tiZdrKamqlnF/QJhJ35lS4bwIKQQrLGGtRdKqo NZaHE/qBSaiW9++YmoVzvjSKWoJbhwMea3inLWfOfQtJYhzf9x0IDJb/xHw3QlY6bOeZ 76sQ== X-Gm-Message-State: AMCzsaUonoQkdltcjFm/wO7Qjd9Zj3eU9NNrBrh5CJXj/e3gigkZWvqv VapFYSD5sRLvWgrVjFZ3ToO8DWdvAXDB+w8tDIA= X-Google-Smtp-Source: ABhQp+RWNOpeQGzpYWh2Inlin0p6hqSYLyMpcPcEk+wCYAZxDsCxP5nd7riUP+hqp8aX9GUA15rpFtwHDymzsHRFbsc= X-Received: by 10.55.203.5 with SMTP id d5mr21080501qkj.189.1508842548219; Tue, 24 Oct 2017 03:55:48 -0700 (PDT) Original-Received: by 10.140.101.52 with HTTP; Tue, 24 Oct 2017 03:55:47 -0700 (PDT) In-Reply-To: <87po9e3jfn.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219714 Archived-At: --001a1144ac201bd650055c48c85d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable For me, I just realized iverse-video is kinda visual noise to see code and I could move the error point flymake-goto-next-error, so as my personal config, I would avoid the inverse-video's configuration. But thanks Jo=C3=A3o for taking your time On Sun, Oct 22, 2017 at 3:29 PM, Jo=C3=A3o T=C3=A1vora wrote: > Yuta Yamada writes: > > > In terminal Emacs, I found not highlight state of flymake even there is > a warning. > > It can be visible if you set underline to the flymake's face. > > Since Flymake can now highlight arbitrary regions, some of those regions > can be mere whitespace, which is the case with the > elisp-flymake-checkdoc backend. > > The offending code is this (repeated in flymake-warning and flymake-note) > > (defface flymake-error > '((((supports :underline (:style wave))) > :underline (:style wave :color "Red1")) > (t > :inherit error)) > "Face used for marking error regions." > :version "24.4") > > Clearly your terminal doesn't support the first clause, and the second > one is unsuitable for whitespace. > > The simplest thing I can think of that keeps some of the "genericness" > of the last clause is adding ":inverse-video t" to it. If noone can > think of anything better, I will push this patch in some days' time. I > tried it and it looks reasonably OK. > > Jo=C3=A3o > > diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el > index 9c546fd966..7738d608e9 100644 > --- a/lisp/progmodes/flymake.el > +++ b/lisp/progmodes/flymake.el > @@ -281,6 +281,7 @@ flymake-error > '((((supports :underline (:style wave))) > :underline (:style wave :color "Red1")) > (t > + :inverse-video t > :inherit error)) > "Face used for marking error regions." > :version "24.4") > @@ -289,6 +290,7 @@ flymake-warning > '((((supports :underline (:style wave))) > :underline (:style wave :color "deep sky blue")) > (t > + :inverse-video t > :inherit warning)) > "Face used for marking warning regions." > :version "24.4") > @@ -297,6 +299,7 @@ flymake-note > '((((supports :underline (:style wave))) > :underline (:style wave :color "yellow green")) > (t > + :inverse-video t > :inherit warning)) > "Face used for marking note regions." > :version "26.1") > > > > --001a1144ac201bd650055c48c85d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
For me, I just realized iverse-video is kin= da visual noise to see code and
I could move the error point flym= ake-goto-next-error, so
as my personal config, I would avoid the i= nverse-video's configuration.
But thanks Jo=C3=A3o for taking your time

On Sun, Oct 22, = 2017 at 3:29 PM, Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> wrote:
Yuta Yamada = <sleepboy.zzz@gmail.com>= ; writes:

> In terminal Emacs, I found not highlight state of flymake even there i= s a warning.
> It can be visible if you set underline to the flymake's face.

Since Flymake can now highlight arbitrary regions, some of those reg= ions
can be mere whitespace, which is the case with the
elisp-flymake-checkdoc backend.

The offending code is this (repeated in flymake-warning and flymake-note)
=C2=A0 =C2=A0(defface flymake-error
=C2=A0 =C2=A0 =C2=A0'((((supports :underline (:style wave)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 :underline (:style wave :color "Red1"= ))
=C2=A0 =C2=A0 =C2=A0 =C2=A0(t
=C2=A0 =C2=A0 =C2=A0 =C2=A0 :inherit error))
=C2=A0 =C2=A0 =C2=A0"Face used for marking error regions."
=C2=A0 =C2=A0 =C2=A0:version "24.4")

Clearly your terminal doesn't support the first clause, and the second<= br> one is unsuitable for whitespace.

The simplest thing I can think of that keeps some of the "genericness&= quot;
of the last clause is adding ":inverse-video t" to it. If noone c= an
think of anything better, I will push this patch in some days' time. I<= br> tried it and it looks reasonably OK.

Jo=C3=A3o

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 9c546fd966..7738d608e9 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -281,6 +281,7 @@ flymake-error
=C2=A0 =C2=A0'((((supports :underline (:style wave)))
=C2=A0 =C2=A0 =C2=A0 :underline (:style wave :color "Red1"))
=C2=A0 =C2=A0 =C2=A0(t
+=C2=A0 =C2=A0 =C2=A0:inverse-video t
=C2=A0 =C2=A0 =C2=A0 :inherit error))
=C2=A0 =C2=A0"Face used for marking error regions."
=C2=A0 =C2=A0:version "24.4")
@@ -289,6 +290,7 @@ flymake-warning
=C2=A0 =C2=A0'((((supports :underline (:style wave)))
=C2=A0 =C2=A0 =C2=A0 :underline (:style wave :color "deep sky blue&quo= t;))
=C2=A0 =C2=A0 =C2=A0(t
+=C2=A0 =C2=A0 =C2=A0:inverse-video t
=C2=A0 =C2=A0 =C2=A0 :inherit warning))
=C2=A0 =C2=A0"Face used for marking warning regions."
=C2=A0 =C2=A0:version "24.4")
@@ -297,6 +299,7 @@ flymake-note
=C2=A0 =C2=A0'((((supports :underline (:style wave)))
=C2=A0 =C2=A0 =C2=A0 :underline (:style wave :color "yellow green"= ;))
=C2=A0 =C2=A0 =C2=A0(t
+=C2=A0 =C2=A0 =C2=A0:inverse-video t
=C2=A0 =C2=A0 =C2=A0 :inherit warning))
=C2=A0 =C2=A0"Face used for marking note regions."
=C2=A0 =C2=A0:version "26.1")




--001a1144ac201bd650055c48c85d--