From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Bastian Beranek Newsgroups: gmane.emacs.bugs Subject: bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames. Date: Sat, 6 Feb 2021 13:16:54 +0100 Message-ID: References: <871rdv4xog.fsf@gmail.com> <87k0rmnbqs.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000814cba05baa9ea71" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38795"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46299@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 06 13:18:37 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l8MXs-0009yy-Ru for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Feb 2021 13:18:36 +0100 Original-Received: from localhost ([::1]:50862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8MXr-0007T2-Tq for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Feb 2021 07:18:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8MXK-0007Sc-5E for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2021 07:18:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33815) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l8MXJ-0002Sk-Nk for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2021 07:18:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l8MXJ-0005Lk-Ia for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2021 07:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Bastian Beranek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Feb 2021 12:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46299 X-GNU-PR-Package: emacs Original-Received: via spool by 46299-submit@debbugs.gnu.org id=B46299.161261383819996 (code B ref 46299); Sat, 06 Feb 2021 12:18:01 +0000 Original-Received: (at 46299) by debbugs.gnu.org; 6 Feb 2021 12:17:18 +0000 Original-Received: from localhost ([127.0.0.1]:45361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8MWb-0005C7-Hb for submit@debbugs.gnu.org; Sat, 06 Feb 2021 07:17:17 -0500 Original-Received: from mail-qt1-f181.google.com ([209.85.160.181]:43957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8MWZ-00056N-Mf for 46299@debbugs.gnu.org; Sat, 06 Feb 2021 07:17:16 -0500 Original-Received: by mail-qt1-f181.google.com with SMTP id s11so3276720qtq.10 for <46299@debbugs.gnu.org>; Sat, 06 Feb 2021 04:17:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Efvgmxbis/8QmD18F3qfW8OSUvtwCZ/k4B2ND/f58lE=; b=KtHbHNl3vSRKFwuDz1XpmqCcs+eMsPsGFtHtd7OYHTLH8E626GfQwcOK0w1lU7ayUo G3aTt8xhL2/pGXE+P8zJ9NSZYJSXgNeUyyBWlccSZiUYcwQt+GGU5q0s5NqxkLRZ/VFc aZiG+mD9y45wuE2QfI5sGv552pnUdAnSnP7fwdD2RE6MRKgPvVeFvzj2HwQxnLNfan80 8s+e+U94UsvKuoC2wVfJRj+S1Ga2bs3BiF51O5m4AYBFYXOwyAN6SvOlIjtnT24Gyino 8eKc5SESwz8pzyTUyAS9ImtsOH8l5biZ49uAj2k4Kc9cxNa2IHXU9CCz9o4Ojel1an5u iDJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Efvgmxbis/8QmD18F3qfW8OSUvtwCZ/k4B2ND/f58lE=; b=pjK3zHKInLupv47Xt7DA6lZ937KPBvQD5VzGDx3rmfw1ZNn38F7lTQ6Ee60kwjtwj9 ZLxpOaueyeWugtlYeRhLUFuXF79GBzoakqHaC8ceFXtypgW/HKUWaRKw9KjMoc5Ne1Cb nCOjfYLDuIktNhKPQrzNuFGzPR1tt2hntzxLvQnv7Zk+J8+ORDLj4U6JfdEKXs07uhsO v5vrfKi6fmPpvTPg1KGsG8ZMi8n6dxTXcpsw7RMVnx9HJmSAJW48hHKjcCzPHOUXSPQQ aEfrWp36/3ENzDKkG/Y68tdvnGKcwOqHSW/9PJKZAUMcy2gxRQNqfqM+ZxOakeaDw/r9 nYKg== X-Gm-Message-State: AOAM530AAfLn2dJkJCNK10BWLMnGuKrn7HZ6BFCRBFqU4FHVK+ug42pP X6Rl7N1Yx4/J8Wu5UYyY/KqhrlrXfHlRk/WZxNQcvLdfVqo= X-Google-Smtp-Source: ABdhPJzKaBNF8PZPH0MpKcQEvss/25SkmtRca1WINGpdE8SuGcEjreeBJ0xoktXpfSzVdcA3lmmrcZlrmqrEjNZKf9I= X-Received: by 2002:ac8:6a01:: with SMTP id t1mr8547680qtr.105.1612613830125; Sat, 06 Feb 2021 04:17:10 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199428 Archived-At: --000000000000814cba05baa9ea71 Content-Type: text/plain; charset="UTF-8" Hello Juri, I added code to make the frame setting of tab-bar-lines as well as the default-frame-alist value dependent on tab-bar-show to the tab-bar-mode function. I think with this the part to which sets frame parameters in tab-bar-show :set is not needed because (tab-bar-mode 1) is called anyway, which already does everything. What do you think about the attached patch? Cheers Bastian On Fri, Feb 5, 2021 at 3:11 PM Bastian Beranek wrote: > > Hello Juri, > > I now installed your patch and I don't think it is complete yet. > > 1) Is the :set function actually used the next time emacs starts after > customizations have been written to .emacs and variables are > initialized to customized values using (custom-set-variables ...)? I > don't think it is, right? > > 2) Switching tab-bar-mode on and off seems to overwrite the > tab-bar-lines information in default-frame-alist: > > ;; If the user has given `default-frame-alist' a `tab-bar-lines' > ;; parameter, replace it. > (if (assq 'tab-bar-lines default-frame-alist) > (setq default-frame-alist > (cons (cons 'tab-bar-lines val) > (assq-delete-all 'tab-bar-lines > default-frame-alist))))) > > This code should depend on the value of tab-bar-show, right? > > Cheers > Bastian --000000000000814cba05baa9ea71 Content-Type: text/x-patch; charset="US-ASCII"; name="tab-bar.patch" Content-Disposition: attachment; filename="tab-bar.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kktokkn50 ZGlmZiAtLWdpdCBhL2xpc3AvdGFiLWJhci5lbCBiL2xpc3AvdGFiLWJhci5lbAppbmRleCA2NzIw ZDgyYjQ3Li4xNzQxMTczYmJlIDEwMDY0NAotLS0gYS9saXNwL3RhYi1iYXIuZWwKKysrIGIvbGlz cC90YWItYmFyLmVsCkBAIC0xMzksMTYgKzEzOSwyMSBAQCBQb3NzaWJsZSBtb2RpZmllciBrZXlz IGFyZSBgY29udHJvbCcsIGBtZXRhJywgYHNoaWZ0JywgYGh5cGVyJywgYHN1cGVyJyBhbmQKICAg Omdsb2JhbCB0CiAgIDs7IEl0J3MgZGVmaW5lZCBpbiBDL2N1cy1zdGFydCwgdGhpcyBzdG9wcyB0 aGUgZC1tLW0gbWFjcm8gZGVmaW5pbmcgaXQgYWdhaW4uCiAgIDp2YXJpYWJsZSB0YWItYmFyLW1v ZGUKLSAgKGxldCAoKHZhbCAoaWYgdGFiLWJhci1tb2RlIDEgMCkpKQorCisgIDs7IFNldCBmcmFt ZSBwYXJhbWV0ZXJzLgorICAobGV0ICgoZGVmYXVsdHZhbCAoaWYgKGFuZCB0YWItYmFyLW1vZGUg dGFiLWJhci1zaG93KSAxIDApKSkKICAgICAoZG9saXN0IChmcmFtZSAoZnJhbWUtbGlzdCkpCi0g ICAgICAoc2V0LWZyYW1lLXBhcmFtZXRlciBmcmFtZSAndGFiLWJhci1saW5lcyB2YWwpKQotICAg IDs7IElmIHRoZSB1c2VyIGhhcyBnaXZlbiBgZGVmYXVsdC1mcmFtZS1hbGlzdCcgYSBgdGFiLWJh ci1saW5lcycKLSAgICA7OyBwYXJhbWV0ZXIsIHJlcGxhY2UgaXQuCi0gICAgKGlmIChhc3NxICd0 YWItYmFyLWxpbmVzIGRlZmF1bHQtZnJhbWUtYWxpc3QpCi0gICAgICAgIChzZXRxIGRlZmF1bHQt ZnJhbWUtYWxpc3QKLSAgICAgICAgICAgICAgKGNvbnMgKGNvbnMgJ3RhYi1iYXItbGluZXMgdmFs KQotICAgICAgICAgICAgICAgICAgICAoYXNzcS1kZWxldGUtYWxsICd0YWItYmFyLWxpbmVzCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGVmYXVsdC1mcmFtZS1hbGlzdCkp KSkpCisgICAgICAobGV0ICgoZnJhbWV2YWwgKGlmIChuYXRudW1wIHRhYi1iYXItc2hvdykKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgKGlmIChhbmQgZGVmYXVsdHZhbAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAoPiAobGVuZ3RoIChmdW5jYWxsIHRhYi1iYXItdGFicy1m dW5jdGlvbiBmcmFtZSkpIHRhYi1iYXItc2hvdykpCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAxIDApCisgICAgICAgICAgICAgICAgICAgICAgICBkZWZhdWx0dmFsKSkpCisgICAgICAg IChzZXQtZnJhbWUtcGFyYW1ldGVyIGZyYW1lICd0YWItYmFyLWxpbmVzIGZyYW1ldmFsKSkpCisg ICAgKGxldCAoKG5ld2ZyYW1ldmFsIChpZiAoYW5kIGRlZmF1bHR2YWwgKGVxIHRhYi1iYXItc2hv dyB0KSkgMSAwKSkpCisgICAgICAoc2V0cSBkZWZhdWx0LWZyYW1lLWFsaXN0CisgICAgICAgICAg ICAoY29ucyAoY29ucyAndGFiLWJhci1saW5lcyBuZXdmcmFtZXZhbCkKKyAgICAgICAgICAgICAg ICAgIChhc3NxLWRlbGV0ZS1hbGwgJ3RhYi1iYXItbGluZXMgZGVmYXVsdC1mcmFtZS1hbGlzdCkp KSkpCisKICAgKHdoZW4gdGFiLWJhci1tb2RlCiAgICAgKHRhYi1iYXItLWxvYWQtYnV0dG9ucykp CiAgIChpZiB0YWItYmFyLW1vZGUKQEAgLTI1MSwxNiArMjU2LDcgQEAgeW91IGNhbiB1c2UgdGhl IGNvbW1hbmQgYHRvZ2dsZS1mcmFtZS10YWItYmFyJy4iCiAgIDpzZXQgKGxhbWJkYSAoc3ltIHZh bCkKICAgICAgICAgIChzZXQtZGVmYXVsdCBzeW0gdmFsKQogICAgICAgICAgOzsgUHJlbG9hZCBi dXR0b24gaW1hZ2VzCi0gICAgICAgICAodGFiLWJhci1tb2RlIDEpCi0gICAgICAgICA7OyBUaGVu IGhhbmRsZSBlYWNoIGZyYW1lIGluZGl2aWR1YWxseQotICAgICAgICAgKGRvbGlzdCAoZnJhbWUg KGZyYW1lLWxpc3QpKQotICAgICAgICAgICAoc2V0LWZyYW1lLXBhcmFtZXRlcgotICAgICAgICAg ICAgZnJhbWUgJ3RhYi1iYXItbGluZXMKLSAgICAgICAgICAgIChpZiAob3IgKGVxIHZhbCB0KQot ICAgICAgICAgICAgICAgICAgICAoYW5kIChuYXRudW1wIHZhbCkKLSAgICAgICAgICAgICAgICAg ICAgICAgICAoPiAobGVuZ3RoIChmdW5jYWxsIHRhYi1iYXItdGFicy1mdW5jdGlvbiBmcmFtZSkp Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgdmFsKSkpCi0gICAgICAgICAgICAgICAgMSAw KSkpKQorICAgICAgICAgKHRhYi1iYXItbW9kZSAxKSkKICAgOmdyb3VwICd0YWItYmFyCiAgIDp2 ZXJzaW9uICIyNy4xIikKIAo= --000000000000814cba05baa9ea71--