all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: nitish chandra <nitishchandrachinta@gmail.com>
To: 25150@debbugs.gnu.org
Subject: bug#25150: [PATCH] Removing ] from message-cite-prefix-regexp
Date: Tue, 20 Dec 2016 00:52:27 +0530	[thread overview]
Message-ID: <CAK88tCHUuo9dAGmT2G8bFeDDYMK3zk5UyS=DKeCZTWd-J1ia-A@mail.gmail.com> (raw)
In-Reply-To: <86r35gamai.fsf@sungevity.com>


[-- Attachment #1.1: Type: text/plain, Size: 343 bytes --]

Hi,

Following is the patch to remove ] character from
message-cite-prefix-regexp. Code wise, it just removes the ] character from
the regexp.

I've a question about the code though. Why is the same variable defined in
both lisp/ldefs-boot.el and lisp/mail/sendmail.el? I changed the default
variable value in both the places.

Thanks,
Nitish

[-- Attachment #1.2: Type: text/html, Size: 457 bytes --]

[-- Attachment #2: 0001-Fix-Bug-25150.patch --]
[-- Type: text/x-patch, Size: 1531 bytes --]

From b1b80c8d9b35753c428b655c9b415df78611813e Mon Sep 17 00:00:00 2001
From: nitishch <nitishchandrachinta@gmail.com>
Date: Tue, 20 Dec 2016 00:27:40 +0530
Subject: [PATCH] Fix Bug#25150

---
 lisp/ldefs-boot.el    | 2 +-
 lisp/mail/sendmail.el | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/ldefs-boot.el b/lisp/ldefs-boot.el
index 406f045..3fbfdc6 100644
--- a/lisp/ldefs-boot.el
+++ b/lisp/ldefs-boot.el
@@ -29184,7 +29184,7 @@ mail-citation-hook
 
 (custom-autoload 'mail-citation-hook "sendmail" t)
 
-(defvar mail-citation-prefix-regexp (purecopy "\\([ 	]*\\(\\w\\|[_.]\\)+>+\\|[ 	]*[]>|]\\)+") "\
+(defvar mail-citation-prefix-regexp (purecopy "\\([ 	]*\\(\\w\\|[_.]\\)+>+\\|[ 	]*[>|]\\)+") "\
 Regular expression to match a citation prefix plus whitespace.
 It should match whatever sort of citation prefixes you want to handle,
 with whitespace before and after; it should also match just whitespace.
diff --git a/lisp/mail/sendmail.el b/lisp/mail/sendmail.el
index 3d22209..b8cf632 100644
--- a/lisp/mail/sendmail.el
+++ b/lisp/mail/sendmail.el
@@ -273,7 +273,7 @@ mail-citation-header
 
 ;;;###autoload
 (defcustom mail-citation-prefix-regexp
-  (purecopy "\\([ \t]*\\(\\w\\|[_.]\\)+>+\\|[ \t]*[]>|]\\)+")
+  (purecopy "\\([ \t]*\\(\\w\\|[_.]\\)+>+\\|[ \t]*[>|]\\)+")
   "Regular expression to match a citation prefix plus whitespace.
 It should match whatever sort of citation prefixes you want to handle,
 with whitespace before and after; it should also match just whitespace.
-- 
2.9.0


  parent reply	other threads:[~2016-12-19 19:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-09 20:18 bug#25150: 26.0.50; sexp motion commands don't work reliably in message-mode Sean McAfee
2016-12-10 11:25 ` bug#25150: nitish chandra
2016-12-16 20:08 ` bug#25150: Possible reason for this bug nitish chandra
2016-12-18 14:23   ` npostavs
2016-12-18  8:58 ` bug#25150: Why is ] included in message-cite-prefix-regexp? nitish chandra
2016-12-19 19:22 ` nitish chandra [this message]
2016-12-19 19:43   ` bug#25150: [PATCH] Removing ] from message-cite-prefix-regexp Eli Zaretskii
2016-12-20  5:04     ` nitish chandra
2019-09-23 10:03       ` Lars Ingebrigtsen
2017-01-02 16:02 ` bug#25150: Patch review nitish chandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK88tCHUuo9dAGmT2G8bFeDDYMK3zk5UyS=DKeCZTWd-J1ia-A@mail.gmail.com' \
    --to=nitishchandrachinta@gmail.com \
    --cc=25150@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.