From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Pavel Repin Newsgroups: gmane.emacs.bugs Subject: bug#11119: 23.4; Xcode 4.3.2 dislikes valueless return statements in non-void functions Date: Thu, 29 Mar 2012 10:56:03 -0700 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: dough.gmane.org 1333043868 2124 80.91.229.3 (29 Mar 2012 17:57:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 29 Mar 2012 17:57:48 +0000 (UTC) Cc: "11119@debbugs.gnu.org" <11119@debbugs.gnu.org> To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 29 19:57:47 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SDJbV-0003eY-F2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 29 Mar 2012 19:57:45 +0200 Original-Received: from localhost ([::1]:59669 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDJbU-0003xf-Uc for geb-bug-gnu-emacs@m.gmane.org; Thu, 29 Mar 2012 13:57:44 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDJbS-0003x6-I4 for bug-gnu-emacs@gnu.org; Thu, 29 Mar 2012 13:57:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDJbQ-0004hk-NB for bug-gnu-emacs@gnu.org; Thu, 29 Mar 2012 13:57:42 -0400 Original-Received: from [140.186.70.43] (port=38378 helo=debbugs.gnu.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDJbQ-0004en-Hy for bug-gnu-emacs@gnu.org; Thu, 29 Mar 2012 13:57:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SDK5m-0001fy-6O for bug-gnu-emacs@gnu.org; Thu, 29 Mar 2012 14:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pavel Repin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Mar 2012 18:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11119 X-GNU-PR-Package: emacs,ns X-GNU-PR-Keywords: Original-Received: via spool by 11119-submit@debbugs.gnu.org id=B11119.13330456836370 (code B ref 11119); Thu, 29 Mar 2012 18:29:02 +0000 Original-Received: (at 11119) by debbugs.gnu.org; 29 Mar 2012 18:28:03 +0000 Original-Received: from localhost ([127.0.0.1]:45210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDK4o-0001eW-7t for submit@debbugs.gnu.org; Thu, 29 Mar 2012 14:28:02 -0400 Original-Received: from mail-bk0-f44.google.com ([209.85.214.44]:42478) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDK4K-0001dk-0z for 11119@debbugs.gnu.org; Thu, 29 Mar 2012 14:28:00 -0400 Original-Received: by bkuw5 with SMTP id w5so2213877bku.3 for <11119@debbugs.gnu.org>; Thu, 29 Mar 2012 10:56:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=1Z4Gqe67dbSPe71AdS+49nYCZsgNAtUQ3HokjVI13PY=; b=GfKCwjwvNLcpNBxjIJwtHK4XXvdtGzdqjTjeRuf7Edu1Dv4etnscRIcdGBgw90iJ5e wQ5xJCTiBkJ2BHLwZzpok9BZv1eDxhQx2V410oyEsQiTKupFsm1D/XuOay8C6clIyzqu v/vmvXk88PlPtmx1Xb4xXj5Uuo+AN4iWXCV3bmUUGmp2yXjOIRpQvk1RzS3AEnC8tGn7 WNQz8U/uSDYzVjhuDze0qJKZLU1hFqhWwcPQ3xaA7o87jWqzQuX08wnVKrFrb6OGpi5T ocj56739rvKlpIVJbARqPnwtDXrz/h7O9HmhQtUlLfmKKJQOu62K+gYMWYY5FAPx1oBh q/DQ== Original-Received: by 10.204.155.84 with SMTP id r20mr14307417bkw.35.1333043763045; Thu, 29 Mar 2012 10:56:03 -0700 (PDT) Original-Received: by 10.204.12.214 with HTTP; Thu, 29 Mar 2012 10:56:03 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58291 Archived-At: On Mar 28, 2012, at 20:58, Glenn Morris wrote: > Thanks. I looked at the patch (which is small; why not include it in > your original report?). My bad. The patch is pasted below. > It seems to me that this is already fixed in the > Emacs trunk for 24.1, by this: > > http://lists.gnu.org/archive/html/emacs-devel/2010-11/msg00133.html Yes this is great it was fixed in trunk (my patch is almost identical). Any chance it might be applied to 23.4 branch? The patch against 23.4 tarball: diff -ur a/src/nsfont.m b/src/nsfont.m --- a/src/nsfont.m 2012-01-11 04:35:01.000000000 -0800 +++ b/src/nsfont.m 2012-01-11 04:35:01.000000000 -0800 @@ -1278,7 +1278,7 @@ } CGContextRestoreGState (gcontext); - return; + return 0; } #endif /* NS_IMPL_COCOA */ diff -ur a/src/nsimage.m b/src/nsimage.m --- a/src/nsimage.m 2012-01-11 04:35:01.000000000 -0800 +++ b/src/nsimage.m 2012-01-11 04:35:01.000000000 -0800 @@ -334,7 +334,7 @@ NSColor *rgbColor; if (bmRep == nil || color == nil) - return; + return nil; if ([color colorSpaceName] != NSCalibratedRGBColorSpace) rgbColor = [color colorUsingColorSpaceName: NSCalibratedRGBColorSpace]; diff -ur a/src/nsterm.m b/src/nsterm.m --- a/src/nsterm.m 2012-01-11 04:35:01.000000000 -0800 +++ b/src/nsterm.m 2012-01-11 04:35:01.000000000 -0800 @@ -5431,7 +5431,7 @@ NSTRACE (performDragOperation); if (!emacs_event) - return; + return NO; position = [self convertPoint: [sender draggingLocation] fromView: nil]; x = lrint (position.x); y = lrint (position.y);