From: Pavel Repin <prepin@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: "11119@debbugs.gnu.org" <11119@debbugs.gnu.org>
Subject: bug#11119: 23.4; Xcode 4.3.2 dislikes valueless return statements in non-void functions
Date: Thu, 29 Mar 2012 10:56:03 -0700 [thread overview]
Message-ID: <CAJyinQCG5Qo58ety4U4_cpSS0mHCqU+t5DrZW0qdGOJfxYAwVQ@mail.gmail.com> (raw)
In-Reply-To: <cu1uoc3vof.fsf@fencepost.gnu.org>
On Mar 28, 2012, at 20:58, Glenn Morris <rgm@gnu.org> wrote:
> Thanks. I looked at the patch (which is small; why not include it in
> your original report?).
My bad. The patch is pasted below.
> It seems to me that this is already fixed in the
> Emacs trunk for 24.1, by this:
>
> http://lists.gnu.org/archive/html/emacs-devel/2010-11/msg00133.html
Yes this is great it was fixed in trunk (my patch is almost identical).
Any chance it might be applied to 23.4 branch?
The patch against 23.4 tarball:
diff -ur a/src/nsfont.m b/src/nsfont.m
--- a/src/nsfont.m 2012-01-11 04:35:01.000000000 -0800
+++ b/src/nsfont.m 2012-01-11 04:35:01.000000000 -0800
@@ -1278,7 +1278,7 @@
}
CGContextRestoreGState (gcontext);
- return;
+ return 0;
}
#endif /* NS_IMPL_COCOA */
diff -ur a/src/nsimage.m b/src/nsimage.m
--- a/src/nsimage.m 2012-01-11 04:35:01.000000000 -0800
+++ b/src/nsimage.m 2012-01-11 04:35:01.000000000 -0800
@@ -334,7 +334,7 @@
NSColor *rgbColor;
if (bmRep == nil || color == nil)
- return;
+ return nil;
if ([color colorSpaceName] != NSCalibratedRGBColorSpace)
rgbColor = [color colorUsingColorSpaceName: NSCalibratedRGBColorSpace];
diff -ur a/src/nsterm.m b/src/nsterm.m
--- a/src/nsterm.m 2012-01-11 04:35:01.000000000 -0800
+++ b/src/nsterm.m 2012-01-11 04:35:01.000000000 -0800
@@ -5431,7 +5431,7 @@
NSTRACE (performDragOperation);
if (!emacs_event)
- return;
+ return NO;
position = [self convertPoint: [sender draggingLocation] fromView: nil];
x = lrint (position.x); y = lrint (position.y);
next prev parent reply other threads:[~2012-03-29 17:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 23:42 bug#11119: 23.4; Xcode 4.3.2 dislikes valueless return statements in non-void functions Pavel Repin
2012-03-29 3:58 ` Glenn Morris
2012-03-29 17:56 ` Pavel Repin [this message]
2012-04-01 6:25 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJyinQCG5Qo58ety4U4_cpSS0mHCqU+t5DrZW0qdGOJfxYAwVQ@mail.gmail.com \
--to=prepin@gmail.com \
--cc=11119@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.