From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "kassick@gmail.com" Newsgroups: gmane.emacs.bugs Subject: bug#71654: [PATCH] Fix display-buffer-override-next-command Date: Wed, 19 Jun 2024 18:54:35 -0300 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000002a8ec6061b453f05" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9350"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71654-done@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 20 00:41:37 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sK3zi-0002AA-CL for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Jun 2024 00:41:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sK3zC-00017F-3f; Wed, 19 Jun 2024 18:41:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sK3z9-00016L-Vf for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 18:41:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sK3z9-0001Lo-MX for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 18:40:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sK3zD-0005VM-1S for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 18:41:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "kassick@gmail.com" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2024 22:41:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71654 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71654-done@debbugs.gnu.org id=D71654.171883685921122 (code D ref 71654); Wed, 19 Jun 2024 22:41:03 +0000 Original-Received: (at 71654-done) by debbugs.gnu.org; 19 Jun 2024 22:40:59 +0000 Original-Received: from localhost ([127.0.0.1]:33760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK3z8-0005UV-JK for submit@debbugs.gnu.org; Wed, 19 Jun 2024 18:40:59 -0400 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:48365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK3HY-00044Z-1O for 71654-done@debbugs.gnu.org; Wed, 19 Jun 2024 17:55:56 -0400 Original-Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-42121d27861so2786255e9.0 for <71654-done@debbugs.gnu.org>; Wed, 19 Jun 2024 14:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718834087; x=1719438887; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9D2CPYbMZfW3APb9RKwI3iYOtwB2vKZHpUiiKKgrTmw=; b=RHyw6kI+LfHLUjUtwXDAQVDT8AuHEygoewiLgJqWd16u7x+pTYSHcSBnAV43QYDqo3 jg5f/HFhziu3ZXfrgfcJExmMFzBRzEDvnDjFMIbjdfNncx3/S0+3eQ6zyIEX5oSycZCM OXe3nYLjHvEECmAGxO/lEDnevbRAnNoXIRUgU3ozjr5+iQ5NrSuZybXeTIuXkyRtRrnI a+RAR/l7hdPwAYdfoSfzjCPd4YiAiA3rCpvabRQg648fYUMq1/yYEo2b824DmhRw0qX8 Iz8rXFGgGic3dBllD+F+f8ukV3bPDWRmuxwG9qJcwMSZ3CZ2JqynKshZQxrTcHH+Gp/0 ciWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718834087; x=1719438887; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9D2CPYbMZfW3APb9RKwI3iYOtwB2vKZHpUiiKKgrTmw=; b=d2pLPnbag12z9UA+QwI3+y3kdCuhlb9aRrBgCC97vPyFqqv7vMUo0m07x3pWugHLt2 F2rSSDKZLTpiWyPmAiZKl2ia5taunecv5OFN0TRo8vhLwJjBxNDKzAyrPJYDBcO+y4yG kQC53+Uq4AmsYp9CXOwzwyZ8Pso3afNM2+LrHZbf0uazXwCy3XYIwxUG1d3qNLUao/WI RjfFCP15taY14o2GcCvjEjN8K4ZVZzcv9+M8+cBZn/Mdk+8nCXTCkRWsCd0gOEyrDaxG f56Z8EDzz+9BNk8piRCeEIm8DqVk5dTPUgwILNxj0FESZ7ArVWidtEDgIXoJ8GIZjDnR eEaA== X-Gm-Message-State: AOJu0YxH7VbtyDZUpe6iTJvhyOcp0nzDJ8yJeOChMtCKRG3vHTVRCJ9o N6NH42BPwdzB4BJVlKjXAHtv6PETWl5j36wM+7Sf8dv8GEiJOrpVIG0t+OtJx1squYfJ494Zhkr La4gnraArITnO08813NeaVYGuHAJoQQ== X-Google-Smtp-Source: AGHT+IGAKRYTqRcY0+WilUzGX2uynuhd5fCYHvPe6VzJ/euJFsScayZc7FjqmQJGmPgS9t+KJEhd1fr3xhK/d+USs58= X-Received: by 2002:a5d:6449:0:b0:360:71a5:da1e with SMTP id ffacd0b85a97d-363175b7dafmr2382594f8f.16.1718834086708; Wed, 19 Jun 2024 14:54:46 -0700 (PDT) In-Reply-To: X-Mailman-Approved-At: Wed, 19 Jun 2024 18:40:55 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287518 Archived-At: --0000000000002a8ec6061b453f05 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Awesome! Any chance of cherry-picking it on emacs-29? Em qua., 19 de jun. de 2024 =C3=A0s 18:32, Andrea Corallo escreveu: > "kassick@gmail.com" writes: > > > When display-buffer-overriding-action's car is set to a function instea= d > of a list, display-buffer-override-next-command > > must ensure that the car is a list before pushing a new element to it, > otherwise the car will become a itself a cons-cell > > and the clear-fun will trigger a wrong-type-argumen error when trying t= o > delq the action. > > > > The error can be triggered by using some minor mode that updates > display-buffer-override-next-command (such as > > purpose-mode) and then calling other-window-prefix. > > Hi Rodrigo, > > the patch LGTM so I applied it after some indentation massage to master. > > Closing then, happy to reopen if some more work is needed. > > Thanks > > Andrea > --=20 Rodrigo Virote Kassick ------------------------------------------------------------ --0000000000002a8ec6061b453f05 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Awesome!

Any chance of cherr= y-picking it on emacs-29?

Em qua., 19 de jun. de 2024 =C3=A0s 18:3= 2, Andrea Corallo <acorallo@gnu.org<= /a>> escreveu:
kassick@gmai= l.com" <= kassick@gmail.com> writes:

> When display-buffer-overriding-action's car is set to a function i= nstead of a list, display-buffer-override-next-command
> must ensure that the car is a list before pushing a new element to it,= otherwise the car will become a itself a cons-cell
> and the clear-fun will trigger a wrong-type-argumen error when trying = to delq the action.
>
> The error can be triggered by using some minor mode that updates displ= ay-buffer-override-next-command (such as
> purpose-mode) and then calling other-window-prefix.

Hi Rodrigo,

the patch LGTM so I applied it after some indentation massage to master.
Closing then, happy to reopen if some more work is needed.

Thanks

=C2=A0 Andrea


--
Rodrigo Virote Kassick
---------------------------------------------= ---------------
--0000000000002a8ec6061b453f05--