From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "kassick@gmail.com" Newsgroups: gmane.emacs.bugs Subject: bug#71654: [PATCH] Fix display-buffer-override-next-command Date: Wed, 19 Jun 2024 12:20:19 -0300 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000037ef58061b3fbd07" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23398"; mail-complaints-to="usenet@ciao.gmane.io" To: 71654@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 19 20:50:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sK0Nv-0005sE-CQ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Jun 2024 20:50:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sK0Nb-0001BF-VQ; Wed, 19 Jun 2024 14:49:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sK0Nb-0001B1-6U for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 14:49:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sK0Na-0003A6-Tj for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 14:49:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sK0Ne-0003U6-9h for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 14:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "kassick@gmail.com" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2024 18:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71654 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.171882295613285 (code B ref -1); Wed, 19 Jun 2024 18:50:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Jun 2024 18:49:16 +0000 Original-Received: from localhost ([127.0.0.1]:55031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK0Mt-0003SA-KH for submit@debbugs.gnu.org; Wed, 19 Jun 2024 14:49:16 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:45684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJx72-0004YA-6E for submit@debbugs.gnu.org; Wed, 19 Jun 2024 11:20:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJx6x-0003AQ-OF for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 11:20:36 -0400 Original-Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJx6w-0004aI-1f for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 11:20:35 -0400 Original-Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4218314a6c7so56796875e9.0 for ; Wed, 19 Jun 2024 08:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718810432; x=1719415232; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=gyrdpSnHm6l7NdGcXdDUJV6FAB+hcZMLMTMIoZzdZjU=; b=Vj2+lVzums/w9WURUlwJrE5vf5Vupq/mO8fm7UBexbo1bA1FsRClLvzzXSiFiRoAl1 /xQhVCgrOl42wwZbCr1ynFYXBNs2mCXtndThtjMtq8oMbBlGKgzk85/aq5CSCHqaGBFR dE3Zuq8ujBAjay7GuSkgEosf6cxR36rLPQ9fN5WGG+Cdris7MQBtl8ce+/ktPY5P4B+N XlkqSsTLz18RcOY4f1f2Bo4xR1sXXcGRwKCkjrBvhbkZ8CJDrF0hZQDcEsHtlgMUEOsE /N9CJq/mVwHhrgDghGgoG22UAbA2+bhM4Rmx4FY3jCBjEIJ9s6eNxpPfVeUVYzrAvdrm yFGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718810432; x=1719415232; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gyrdpSnHm6l7NdGcXdDUJV6FAB+hcZMLMTMIoZzdZjU=; b=La6LPr7hO/vbYkT3gYzIZ2ewjUgcB3vF4vl9viSfTykjl6lh5SQ78jSYnFw///hRDH MC4R7+GWNUX/qi3cCOgWbLKwD5rtRAJimZMiGfi/6KFjf4ylJMeruunGwK3+pwin88Wv XakCWaIAGLemclht7WPz2xnpkL7T8JgARhiDe0d3izSY87+ImaEmJhvgSbGIsvVWhqTW 49//31jwYtxvq4bq/a795hDZ6ofR8JQ+KazU1cyQgzWxVkKaVk+TRDabXPDm/WmoxilZ oaYFDm9ksTixvmkDns/A13T6s2CU77oUquVh4Q8+b+iiSjsTGarXLM1FGI7570SeR0cm pVOg== X-Gm-Message-State: AOJu0YxMs/PYTZV4pX2hs+Nh/JAs85V7EakaFzuz+zNPETsSR+4UqEBo 3MO5jxQE46VUZzEuFN88vipZ0pHt9KKsHc4O+9leAQoJsjlVbErypwl1BhjMJQnrN/h9Xl8vbuN JrzzhYk6tHcwJM3mhh2aFlowjH93Vi9wt X-Google-Smtp-Source: AGHT+IFwOfTGy91OUTE94irZcus71bgeFcEzf31nWlsXKF9XkAkg+5umDFAnFznkX5ya9lu8eEI0DKb2r8QLxF3y/y0= X-Received: by 2002:adf:fd0e:0:b0:360:9223:b07 with SMTP id ffacd0b85a97d-36319a8574fmr2070906f8f.66.1718810431704; Wed, 19 Jun 2024 08:20:31 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=kassick@gmail.com; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 19 Jun 2024 14:49:14 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287497 Archived-At: --00000000000037ef58061b3fbd07 Content-Type: multipart/alternative; boundary="00000000000037ef57061b3fbd05" --00000000000037ef57061b3fbd05 Content-Type: text/plain; charset="UTF-8" When display-buffer-overriding-action's car is set to a function instead of a list, display-buffer-override-next-command must ensure that the car is a list before pushing a new element to it, otherwise the car will become a itself a cons-cell and the clear-fun will trigger a wrong-type-argumen error when trying to delq the action. The error can be triggered by using some minor mode that updates display-buffer-override-next-command (such as purpose-mode) and then calling other-window-prefix. The patch was created using the `emacs-29` branch. ---- In GNU Emacs 29.3.50 (build 8, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0) of 2024-05-27 built on thnkpd System Description: Fedora Linux 39 (Workstation Edition) Configured using: 'configure --build x86_64-linux-gnu --prefix=/usr/local --sharedstatedir=/var/lib --localstatedir=/var/lib --enable-libsystemd --with-pop=yes --build x86_64-linux-gnu --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/29/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --without-gconf --with-mailutils --with-cairo --with-x=yes --with-x-toolkit=gtk3 --with-pgtk --with-toolkit-scroll-bars --without-xwidgets --with-imagemagick --with-native-compilation --with-tree-sitter --with-xinput2' -- Rodrigo Virote Kassick ------------------------------------------------------------ --00000000000037ef57061b3fbd05 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
When=C2=A0display-buffer-overriding-action's car = is set to a function instead of a list, display-buffer-override-next-comman= d must ensure that the car is a list before pushing a new element to it, ot= herwise the car will become a itself a cons-cell and the clear-fun will tri= gger a wrong-type-argumen error when trying to delq the action.
<= br>
The error can be triggered by using some minor mode that upda= tes=C2=A0display-buffer-override-next-command (such as purpose-mode) and th= en calling other-window-prefix.

The patch= was created using the `emacs-29` branch.

----
=
In GNU Emacs 29.3.50 (build 8, x86_64-pc-linux-gnu, GTK+ Version
=C2= =A03.24.41, cairo version 1.18.0) of 2024-05-27 built on thnkpd
System D= escription: Fedora Linux 39 (Workstation Edition)

Configured using:<= br>=C2=A0'configure --build x86_64-linux-gnu --prefix=3D/usr/local
= =C2=A0--sharedstatedir=3D/var/lib --localstatedir=3D/var/lib --enable-libsy= stemd
=C2=A0--with-pop=3Dyes --build x86_64-linux-gnu
=C2=A0--enable-= locallisppath=3D/etc/emacs:/usr/local/share/emacs/29/site-lisp:/usr/local/s= hare/emacs/site-lisp:/usr/share/emacs/29/site-lisp:/usr/share/emacs/site-li= sp
=C2=A0--with-sound=3Dalsa --without-gconf --with-mailutils --with-cai= ro
=C2=A0--with-x=3Dyes --with-x-toolkit=3Dgtk3 --with-pgtk
=C2=A0--w= ith-toolkit-scroll-bars --without-xwidgets --with-imagemagick
=C2=A0--wi= th-native-compilation --with-tree-sitter --with-xinput2'

--
Rodrigo V= irote Kassick
----------------------------------------------------------= --
--00000000000037ef57061b3fbd05-- --00000000000037ef58061b3fbd07 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-display-buffer-override-next-command.patch" Content-Disposition: attachment; filename="0001-Fix-display-buffer-override-next-command.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lxlz9tkw0 RnJvbSA4ZmExMWE0NTE5NDliZTc0M2Q0YmRlZGQ1MTE3NTcxZDkxMmUyMjA5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2RyaWdvIEthc3NpY2sgPGthc3NpY2tAZ21haWwuY29tPgpE YXRlOiBXZWQsIDE5IEp1biAyMDI0IDExOjQ2OjM1IC0wMzAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IGRpc3BsYXktYnVmZmVyLW92ZXJyaWRlLW5leHQtY29tbWFuZAoKKiBsaXNwL3dpbmRvdy5lbCAo ZGlzcGxheS1idWZmZXItb3ZlcnJpZGUtbmV4dC1jb21tYW5kKToKZGlzcGxheS1idWZmZXItb3Zl cnJpZGluZy1hY3Rpb24ncyBjYXIgY2FuIGJlIGVpdGhlciBhIGZ1bmN0aW9uIG9yIGEKbGlzdCBv ZiBmdW5jdGlvbnMuIFdoZW4gYSBmdW5jdGlvbiwKKHB1c2ggYWN0aW9uIChjYXIgZGlzcGxheS1i dWZmZXItb3ZlcnJpZGluZy1hY3Rpb24pKSB3aWxsIGNyZWF0ZSBhCmNvbnMtY2VsbCAoYWN0aW9u IC4gZnVuY3Rpb24pICBpbnN0ZWFkIG9mIGEgbGlzdC4gSW4gdGhlCmNsZWFyLWZ1biBjYWxsYmFj aywgdHJ5aW5nIHRvCihkZWxxIGFjdGlvbiAoY2FyIGRpc3BsYXktYnVmZmVyLW92ZXJyaWRpbmct YWN0aW9uKSkgY2F1c2VzIGFuCndyb25nLXR5cGUtYXJndW1lbnQgZXJyb3IuCi0tLQogbGlzcC93 aW5kb3cuZWwgfCAyICsrCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCgpkaWZmIC0t Z2l0IGEvbGlzcC93aW5kb3cuZWwgYi9saXNwL3dpbmRvdy5lbAppbmRleCAxM2ZlMWZlYmExMC4u OGRiMDU4NGM5MTAgMTAwNjQ0Ci0tLSBhL2xpc3Avd2luZG93LmVsCisrKyBiL2xpc3Avd2luZG93 LmVsCkBAIC05MTA5LDYgKzkxMDksOCBAQCBkaXNwbGF5LWJ1ZmZlci1vdmVycmlkZS1uZXh0LWNv bW1hbmQKICAgICAod2hlbiBlY2hvZnVuCiAgICAgICAoYWRkLWhvb2sgJ3ByZWZpeC1jb21tYW5k LWVjaG8ta2V5c3Ryb2tlcy1mdW5jdGlvbnMgZWNob2Z1bikpCiAgICAgKHNldHEgc3dpdGNoLXRv LWJ1ZmZlci1vYmV5LWRpc3BsYXktYWN0aW9ucyB0KQorICAgICh1bmxlc3MgKGxpc3RwIChjYXIg ZGlzcGxheS1idWZmZXItb3ZlcnJpZGluZy1hY3Rpb24pKQorICAgICAgICAoc2V0Y2FyIGRpc3Bs YXktYnVmZmVyLW92ZXJyaWRpbmctYWN0aW9uIChsaXN0IChjYXIgZGlzcGxheS1idWZmZXItb3Zl cnJpZGluZy1hY3Rpb24pKSkpCiAgICAgKHB1c2ggYWN0aW9uIChjYXIgZGlzcGxheS1idWZmZXIt b3ZlcnJpZGluZy1hY3Rpb24pKQogICAgIGV4aXRmdW4pKQogCi0tIAoyLjQ1LjEKCg== --00000000000037ef58061b3fbd07--