From: PJ Weisberg <pj@irregularexpressions.net>
To: Chming <chming@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: About write-contents-functions in pre-test 24.0.95.1
Date: Tue, 17 Apr 2012 15:44:33 -0700 [thread overview]
Message-ID: <CAJsNXT=kSrGK4-O9OR1v5UDqLG=O3bcWSMZJ6KT0fM2uiJXOYw@mail.gmail.com> (raw)
In-Reply-To: <CAMXexegi-3myJLLJORbC9uAGPnZzYFuWtmbbxjBaKd05rb9O0w@mail.gmail.com>
On Tue, Apr 17, 2012 at 8:50 AM, Chming <chming@gmail.com> wrote:
> Hello,
>
> I am using the following codes to untabify code in c mode.
>
> ;; Untabify when saving
> (defun ska-untabify ()
> (save-excursion
> (goto-char (point-min))
> (when (search-forward "\t" nil t)
> (untabify (1- (point)) (point-max)))
> nil))
Why not just:
(defun ska-untabify ()
(untabify (point-min) (point-max)))
?
As written it seems like it's trying to make sure it doesn't remove
any tabs that occur before the first tab, which is a little silly. ;-)
> (defun saving-untabify ()
> (add-hook 'write-contents-functions 'ska-untabify nil t))
> (add-hook 'c-mode-common-hook 'saving-untabify)
>
> Right now when I try this on the latest version, it looks like it will
> remove all tabs in makefile mode. My understanding is this func only
> works on cc-mode. Is that correct to use write-contents-functions in
> this way?
I think before-save-hook is a better place for functions like this.
-PJ
Gehm's Corollary to Clark's Law: Any technology distinguishable from
magic is insufficiently advanced.
prev parent reply other threads:[~2012-04-17 22:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 15:50 About write-contents-functions in pre-test 24.0.95.1 Chming
2012-04-17 22:44 ` PJ Weisberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJsNXT=kSrGK4-O9OR1v5UDqLG=O3bcWSMZJ6KT0fM2uiJXOYw@mail.gmail.com' \
--to=pj@irregularexpressions.net \
--cc=chming@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.