From: Allen Li <vianchielfaura@gmail.com>
To: 28615@debbugs.gnu.org
Subject: bug#28615: [PATCH] Clarify what grep-read-files wants
Date: Wed, 4 Oct 2017 21:15:32 -0700 [thread overview]
Message-ID: <CAJr1M6ffi9yeU6rGNuioAr6+8DP4+8S_Hz+SLWSky3O7G2QgqA@mail.gmail.com> (raw)
In-Reply-To: <CAJr1M6fy+wRfbHn=iXDWAaX7zmqJ72VWRy-pOHuDkca5=Cr6ig@mail.gmail.com>
grep-read-files wants a filename glob, not a filename/path.
* lisp/progmodes/grep.el (grep-read-files): Clarify docstring.
Use file aliases for completion.
Clarify completing-read prompt.
---
lisp/progmodes/grep.el | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el
index 01bdb04714..0537c76d30 100644
--- a/lisp/progmodes/grep.el
+++ b/lisp/progmodes/grep.el
@@ -903,7 +903,7 @@ grep-read-regexp
(read-regexp "Search for" 'grep-tag-default 'grep-regexp-history))
(defun grep-read-files (regexp)
- "Read files arg for interactive grep."
+ "Read filename glob arg for interactive grep."
(let* ((bn (or (buffer-file-name)
(replace-regexp-in-string "<[0-9]+>\\'" "" (buffer-name))))
(fn (and bn
@@ -936,10 +936,10 @@ grep-read-files
(car (car grep-files-aliases))))
(files (completing-read
(concat "Search for \"" regexp
- "\" in files"
+ "\" in files matching glob"
(if default (concat " (default " default ")"))
": ")
- 'read-file-name-internal
+ grep-files-aliases
nil nil nil 'grep-files-history
(delete-dups
(delq nil (append (list default default-alias default-extension)
--
2.14.2
next prev parent reply other threads:[~2017-10-05 4:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 7:01 bug#28615: 25.3; rgrep, grep-read-files confusingly completes file names ヌエルモリノ
2017-10-05 4:15 ` Allen Li [this message]
2017-10-09 13:41 ` bug#28615: [PATCH] Clarify what grep-read-files wants Eli Zaretskii
2017-10-10 4:43 ` Allen Li
2017-10-10 5:55 ` Eli Zaretskii
2017-10-10 6:51 ` Allen Li
2017-10-10 7:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJr1M6ffi9yeU6rGNuioAr6+8DP4+8S_Hz+SLWSky3O7G2QgqA@mail.gmail.com \
--to=vianchielfaura@gmail.com \
--cc=28615@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.