From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Allen Li Newsgroups: gmane.emacs.bugs Subject: bug#28008: 25.2; Resume kmacro definition errors C-u C-u Date: Mon, 18 Sep 2017 13:02:57 -0700 Message-ID: References: <87d1867hpd.fsf@calancha-pc> <87d182p97t.fsf@calancha-pc> <83shgyqmwn.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1505765060 18086 195.159.176.226 (18 Sep 2017 20:04:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 18 Sep 2017 20:04:20 +0000 (UTC) Cc: 28008@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 18 22:04:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du2H6-0004LT-E4 for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Sep 2017 22:04:12 +0200 Original-Received: from localhost ([::1]:38686 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1du2HD-0000vg-He for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Sep 2017 16:04:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1du2H1-0000tL-Qw for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 16:04:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1du2Gw-0006J6-Rn for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 16:04:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38185) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1du2Gw-0006J0-O2 for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 16:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1du2Gw-0001fH-G1 for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2017 16:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Sep 2017 20:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28008 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28008-submit@debbugs.gnu.org id=B28008.15057649876332 (code B ref 28008); Mon, 18 Sep 2017 20:04:02 +0000 Original-Received: (at 28008) by debbugs.gnu.org; 18 Sep 2017 20:03:07 +0000 Original-Received: from localhost ([127.0.0.1]:46865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du2G3-0001e3-0A for submit@debbugs.gnu.org; Mon, 18 Sep 2017 16:03:07 -0400 Original-Received: from mail-qt0-f196.google.com ([209.85.216.196]:35078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du2G0-0001dB-0b for 28008@debbugs.gnu.org; Mon, 18 Sep 2017 16:03:05 -0400 Original-Received: by mail-qt0-f196.google.com with SMTP id l25so1067102qtf.2 for <28008@debbugs.gnu.org>; Mon, 18 Sep 2017 13:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=OofaU83KshIwSSz2aL8+W5Khi/REA3tcRZ1qz1ZuGMU=; b=T2SSz5toBI49tzfZOMn+ZUm7VctpwRn3VOunPg5tlk/CSQXDIPjEyqxEQGgVDJAiLC ZOfpiJiJBU3ErnEdcBIwSVfLcOwS/HEHNy2HtC/2iYnmV+6n0ztTQmMZ0IW+dHy05gGY FxGHBoiQ4fTKm9Qe9ahhoM+IKdwko/vYT7bxN6tjTkmrJR1bBNDMYKA+sGyhRpMsLK4u vNW2aUk5AVYSeA7s1HSU5+EWCbBOKi5OqD8lMMk8OcXS4kI1Sv+EpXa10HOi0RSudGuz QB52nPBb9Iim0kXAxwmxFG7GZWL18+QZ2pzLywcfbfW7Wyt0C81x8B6+gRsGN9VlgV4W WPCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=OofaU83KshIwSSz2aL8+W5Khi/REA3tcRZ1qz1ZuGMU=; b=XqUEqcwyalI1hETM1/oF8P2ih9r0cKSrSVpWIdECDAhnez5egfflx4g4r6yzp4fziD DyF7ZkQMV9JxMEBvh3Poge/F7494z1X5GgeJFgnctNS79zznGwifvAWqxU7/qyUQAmRW zVphx7FItxb1Nk6LSkv/CSFkbqsSyOmCK8Itq3UA/7FC7cmD9Iqk4jXgGvIgXeFT1W9W DaK7BCnyYKNveGLAE3ACXbbh6qbjhp7kEpAt+cRn1Td7lCNoyaXGhVwjs7hcVt53PxXS PKMyiDJt6L4NZl/7zq429SNgK61BJnw51vjQxgN57J81VaPVygtV0lm1IKo2nZK+ENY9 Nr4g== X-Gm-Message-State: AHPjjUiWqrvTUwQNQOxxJTNqgOsgzAvgYWvnsVRZNnKPgPCd0vyLfzxu pUWioZYLXVmrF3LuT+nLZcV8EKEM3ZPcqxkEO7c= X-Google-Smtp-Source: AOwi7QDHTccqgFNBT53dVmEoPQ6Ii7neaUgqmb+wO5iOW3X+5EoTGRwpSlCG3qoCRs5FSfquYDaI+2NmlBZRD7LIFug= X-Received: by 10.200.2.147 with SMTP id p19mr48726283qtg.242.1505764978036; Mon, 18 Sep 2017 13:02:58 -0700 (PDT) Original-Received: by 10.200.49.212 with HTTP; Mon, 18 Sep 2017 13:02:57 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137080 Archived-At: On Fri, Aug 11, 2017 at 6:17 AM, Tino Calancha wrote: > > On Fri, 11 Aug 2017, Eli Zaretskii wrote: >> All these low-level changes just to support an obscure use case? Is >> really worth the risk to break macros to cater to that? > > That depends of how often someone uses kbd macros. I rarely use them, but > the people using them frequently might suffer D.2 from time to time. > > Actually, the patch#1 is quite short: i included a docstring fix from > the patch#2 by mistake. > The C code changes in patch#1 are just: > 3 files changed, 41 insertions(+), 2 deletions(-) I had to change a c to Qc in macros.c to get patch 1 to compile. However, it does not seem to fix case D.2. I don't think this was made explicit, but case D.2 applies to all undefined keybindings, so for example C-x C-g, but also C-c z. We should at least fix the behavior for case D.2 The more invasive patch 2 can be discussed later, but Emacs shouldn't just discard the entire recorded macro on an undefined key press. This makes me nervous whenever I use kmacros.