Bug: Stuck projects view reverts to tag match on refresh [9.0.5]

Bug: Stuck projects view reverts to tag match on refresh [9.0.5]

[Allen Li]

The stuck projects agenda view reverts to a tag match when it is
refreshed with r or g

Example of original view:

    List of stuck projects: 
      Refile:     Stuck                                            :refile::project:

After refreshing:

    Headlines with TAGS match: project
    Press ‘C-u r’ to search again with new search string
      Refile:     Stuck                                            :refile::project:
      Refile:     Unstuck                                          :refile::project:

Emacs  : GNU Emacs 25.1.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.7)
 of 2017-02-07
Package: Org mode version 9.0.5 (9.0.5-elpa @ ~/.emacs.d/elpa/org-20170210/)

Re: Bug: Stuck projects view reverts to tag match on refresh [9.0.5]

[Nicolas Goaziou]

Hello,

Allen Li <darkfeline@felesatra.moe> writes:

> The stuck projects agenda view reverts to a tag match when it is
> refreshed with r or g
>
> Example of original view:
>
>     List of stuck projects: 
>       Refile:     Stuck                                            :refile::project:
>
> After refreshing:
>
>     Headlines with TAGS match: project
>     Press ‘C-u r’ to search again with new search string
>       Refile:     Stuck                                            :refile::project:
>       Refile:     Unstuck                                          :refile::project:

I cannot reproduce it. Could you provide an ECM?

Regards,

-- 
Nicolas Goaziou

Re: Bug: Stuck projects view reverts to tag match on refresh [9.0.5]

[Allen Li]

On Tue, Apr 18, 2017 at 1:33 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> I cannot reproduce it. Could you provide an ECM?

Create a file tmp.org with the contents:

* Stuck :project:
* Unstuck :project:
** TODO thing

1. emacs -q
2. Eval:

(setq org-agenda-files '("~/tmp.org")
      org-stuck-projects '("project" ("TODO") nil ""))

3. M-x org-agenda RET #

Buffer contents:

List of stuck projects:
  tmp:        Stuck                                                    :project:

4. r

Buffer contents:

Headlines with TAGS match: project
Press ‘C-u r’ to search again with new search string
  tmp:        Stuck                                                    :project:
  tmp:        Unstuck                                                  :project:
  tmp:        TODO thing                                              :project::

I realize that this is using the stock Org mode that ships with Emacs,
but it's the same behavior as org-20170210, which I believe is the
latest and this repro is easier.

[PATCH] org-agenda: Store stuck project redo command

[Allen Li]

* lisp/org-agenda.el (org-agenda-list-stuck-projects): Store the redo
command in a text property so it is found correctly.

`org-agenda-redo' checks the `org-redo-cmd' text property, not
`org-agenda-redo-command'.

TINYCHANGE
---
 lisp/org-agenda.el | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index cf9351a9b..78c1a37f4 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -4971,7 +4971,11 @@ of what a project is and how to check if it stuck, customize the variable
     (setq org-agenda-buffer-name (buffer-name))
     (with-current-buffer org-agenda-buffer-name
       (setq org-agenda-redo-command
-	    `(org-agenda-list-stuck-projects ,current-prefix-arg)))))
+	    `(org-agenda-list-stuck-projects ,current-prefix-arg))
+      (let ((inhibit-read-only t))
+        (add-text-properties
+         (point-min) (point-max)
+         `(org-redo-cmd ,org-agenda-redo-command))))))
 
 ;;; Diary integration
 
-- 
2.12.2

Re: [PATCH] org-agenda: Store stuck project redo command

[Samuel Wales]

in case it isn't already considered, i think storing the conditions of
the original call applies to many agenda calls.  i run into this issue
with the following old code.  i set a restriction lock, and run
agenda, but g runs agenda without the restriction lock.

(defun alpha-org-agenda-subtree (&optional _arg)
  "Show agenda for all tasks in subtree.

===

You can get a fast sorted view with this command.  In this
example, the agenda will show tasks under my subtree.

  * top level 1 -- not shown
    * my subtree -- shown
      * TODO a
      * some other headline | (<- point is here)
        * TODO [#A] b
  * top level 2 -- not shown

If you sort by priority, b will sort above a.

===

This allows you to organize nodes hierarchically instead of
keeping things at the same level merely to allow sorting.
"
  (interactive "P")

  (org-agenda-set-restriction-lock 'subtree)
  (let ((org-agenda-sorting-strategy '(user-defined-up category-up))
        (org-agenda-text-search-extra-files)
        (org-agenda-show-inherited-tags))
    (org-tags-view nil "LEVEL>0")
    (setq-local org-agenda-sorting-strategy
                org-agenda-sorting-strategy)))

-- 
The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>

The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.

"You’ve really gotta quit this and get moving, because this is murder
by neglect." ---
<http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.

Re: [PATCH] org-agenda: Store stuck project redo command

[Samuel Wales]

maybe i got that backward.

my note is: "fixme bug in org: either if you do g, it will ignore restriction
lock or you have to manually remove restriction lock.  the best
would be for g to preserve the restriction lock even though it
has been removed."

On 4/20/17, Samuel Wales <samologist@gmail.com> wrote:
> in case it isn't already considered, i think storing the conditions of
> the original call applies to many agenda calls.  i run into this issue
> with the following old code.  i set a restriction lock, and run
> agenda, but g runs agenda without the restriction lock.
>
> (defun alpha-org-agenda-subtree (&optional _arg)
>   "Show agenda for all tasks in subtree.
>
> ===
>
> You can get a fast sorted view with this command.  In this
> example, the agenda will show tasks under my subtree.
>
>   * top level 1 -- not shown
>     * my subtree -- shown
>       * TODO a
>       * some other headline | (<- point is here)
>         * TODO [#A] b
>   * top level 2 -- not shown
>
> If you sort by priority, b will sort above a.
>
> ===
>
> This allows you to organize nodes hierarchically instead of
> keeping things at the same level merely to allow sorting.
> "
>   (interactive "P")
>
>   (org-agenda-set-restriction-lock 'subtree)
>   (let ((org-agenda-sorting-strategy '(user-defined-up category-up))
>         (org-agenda-text-search-extra-files)
>         (org-agenda-show-inherited-tags))
>     (org-tags-view nil "LEVEL>0")
>     (setq-local org-agenda-sorting-strategy
>                 org-agenda-sorting-strategy)))
>
> --
> The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>
>
> The disease DOES progress. MANY people have died from it. And ANYBODY
> can get it at any time.
>
> "You’ve really gotta quit this and get moving, because this is murder
> by neglect." ---
> <http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.
>


-- 
The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>

The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.

"You’ve really gotta quit this and get moving, because this is murder
by neglect." ---
<http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.

Re: [PATCH] org-agenda: Store stuck project redo command

[Nicolas Goaziou]

Hello,

Allen Li <darkfeline@felesatra.moe> writes:

> * lisp/org-agenda.el (org-agenda-list-stuck-projects): Store the redo
> command in a text property so it is found correctly.
>
> `org-agenda-redo' checks the `org-redo-cmd' text property, not
> `org-agenda-redo-command'.
>
> TINYCHANGE

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou