From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Allen Li Newsgroups: gmane.emacs.bugs Subject: bug#28615: [PATCH] Clarify what grep-read-files wants Date: Mon, 9 Oct 2017 23:51:47 -0700 Message-ID: References: <83wp44qvzw.fsf@gnu.org> <83k203r1gx.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1507618341 19512 195.159.176.226 (10 Oct 2017 06:52:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 10 Oct 2017 06:52:21 +0000 (UTC) Cc: 28615@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 10 08:52:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1oOd-00036I-20 for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Oct 2017 08:52:07 +0200 Original-Received: from localhost ([::1]:33135 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1oOh-0001ec-Go for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Oct 2017 02:52:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1oOb-0001eL-SI for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2017 02:52:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1oOY-00078B-RH for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2017 02:52:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50342) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e1oOY-000781-N7 for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2017 02:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e1oOY-0004Z9-FF for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2017 02:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Oct 2017 06:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28615-submit@debbugs.gnu.org id=B28615.150761831817529 (code B ref 28615); Tue, 10 Oct 2017 06:52:02 +0000 Original-Received: (at 28615) by debbugs.gnu.org; 10 Oct 2017 06:51:58 +0000 Original-Received: from localhost ([127.0.0.1]:59021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1oOR-0004YX-GM for submit@debbugs.gnu.org; Tue, 10 Oct 2017 02:51:57 -0400 Original-Received: from mail-qt0-f195.google.com ([209.85.216.195]:52788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1oOP-0004YE-Fg for 28615@debbugs.gnu.org; Tue, 10 Oct 2017 02:51:53 -0400 Original-Received: by mail-qt0-f195.google.com with SMTP id o52so48361622qtc.9 for <28615@debbugs.gnu.org>; Mon, 09 Oct 2017 23:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KTu7OEm4d2vUyKvqb41edxJv8vzy4MCvAh6EhwXLmz0=; b=ZwU3BBHk7A6IMmdEhYE0+thDl/DuuHntgFK0WkAuYQP4C3upB92tMgGZpe4BcicTKT L4Ak1xO+sp6RjAIU6FQLACeeOV1IWsIOj8aIorvCbG9ncFwr63BsCgTGUNy3zonlsCyC lcob2bLDk6JKPXXjZhdHlXlT65F0CnAUsyNSjWc1iJeFFlo0DUmjUIDjgiXhN4mznQWh Lf4mHqq2oAobvB07MK7Eeg/kkZMEeDweAF/tGe56OcCsWRBiTYSwUVf+4qoMo3O5o12q jZLlEhib6Hotx1AOxPEn+1w+9y3i1STHWOGt1PLADHI9ndQw/Gv5/+zDcKTDv1ZdvnqG cNmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KTu7OEm4d2vUyKvqb41edxJv8vzy4MCvAh6EhwXLmz0=; b=G9ORz5aWVKipCqdeCXmO1bw+DNYBpo9T4DstClaijtPohl75whi9WeL0GptMqN9rPk wzMc6MkWLQB3AaHMDqJ1V1QdQB1OiOkeA9o8p2qzy6ksJnWW5N0D2C16rh6CzTG1s78F VCD1TjrT+uvCPEfWIAjjVxZiuR7ot9aTiEsGNmtO2mAc/a44COWJWT8hu6Qn4YwFWkul +N/L/nANeExyrC/rDzEosLavgYFZMr7LpPYdNLr6Lt9QvNiOAtPbOcjWjb/xCl4Ry2z3 Y0ibSIbV7IX72YUuWi+Rk/1LzEoJDCa+P84BRUARbzKFFHNE9fejpi1LwG1jrVaKbn8q Gc/A== X-Gm-Message-State: AMCzsaWAREiZoPd8tYMxE89LPVef+IFpRECi7bHpUUy4Mh5IcGuvQYxk B5TXKqfGeYclDllQNkHPEchvVzoQtO+JuPr09hY= X-Google-Smtp-Source: AOwi7QCJPyrVabFzXx7U9q/uMb2N1q9OS+DRouCTQzXxoXY8cktG+PHwxlTaDBB72VDb8X92YpsPOkDiGg7jMqPNFvw= X-Received: by 10.200.2.175 with SMTP id p47mr3674655qtg.242.1507618307999; Mon, 09 Oct 2017 23:51:47 -0700 (PDT) Original-Received: by 10.200.18.134 with HTTP; Mon, 9 Oct 2017 23:51:47 -0700 (PDT) In-Reply-To: <83k203r1gx.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138150 Archived-At: On Mon, Oct 9, 2017 at 10:55 PM, Eli Zaretskii wrote: >> From: Allen Li >> Date: Mon, 9 Oct 2017 21:43:59 -0700 >> Cc: 28615-done@debbugs.gnu.org >> >> Why did you not change the collection function? > > Because there could be a file called literally like one of the > shorthands in grep-files-aliases, or whose name includes those > shorthands as a substring. Not sure what you mean. There is no use case for completing a file name. Are you saying that a user might mistake the completion on grep-files-aliases as completion on file name? I believe that with the new prompt change, that is unlikely. > >> As I noted in the bug, most of the completions that would be >> provided by read-file-name-internal don't work > > IMO, that's okay, because wildcards cannot be meaningfully completed > on. But the aliases from grep-files-aliases can be meaningfully completed. I don't see why we shouldn't provide meaningful completion if the user defines a lot of aliases, seeing as how the current file name completion is useless.