From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Allen Li Newsgroups: gmane.emacs.bugs Subject: bug#28615: [PATCH] Clarify what grep-read-files wants Date: Mon, 9 Oct 2017 21:43:59 -0700 Message-ID: References: <83wp44qvzw.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1507610716 8229 195.159.176.226 (10 Oct 2017 04:45:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 10 Oct 2017 04:45:16 +0000 (UTC) Cc: 28615-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 10 06:45:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1mPk-0000ms-N8 for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Oct 2017 06:45:08 +0200 Original-Received: from localhost ([::1]:32852 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1mPo-0002mN-MX for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Oct 2017 00:45:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1mPj-0002lj-Ba for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2017 00:45:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1mPe-0006em-HE for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2017 00:45:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50266) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e1mPe-0006eM-Ce for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2017 00:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e1mPe-000164-16 for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2017 00:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Oct 2017 04:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28615-done@debbugs.gnu.org id=D28615.15076106494127 (code D ref 28615); Tue, 10 Oct 2017 04:45:01 +0000 Original-Received: (at 28615-done) by debbugs.gnu.org; 10 Oct 2017 04:44:09 +0000 Original-Received: from localhost ([127.0.0.1]:58947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1mOn-00014U-3r for submit@debbugs.gnu.org; Tue, 10 Oct 2017 00:44:09 -0400 Original-Received: from mail-qt0-f193.google.com ([209.85.216.193]:36478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1mOj-00013p-Qo for 28615-done@debbugs.gnu.org; Tue, 10 Oct 2017 00:44:06 -0400 Original-Received: by mail-qt0-f193.google.com with SMTP id 24so3642407qts.3 for <28615-done@debbugs.gnu.org>; Mon, 09 Oct 2017 21:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=y4YI/K7cFGMCXToqKdZY8XppmJ6n9WUYXGrqRcjLWpI=; b=AKqB4fKpI8BIBiH7ONzzWRbRQ8MbPxUBTEVMMjI0JZ64Da88JvAUofHZSBN17tyG6n txH8pYDwHTDQ0JaLU8Rv2GaSkpbE4a4BEcg5UWh43gMEiUR0AyGmTN/7Du8L+LJ3L7pX 85x4xlYVoXWvmL3BSAUrlhzqoAhLEO1f3+hM4lTOomx2EP1fjutpl1saX/mZxDX8OUar ju/AIZHKt8sQ//9pqVUSSjXALo6S8k9AG8TUN/0WPBzkB1i+9wJUYe2sZ9C1AH0XThCA 6DpuWGtV9u/ISo8DPNnPjvGOt/AKHJarMVuvO/TX4jwvvwgqEeLDoQnKy1mcmoIT+f9O Ghug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=y4YI/K7cFGMCXToqKdZY8XppmJ6n9WUYXGrqRcjLWpI=; b=GvQnmUGTj02bicTpIdcRciYZNpa9wRZMvpUqj6Kg35OO8ZdqRNHmcTcK9Z0rWP5UNI X84LtUFXllA5jmK0lUV8UM58M+g9HPHBfVTFtqmEdd8jzBvTHK69qNlmXO207k26SL3C 4FAEgp6BWafbWdkda/NRhFTMDpdNy1r0Lenzj1JvxYVfG5xuLHzFfPYtxOBnjLhl1ccc tMXQReciXxC16GrvlfX82uyY+YD5FObaAecAmm34NgGMjXGM88aTVMYnMRSJohh9nDR9 iGICXlj1rxwaUIkICnQyEIL65yyyUFUE6rj3tDMXRzbiVlUl+00l5qKVrca2ZgIaHIes qS8g== X-Gm-Message-State: AMCzsaWnz0MNb8T+fdSIAueJ4/kDALs19769vyU6TyKzyxSQ4Gxc4tek gjGS5vss3m4Z0bjAgOZKgK9X+jZcrWI0k5nzJuM= X-Google-Smtp-Source: AOwi7QAjAMBbARLeldkUrjdV15Kex+M1Y5SEH48ZnS5nX4UFN8Bl2Nu76aGCQIqV0Cq/aimHTZGiwnMYIUz3ilD64AI= X-Received: by 10.55.77.214 with SMTP id a205mr7991546qkb.196.1507610640254; Mon, 09 Oct 2017 21:44:00 -0700 (PDT) Original-Received: by 10.200.18.134 with HTTP; Mon, 9 Oct 2017 21:43:59 -0700 (PDT) In-Reply-To: <83wp44qvzw.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138146 Archived-At: On Mon, Oct 9, 2017 at 6:41 AM, Eli Zaretskii wrote: > > Thanks, I installed a slightly different change for the first 2 parts, > but didn't change the function we pass to completing-read. > > With that, I'm closing the bug report. Why did you not change the collection function? As I noted in the bug, most of the completions that would be provided by read-file-name-internal don't work, and the ones that do work result in running rgrep against a single file. grep-files-aliases seems like a much better choice than read-file-name-internal, given that grep-files-aliases is intended to provide aliases for this very purpose.