From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Allen Li Newsgroups: gmane.emacs.bugs Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Date: Tue, 28 Nov 2017 12:13:11 -0800 Message-ID: References: <83vahv67eb.fsf@gnu.org> <87fu8zukmb.fsf@gmail.com> <83609u5pyr.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1511900055 24922 195.159.176.226 (28 Nov 2017 20:14:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Nov 2017 20:14:15 +0000 (UTC) Cc: 29465@debbugs.gnu.org, Tino Calancha To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 28 21:14:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJmGd-0005ut-7T for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Nov 2017 21:14:07 +0100 Original-Received: from localhost ([::1]:39897 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJmGk-0001Mj-6Z for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Nov 2017 15:14:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJmGd-0001Me-FB for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 15:14:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJmGY-0000dZ-Cx for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 15:14:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54721) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJmGY-0000dP-8c for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 15:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eJmGX-0003kM-S2 for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 15:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Nov 2017 20:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.151190000114344 (code B ref 29465); Tue, 28 Nov 2017 20:14:01 +0000 Original-Received: (at 29465) by debbugs.gnu.org; 28 Nov 2017 20:13:21 +0000 Original-Received: from localhost ([127.0.0.1]:35169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJmFr-0003jE-DI for submit@debbugs.gnu.org; Tue, 28 Nov 2017 15:13:21 -0500 Original-Received: from mail-qk0-f180.google.com ([209.85.220.180]:38961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJmFp-0003iw-B1 for 29465@debbugs.gnu.org; Tue, 28 Nov 2017 15:13:17 -0500 Original-Received: by mail-qk0-f180.google.com with SMTP id u184so1514802qkd.6 for <29465@debbugs.gnu.org>; Tue, 28 Nov 2017 12:13:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Y1mrzPDNqdH4SoctE5RrJqQ/5kiXy3cmYsfgqZJwOTs=; b=qPvS141VGPtdFwJNwK1IkrxywXaMFRa5GKaQ1ddCLewNHMz9tuIQI5r8JUI3Qoq/Sk uSWNcjrR+n3iXPHHr7ICqnrDNULm9kdmmnSl/FHqGN5/IN+KjaXNvTyHwpjnycarQlcW aGULXF1ORH6PANKZZy5sknWACHAncxvG0J2QypTbY/5L4DnC+9UX6CD2dnyvYqmfrpZh mKR9X6oGUE0CLDZjZCgrQjGRlQxAyyU0PgNSFFE1KlfRkQiR4KzYi6tHFCm78iKjard/ bXB9OVFzdLs++4iYMszscdhypaPJFcLJv8pT+5wINrGBAHEQSr2L+VHO4NT/LubtHKyu 5yJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Y1mrzPDNqdH4SoctE5RrJqQ/5kiXy3cmYsfgqZJwOTs=; b=Kajnee03i7XIjogXbPT29QzyhKONZldjrFiRjiINKBuwNnpCIHXbIU1G8mqi5dhOCY OwL4PfLnUAoLse5E5VTd/CWLEgIDvB0s9wr+j85S2mt65bNwEhPqmGOPSje76xv/Jt7f 1y94ray+ek/lKg/3ghKb4CsO7pFA4XwTIVUb9RWFteC+ZeophSiLjceTzIZ+AXKO4EWu Sv7utDwiue0jQX4QxFdxP4zTwlk9d+G+CMLqA0WlmOhNYUUn9Y1ZDrv33EDzWM8a+Q+3 U7drfavgoeT6dj2V1tugdxFGiYVwU6rbr4HujW2yvSkVY6/4djwrq1oYyVjzQvl0v8zW 4gRA== X-Gm-Message-State: AJaThX4DjnGzp6SVRnp+Bt3onaKhw2ebZ1ZKrXKlUC0/axgmF642SW14 B2SQrhXioJ3U8s4ptPedr29HOtz5mhLtOgEdWT8= X-Google-Smtp-Source: AGs4zMZUzk4cQdIAQ/Qot2YwRA51X0kZ5DoDl6/n/SGgRi/9bsngEPMKkUMemOodSSGdMaVs8EybbPQ/+TI5l5ZQZ3s= X-Received: by 10.55.54.146 with SMTP id d140mr641961qka.39.1511899991578; Tue, 28 Nov 2017 12:13:11 -0800 (PST) Original-Received: by 10.237.52.161 with HTTP; Tue, 28 Nov 2017 12:13:11 -0800 (PST) In-Reply-To: <83609u5pyr.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140501 Archived-At: On Tue, Nov 28, 2017 at 8:26 AM, Eli Zaretskii wrote: > I think we should try to make the prompt more clear, it cannot be that > hard. Removing the prompt will introduce backward incompatibility > with what Emacs was doing for the past 15 years, so it's a worse > alternative, IMO. I don't care personally, if there's an option to disable it, but I am not convinced for the sake of the betterment of Emacs. I don't see how removing the prompt introduces backward incompatibility issues unless someone has a keyboard macro saved that includes a "y" to handle this case (which I suppose is a possible use case, but I think we have to draw the line somewhere; would improving Emacs performance be a breaking change because someone was relying on a certain function call taking at least a certain amount of time?). This is changing interactive usage, not API usage. > You need to look up relevant discussions on Emacs mailing lists around > the date of the commit. In this case, read this thread: > > http://lists.gnu.org/archive/html/emacs-devel/2002-01/msg00233.html > > and also the original bug report and its followups: > > http://lists.gnu.org/archive/html/bug-gnu-emacs/2002-01/msg00230.html > >> If I were to hazard a guess, the behavior of the command was >> changed, so the prompt was added to warn users accustomed to the old >> behavior. > > No, it was a bug report about a potentially risky feature, where a > user mistyping a command could have their files wiped out or cause > some other grave accident. Thanks for that. But the confirmation prompt doesn't actually address said bug. Mistyping `M-! rm *' instead of `! rm *' will still wipe out your files with no confirmation. I don't accept that `! rm *""', the case covered by the confirmation prompt, is a common typo. Basically, I'm not convinced that this is protecting against a common case of user error. I would appreciate it if someone could provide a concrete example of such a user error (or ideally two or three examples). > The syntax of the shell commands supported by dired-do-shell-command > and its features regarding '*' and '?' are still very complicated, as > they were back then. Just the doc string describing the behavior is > so long it can scare. So I don't see how the time that has passed is > of relevance here. If dired-do-shell-command is complicated enough to scare, as you say, I think presenting the user with an ambiguous confirmation prompt scares even more. The confirmation prompt implies that the user is doing something dangerous, when in all likelihood the user is doing nothing of the sort. Again, I would like to see a concrete example of a user error this prompt actually protects against. With all of that said, I am fine with adding an option, since I can just set it and be on my merry way. But I think Emacs would benefit from not having this prompt (and I would be happy to be convinced otherwise).