From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Corwin Brust Newsgroups: gmane.emacs.devel Subject: Re: How to contribute to Emacs Windows(NT) installer? Date: Sun, 21 Apr 2024 21:13:34 -0500 Message-ID: References: <86jzksa6yz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34707"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Elijah G Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 22 04:14:38 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ryjCX-0008tE-PC for ged-emacs-devel@m.gmane-mx.org; Mon, 22 Apr 2024 04:14:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ryjBn-0001yq-25; Sun, 21 Apr 2024 22:13:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ryjBm-0001yg-1y for emacs-devel@gnu.org; Sun, 21 Apr 2024 22:13:50 -0400 Original-Received: from mail-oi1-f176.google.com ([209.85.167.176]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ryjBk-0003EB-25; Sun, 21 Apr 2024 22:13:49 -0400 Original-Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3bbc649c275so1440741b6e.0; Sun, 21 Apr 2024 19:13:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713752026; x=1714356826; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IiQ+7AftLz78KiA+6qGI3I5+YwQukkg3Ii/optkJwhQ=; b=PyVbTPBul5VxyxtynwnApv2wy2zB82HxTcwKE5U50SnMKw66CpL3bvx9BQmit/mvqK Xcsz8fiYGeWiS8745yIG4upP7TlvtRSC9wNq/YrW3irtTZ2F0jNXALJqNy18V7BQRKM+ 1fdtL/nDv250oPeCKchT0X8oC/pWKCzyiUbn6Zy5IzqgTE9LsrdIXw41CF3OqPEr2fnD 9jNlIPV3hvMxLT1lZX3Nv1S0beLFKPhSojiiym/NI8MyDdRyeCH1OohX/k07dX66aDPw NnG2rc7exziH8JdyiF6rp8kdz/fZ+PLmMGYaNCaV5V9SiBJwA2C2fCXf3ZDWKv0MMTYf EB8w== X-Forwarded-Encrypted: i=1; AJvYcCWCFRbRqdnfGrI4Go4OsRy5tVja8TvFYvuu2YJrINTatD1uMdH4R8Z8Ep4jmUvG7CIhLe1R+AtcW6j/isLpQyRIZOHT X-Gm-Message-State: AOJu0YxMFjJNclNLRD+PUvhYXQRAk91f7QhvSjYmpuDStToIRU+8MgVX hPgoUIXwndIU1vuABKgCGvxu7/GyQhD9obm/ErorwfWjtO4hJXUbFz/GsImGcKWwoOZ9C/N6xSi vDhgn1G3IShdETbIs5HhH3a6usGE= X-Google-Smtp-Source: AGHT+IEyBzXo8QMRuhKE3QmT3jnRsawOmRbLJj/KR4sNEQgTetVZw4VHsjD3P5PZZ0NSTyp6uH2NtxlJ2S+zLq7tOXc= X-Received: by 2002:a05:6870:d0d1:b0:229:7d01:7e03 with SMTP id k17-20020a056870d0d100b002297d017e03mr9288012oaa.43.1713752025859; Sun, 21 Apr 2024 19:13:45 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=209.85.167.176; envelope-from=mplscorwin@gmail.com; helo=mail-oi1-f176.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317943 Archived-At: On Sun, Apr 21, 2024 at 7:04=E2=80=AFPM Elijah G wrote= : > > On Sun, Apr 21, 2024 at 4:38=E2=80=AFPM Elijah G wro= te: > > > > On Sun, Apr 21, 2024 at 4:00=E2=80=AFPM Corwin Brust wr= ote: > > > > > > On Sat, Apr 20, 2024 at 1:22=E2=80=AFAM Eli Zaretskii = wrote: > > > > > > > > > From: Elijah G > > > > > Date: Fri, 19 Apr 2024 20:42:51 -0600 > > > > > > > > > > Hello, I'm interested in contributing to emacs windows installer = such > > > > > as providing more options and providing images/banners bitmap, Wh= ere > > > > > can I find information such as where to send them and which files= are > > > > > needed to modify? > > > > > > > > I believe Corwin (CC'ed) is the person who currently takes care of = the > > > > Windows binaries. > > > > > > > > > > Hi Elijah! > > > > > > The files specific to building on and for Windows port are in > > > admin/nt/dist-build within the source tree. The NSIS installer is > > > emacs.nsi in that folder. I would be happy to look at any patches. > > > > > > I have lots and lots of rather so-so code relating to making these > > > builds, most of which I don't use when preparing release builds which > > > I do rather manually. In any case, my local snapot "CI" build > > > programs are here: https://git.sr.ht/~mplscorwin/emacs-local-ci > > > > > > Let me know how I can help most, and thanks for your interest in > > > improving things. > > > > Hi Corwin, thank you for showing me the files I've tried building only = the > > installer using "build-zips.sh -i" but i'm getting an error "Error > > while loading icon from > > "emacs-30.0.50\share\emacs\30.0.50\etc\images\icons\hicolor\scalable\a > > pps\emacs.ico": can't open file" can you tell me Where the share folder= should > > be? > > I think I found the error, it's because build-zips.sh was executing in "C= :\", > i'm planning to add images/banners for the installer because the > default is stretched and > other stuff, i'm not sure if I should send the patch in this thread or > create another. > I think you are correct - build-zips.sh wants to be run from a folder containing your newly built Emacs (or maybe one level up from that; I'm not using it much at present; I run the installer directly). Once you have a patch ready to send please use the `report-emacs-bug' command and attach your patch, which will open a new bug report for us to discuss these "beautification" changes (which will be much appreciated). I'm not sure it matters a great deal in the case of these few files, but we most often work in terms of separate bugs for specific finite changes, while using this list to discuss what bugs to open and otherwise align on approaches to take when the given subject may lead to more sweeping change, as best I understand regarding Emacs development more generally.