From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Corwin Brust Newsgroups: gmane.emacs.devel,gmane.emacs.bugs Subject: Windows binary installer ignores user options for Start menu shortcuts Date: Sat, 21 Dec 2024 13:46:39 -0600 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28502"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs developers To: Francis Wright , bug-gnu-emacs@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 21 20:47:34 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tP5Rm-0007Iw-2k for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Dec 2024 20:47:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tP5R9-0006MY-Mp; Sat, 21 Dec 2024 14:46:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tP5R8-0006MM-3s; Sat, 21 Dec 2024 14:46:54 -0500 Original-Received: from mail-oo1-f46.google.com ([209.85.161.46]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tP5R6-0003WA-81; Sat, 21 Dec 2024 14:46:53 -0500 Original-Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-5f2ed7462c1so219478eaf.0; Sat, 21 Dec 2024 11:46:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734810411; x=1735415211; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MOvXABNGAtOsSDB8CGeAEdezOk4DZfsxf49i5EHQp20=; b=cBR3+c6Gvbg1GkGXydupoGSDvtQlhpAkRojDfRsG+qEgqpg/bhodLTbEVpLGm59LWq WD7fmgbvMRoCMpCVGxxxesLCUEFr22zseszzS4f1yT0Wc8PI9imemYwbFZac7Kfe1cX+ bixYlFxzMqPqIc0lnqdc5pMOqbK+/NHekzuQV3V2rXkqAOKjk6MZk6ciABSLjCwBbZEz IAGuji422okQKgWCqsLmzXoNoRi9gA4bJpslxHjUjyxyr6jMwvMG0BwmR1WRLIpccBF0 dtWps6g3k9VMdD55XR6zkTiO35+6P+AIiRygntWk16ZO/a2TfH2g/NNetI69GXdyOOSU OOOQ== X-Forwarded-Encrypted: i=1; AJvYcCWIP3lgravy85OnzHy0ffMDxKc6odeflrCJsclnULMxo2gJ1psibeU/aeenpS9EZgmczTYVDjIpG48ItFnH@gnu.org X-Gm-Message-State: AOJu0YwdhM4hxwJ4EOK3Kz9To2dlHzHncwCerxZYsAXzmkvw8A3Ot/Na rSFTf1ZyUSBeySsK99ZlgBr4UDgWG+g5yQB4edZnNKPju1xTS8x7h8bfLKka10NrO5QcdxHHIhU Mpumj0EtTxHEJX1MXLj4fXu/7A1I= X-Gm-Gg: ASbGncvt99b+75577vT9DjfIvPdOsZPFKu1n0MporyAhOHBNs+PiA9zvAofM1KUU/ag 3fLuWRJZo3CACbyFumr/nOoHrMze3xJad7uz5 X-Google-Smtp-Source: AGHT+IFL+NocJVJ917chEzUSaHMvXNDsOGYER90gl+88ozoH0GQnSWooGPBTCiGnu+4ub/ltzhkc0Ob7Q63D15EafKk= X-Received: by 2002:a05:6830:2643:b0:71e:4ce2:4331 with SMTP id 46e09a7af769-720ff8825a2mr1342509a34.4.1734810410700; Sat, 21 Dec 2024 11:46:50 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=209.85.161.46; envelope-from=mplscorwin@gmail.com; helo=mail-oo1-f46.google.com X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326833 gmane.emacs.bugs:297549 Archived-At: Thanks much for looking into issues/fixes with the binary installer for Windows, Francis! "Promoting" your comments to a bug report here, as I think you've uncovered an undocumented (and fixable + worth fixing) thing. On Sat, Dec 21, 2024 at 12:29=E2=80=AFPM Francis Wright wrote: > > Hi Corwin > > Thanks for working on this. The "greedy uninstaller" was a bit of a pain.= I tried your installer [] > and the associated uninstaller seems to work correctly, i.e. it only unin= stalls emacs-30.0.93, which is great. I didn't notice any of the other issu= es you listed. > Yay! > However, I did notice a couple of problems. Firstly, Windows pops up a wa= rning from Microsoft Defender SmartScreen, which is not a new problem and i= s easy to work around. This I think I am not currently able to do much about, alas. > Secondly, the installer did not install a shortcut folder. On the Choose = Start Menu Folder dialogue, Emacs-30.0.93 was pre-selected, and I ensured t= hat Do not create shortcuts was not selected. The only button available was= the Close button, which I clicked. A shortcut for Emacs itself was install= ed but not the shortcut to the folder containing Emacs and the uninstaller.= (I can add the folder shortcut by hand.) > Thanks for reporting this issue. I confirmed it exists also with the 29.4 released binary installer. When I select "show details" I can see at the end of the unpacking ("installation") processing step it creates start-menu short-cuts; however, the screen where we choose whether or not we want to install short-cuts isn't shown until after the unpacking step -which I now see does short-cut creation, but shouldn't- is completed. There is some code in the nsi script which might be doing the write thing in the wrong place, at first glance. In any case, with the present (for some time) installer we get a "hard-coded" incorrect value for a start menu shortcut that is always created irrespective of relevant choices offered to the user by said installer. Not great. I'll look into fixing this for the 30.1 installer, also, replying back in here if/when I have an "_3" that seems to warrant others' testing effort. Since this "short-cut page ignored" issue doesn't seem already to have been captured in the bug tracker I have directed this reply such as to create a new bug-report. I'll try to arrange to get additional relevant comments I/we make back on devel show up in the new bug report (I don't have the number yet, as I write this), but: feel free to address replies back to original devel thread (or otherwise to this new bug thread) as you think best. > Best wishes, > Francis > Gratefully, Corwin