bug#68320: 30.0.50; filename completion with tramp fails on Windows

bug#68320: 30.0.50; filename completion with tramp fails on Windows

[Kazuhiro Ito]

1. Start Emacs that is placed in D: drive.
2. Evaluate (require 'tramp) to load tramp.el.
3. Type C-x C-f c : / TAB TAB

Completion for c:/ should be listed, but it seems that completions for
d:/ are showed.

-- 
Kazuhiro Ito

bug#68320: 30.0.50; filename completion with tramp fails on Windows

[Corwin Brust]

On Mon, Jan 8, 2024 at 6:35 AM Kazuhiro Ito <kzhr@d1.dion.ne.jp> wrote:
>
> 1. Start Emacs that is placed in D: drive.
> 2. Evaluate (require 'tramp) to load tramp.el.
> 3. Type C-x C-f c : / TAB TAB
>

I can reproduce this by starting Emacs placed in an H: drive and then
attempting to complete starting from C-x C-f c:/p <TAB> which should
offer me a folder called "projects" however the completion candidates
appear to be from my HOME directory (set by Environment Variable
before starting Emacs).

bug#68320: 30.0.50; filename completion with tramp fails on Windows

[Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Corwin Brust <corwin@bru.st> writes:

Hi,

>> 1. Start Emacs that is placed in D: drive.
>> 2. Evaluate (require 'tramp) to load tramp.el.
>> 3. Type C-x C-f c : / TAB TAB
>
> I can reproduce this by starting Emacs placed in an H: drive and then
> attempting to complete starting from C-x C-f c:/p <TAB> which should
> offer me a folder called "projects" however the completion candidates
> appear to be from my HOME directory (set by Environment Variable
> before starting Emacs).

FTR, I can also reproduce the problem. Will check next days whether I
could fix the problem. (Testing on MS Windows is always a burden to me.)

Best regards, Michael.

bug#68320: 30.0.50; filename completion with tramp fails on Windows

[Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Michael Albinus <michael.albinus@gmx.de> writes:

Hi,

>>> 1. Start Emacs that is placed in D: drive.
>>> 2. Evaluate (require 'tramp) to load tramp.el.
>>> 3. Type C-x C-f c : / TAB TAB
>>
>> I can reproduce this by starting Emacs placed in an H: drive and then
>> attempting to complete starting from C-x C-f c:/p <TAB> which should
>> offer me a folder called "projects" however the completion candidates
>> appear to be from my HOME directory (set by Environment Variable
>> before starting Emacs).
>
> FTR, I can also reproduce the problem. Will check next days whether I
> could fix the problem. (Testing on MS Windows is always a burden to me.)

I've fixed this in the master branch. Could you, pls, give it some
testing. Since I don't use MS Windows regularly, I could try only some
few tests.

Best regards, Michael.

bug#68320: 30.0.50; filename completion with tramp fails on Windows

[Corwin Brust]

On Wed, Jan 10, 2024 at 9:16 AM Michael Albinus via Bug reports for
GNU Emacs, the Swiss army knife of text editors
<bug-gnu-emacs@gnu.org> wrote:
>
> Michael Albinus <michael.albinus@gmx.de> writes:
> >>> 1. Start Emacs that is placed in D: drive.
> >>> 2. Evaluate (require 'tramp) to load tramp.el.
> >>> 3. Type C-x C-f c : / TAB TAB
> >>
> >> I can reproduce this by starting Emacs placed in an H: drive and then
> >> attempting to complete starting from C-x C-f c:/p <TAB> which should
> >> offer me a folder called "projects" however the completion candidates
> >> appear to be from my HOME directory (set by Environment Variable
> >> before starting Emacs).
> >
> I've fixed this in the master branch. Could you, pls, give it some
> testing.

I will kick-off a MSYS2/MINGW64 build from the development branch
shortly and report back; thanks for looking into this so quickly!

bug#68320: 30.0.50; filename completion with tramp fails on Windows

[Eli Zaretskii]

> Date: Wed, 10 Jan 2024 16:16:24 +0100
> From:  Michael Albinus via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> I've fixed this in the master branch. Could you, pls, give it some
> testing. Since I don't use MS Windows regularly, I could try only some
> few tests.

Seems to work here, thanks.

bug#68320: 30.0.50; filename completion with tramp fails on Windows

[Corwin Brust]

> > Michael Albinus <michael.albinus@gmx.de> writes:
> > >>> 1. Start Emacs that is placed in D: drive.
> > >>> 2. Evaluate (require 'tramp) to load tramp.el.
> > >>> 3. Type C-x C-f c : / TAB TAB
> > >>
> > >
> > I've fixed this in the master branch. Could you, pls, give it some
> > testing.
>

I can no longer reproduce as of cd0eb055fd4ebc3f7f7f5f5617549f963fe8ecff

Here is a set of Windows x64 binaries created from that revision:

https://corwin.bru.st/emacs-30/emacs-30-cd0eb0/

bug#68320: 30.0.50; filename completion with tramp fails on Windows

[Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Version: 30.1

Corwin Brust <corwin@bru.st> writes:

Hi Corwin,

>> > I've fixed this in the master branch. Could you, pls, give it some
>> > testing.
>
> I can no longer reproduce as of cd0eb055fd4ebc3f7f7f5f5617549f963fe8ecff

Thanks for the feedback. Taking also into account the feedback from Eli,
I assume the problem is fixed. Closing the bug.

Best regards, Michael.

bug#68320: 30.0.50; filename completion with tramp fails on Windows

[Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

Hi Eli,

>> I've fixed this in the master branch. Could you, pls, give it some
>> testing. Since I don't use MS Windows regularly, I could try only some
>> few tests.
>
> Seems to work here, thanks.

Thanks for the feedback. My concern is rather that there could be a
regression in completion of remote file names on MS Windows. However, my
few test didn't show such bad.

Let's observe for the next couple of days whether people report problems.

Best regards, Michael.

bug#68320: 30.0.50; filename completion with tramp fails on Windows

[Corwin Brust]

On Wed, Jan 10, 2024 at 10:59 AM Michael Albinus via Bug reports for
GNU Emacs, the Swiss army knife of text editors
<bug-gnu-emacs@gnu.org> wrote:
>
>
> Let's observe for the next couple of days whether people report problems.
>

Completion of remote filenames works as normal for me from HEAD.  (It
worked as well before, so I think there is not a regression here
speaking from my own C-f C-x /pscp:...  based use-case.)

bug#68320: 30.0.50; filename completion with tramp fails on Windows

[Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Corwin Brust <corwin@bru.st> writes:

Hi Corwin,

>> Let's observe for the next couple of days whether people report problems.
>
> Completion of remote filenames works as normal for me from HEAD.  (It
> worked as well before, so I think there is not a regression here
> speaking from my own C-f C-x /pscp:...  based use-case.)

Thanks for the feedback!

Best regards, Michael.