From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Corwin Brust Newsgroups: gmane.emacs.bugs Subject: bug#72781: Emacs 29 for Windows: Uninstall.exe deletes everything in the same folder as it. Date: Sat, 24 Aug 2024 10:06:11 -0500 Message-ID: References: <861q2epha5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32953"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72781@debbugs.gnu.org To: Eli Zaretskii , Sylvan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 24 17:07:38 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1shsMb-0008P3-IF for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Aug 2024 17:07:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1shsMG-000771-E4; Sat, 24 Aug 2024 11:07:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shsMD-00076L-KO for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2024 11:07:13 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1shsMD-0006Zd-BE for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2024 11:07:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=IRz2DJcWg+KcDviNrjl5or8ORXw/Xv8PqEBKok3h/2Y=; b=l+lXZz1JLdG+QFT5kC0Q/moWL4sOoxaaunqGEuAJaIB/rWInsAzQaaKcGSQBPzlMGUrY3CFVBmbstJQ1PBKB/D6piRxfwUiirbSBrPkUt8zPPKm/XoUs747yKA+gxfHBfQii9Ts3aa/cLhgSMCLC7esPbCENOpSfFXiMu73FwnnnlrryjEL8FYnxZR2tA2DIdv6EAjXDkLaSYWGTQc2H6JfBojUmp702x8QnS49EuaLJCe1ONrM1+wMiSWM2v0fng3kDoKAWsaSIc5Bnh6zJmvNwqqdUispvfPQ07xudBZBUaN67j27WicO2d/ErBlzZ/++VqtQsc7VOI+UWC+WqsQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1shsMz-0001qc-LG for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2024 11:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Corwin Brust Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Aug 2024 15:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72781 X-GNU-PR-Package: emacs Original-Received: via spool by 72781-submit@debbugs.gnu.org id=B72781.17245120397006 (code B ref 72781); Sat, 24 Aug 2024 15:08:01 +0000 Original-Received: (at 72781) by debbugs.gnu.org; 24 Aug 2024 15:07:19 +0000 Original-Received: from localhost ([127.0.0.1]:41757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shsMJ-0001ow-2l for submit@debbugs.gnu.org; Sat, 24 Aug 2024 11:07:19 -0400 Original-Received: from mail-oa1-f47.google.com ([209.85.160.47]:38417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shsMG-0001og-Pv for 72781@debbugs.gnu.org; Sat, 24 Aug 2024 11:07:18 -0400 Original-Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-25075f3f472so865527fac.2 for <72781@debbugs.gnu.org>; Sat, 24 Aug 2024 08:06:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724511982; x=1725116782; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IRz2DJcWg+KcDviNrjl5or8ORXw/Xv8PqEBKok3h/2Y=; b=XX4Pff2MB+vI+zi42sY+X4kYOHlKJ7vjT/iAbWgX1ZTn7qZqSWAX+UlKOLp04GSCpC tzZ45dwDqciIaTzXq1sfW3ktUBlAocbeGSAMYQMw5NIRh+xAxMAip1KM5daTfpHJlhln mo5Rm2j8OgWjHp5rEdg227oYQAxp7YppOgYWApgZktL/+9t1BFz75QcmIHBSaN9yvlHU VGA7Iuf6MDMm7y4cBvR6CQ08a5ESWn08S5K7ht0lk1HsbeD7Zc/EB1Ni/RrvNIiEN4nG Wk5pARNowXzEv8vQC/4gr6gXmpKTS4rWlRD/dVYX9leQ2eHTGsd6ax9jad8K82JYGyQJ W1XA== X-Gm-Message-State: AOJu0YxnZrFt1dVvcItSeLV1cjaaODpbt7/IVv+2B+kQfxFP1eawWpSq K7/obIvWbEyNpFKEENQS5MnKhLy+6zhRTUyj/YX9EUoJunKgLcVnOnONkbFwmzvUOmgKLHmA+fN N1frGPqbvUgd+2//nsYcg4iPutBY= X-Google-Smtp-Source: AGHT+IFbcJH4ClaJib3MUeuWH3sfXbEJk+4hk+A2myIJt01/e1wbGuifzSgw5Vm7kGMAoTVf2FDngZPpvgdId8gclC8= X-Received: by 2002:a05:6830:2b2c:b0:704:474f:b846 with SMTP id 46e09a7af769-70e0ec17ab1mr3096062a34.3.1724511982282; Sat, 24 Aug 2024 08:06:22 -0700 (PDT) In-Reply-To: <861q2epha5.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290676 Archived-At: Tags: 72781 Merge: 68756 thank you On Sat, Aug 24, 2024 at 1:27=E2=80=AFAM Eli Zaretskii wrote: > > > Date: Fri, 23 Aug 2024 22:06:59 +0000 > > From: Sylvan via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > > > > > Expected behaviour after Step 6: > > The emacs-29.4 folder and Uninstall.exe are gone, but any other files o= r folders remain. > > Actual behaviour after Step 6: > > All files and folders in your test file are gone. > > > > Expected behaviour after Step 7: > > The test folder made in Step 1 still exists. > > Actual behaviour after Step 7: > > The test folder made in Step 1 has been deleted. > > Upon pressing the back button in Windows Explorer, I received an error = message saying > > "C:\Users\redacted\Downloads\testfolder is unavailable. If the location= is on this PC, make sure the device or > > drive is connected or the disc is inserted, and then try again. If the = location is on a network, make sure you're > > connected to the network or Internet, and then try again. If the locati= on still can't be found, it might have been > > moved or deleted." > > Adding Corwin, who provided the Windows installer. > Sylvan, I believe this is the same problem as reported in bug#68756, hence I am merging them. That bug report contains a patch which was tested (but not installed) back in Feburary, one of three patch-sets for the Windows installer/uninstaller that have been awaiting my attention far too long. I plan to retest these (starting with this one) this morning with intent to apply as soon as I can confirm they appear to resolve the (most important, incorrect file deletion) problem; apologies I wasn't able to resolve this before you were bitten. Here's a link to the other report, containing the patch to avoid uninstaller deleting versions other than that from the corresponding installer: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D68756 Are you able to build Emacs locally to test? I would normally upload a set of binaries incorporating my patches to my own website to make it easier for others who are not in a position to compile Emacs for Windows; however, if you plan to build your own Emacs to test my fixes in this case, I might skip that in name of moving a little more quickly. (I have a Windows machine separate from my "development environment" where I'm able to test myself however both of these machines are Windows 10 - I don't have anything running Windows 11 at my disposal. It would be lovely to get confirmation the fix works under Windows 11 (although I see no reason it should not). Eli, I would like to install this directly to the release branch. I believe we had discussed doing so when the release branch was for Emacs 29 but please tell me if this must go to the development branch, instead. As I suspect you are aware, the change here is specifically to the NSIS script within admin/nt/dist-build and thus cannot affect other than the installer for Windows. Moreover, as this issue potentially causes Emacs to unexpectedly delete files I think it is rather serious. If my changes cause further problems I expect to "fix and fall forward"; so, while I'm confident -existing patch, previously tested- it's possible this will not be the "one-and-done" I expect. Please let me know I must apply to the main branch (for Emacs 31), instead.