From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Corwin Brust Newsgroups: gmane.emacs.bugs Subject: bug#65206: 29.1; [windows][patch] build-deps-zips.py is broken and hard to maintain Date: Wed, 16 Aug 2023 08:41:25 -0500 Message-ID: References: <83msyzhvpz.fsf@gnu.org> <837cpw9uq6.fsf@gnu.org> <834jl09tvy.fsf@gnu.org> <83leeb8a0j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36766"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65206@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 16 15:44:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWGos-0009MB-SU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Aug 2023 15:44:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWGmh-0006rD-Vu; Wed, 16 Aug 2023 09:42:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWGmg-0006qL-4M for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2023 09:42:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWGmf-0001Nx-Pu for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2023 09:42:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qWGmf-0002QH-MI for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2023 09:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Corwin Brust Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Aug 2023 13:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65206-submit@debbugs.gnu.org id=B65206.16921933099289 (code B ref 65206); Wed, 16 Aug 2023 13:42:01 +0000 Original-Received: (at 65206) by debbugs.gnu.org; 16 Aug 2023 13:41:49 +0000 Original-Received: from localhost ([127.0.0.1]:39562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWGmS-0002Pj-Dd for submit@debbugs.gnu.org; Wed, 16 Aug 2023 09:41:49 -0400 Original-Received: from mail-oo1-f50.google.com ([209.85.161.50]:55591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWGmL-0002PG-Rj for 65206@debbugs.gnu.org; Wed, 16 Aug 2023 09:41:43 -0400 Original-Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-56dd683e9b3so3401907eaf.3 for <65206@debbugs.gnu.org>; Wed, 16 Aug 2023 06:41:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692193296; x=1692798096; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0BszWpAlRj9oYE/QC2GJHksLNh6+NRFwQJgrYHgcaEE=; b=b5pf/Ej7e5+2zBHCV0D7ioFlFXgppaZdGCsclmNNgIzN/GVGIvg9JRMryVuTPrdFBd Cv3Lzb1aM2kNxkHXur5QZ3BT947BOyCfvXzmVd1QEP4o11XnLB6rxSBQjJvpTklkV5Pe ke01DbpZ6U6gt1t+zpJS72W3ANetawBcUvUyAX2ghSwOH1riLrPbRxOvJA9LdeEjVtjq MlCqy+q0XkseJwKT0zI/HKLJKOSwuS94VK5Xy6w1inPvf2oagimgBiFvzSj2jP5fyZpJ tF02Nm6ewkju33g9McLbbsqEYwekEk6db7e7EBQQ10k3JVY7olgNKUjFfpgqmzAac03m yuOA== X-Gm-Message-State: AOJu0YzKWq4oDKXiOyPch2e48b7rk67h7sOH3aaPlOSS3CaU+x+QTvf6 IxcrEXpeVqRRMOTk4GNUpFJEgXmIXIOmK2GTuYE= X-Google-Smtp-Source: AGHT+IGIMEGmwVRQr7BR43SMk43fWhoxKbe2Y+ITvksfGsoCwez34EE4HkRN7wnU9OT13zrBwQYB3F//lL+h6W1Bd18= X-Received: by 2002:a05:6870:a194:b0:1bf:11f1:4729 with SMTP id a20-20020a056870a19400b001bf11f14729mr2002839oaf.56.1692193296151; Wed, 16 Aug 2023 06:41:36 -0700 (PDT) In-Reply-To: <83leeb8a0j.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267586 Archived-At: On Wed, Aug 16, 2023 at 7:08=E2=80=AFAM Eli Zaretskii wrote: > > > From: Corwin Brust > > Date: Tue, 15 Aug 2023 20:23:44 -0500 > > Cc: 65206@debbugs.gnu.org > > > > On Tue, Aug 15, 2023 at 11:01=E2=80=AFAM Eli Zaretskii w= rote: > > > > > > the list in dynamic-library-alist, on lisp/term/w32-win.el. > > I'm not sure I understand the reservation. That list mentions every > single DLL that we know can be used for each optional feature. If a > feature has more than one DLL listed, the first one is usually the > most popular, and should be tried first. This solves my worry completely, or nearly so. To confirm: when walking the list, I will want to take the first DLL mentioned that actually exists for each entry. Is that right? > Given this, what problems do you envision with using that list? There might not be a problem (except the one we are trying to fix). The alist contains 22 entries, while var DLL_REQ contains 14 entries. The five on the alist but on mentioned in the script (so far) are: gdiplus shlwapi gobject gio webpdemux - this is pretty obviously a miss in the script; it does get however because it's required by webp which is listed in DLL_REQ Are all of these errors with the script (so, the corresponding DLLs should be included)? If not, I think we will need a way for the script to know which alist entries to skip/ignore. > > Does a "invokes Emacs now and errors out if stuff is missing" approach > > sound right/good? > > I'm not sure I understand how would you force Emacs to "error out" > when we are talking about optional dependencies. They are optional so > that Emacs could run even if they are not present. > Oops, badly said: I mean that my build and packaging process should stop and report an error if it cannot create a "complete" DEPS ZIP. Nothing affecting the Emacs run-time.