all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Corwin Brust <corwin@bru.st>
To: Stefan Kangas <stefankangas@gmail.com>, 68919-done@debbugs.gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>
Subject: bug#68919: 30.0.50; etc/w32-feature.el: tests do not work under --batch
Date: Mon, 23 Dec 2024 21:28:28 -0600	[thread overview]
Message-ID: <CAJf-WoS=cY8ctCS7qtVNiwSTGnRaPyEEZWZDuXPnyM6NvM4qLw@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmksUqPkqqP87wMwtA6EqdB2Epd2RAu8Fag2QG=QF82xhw@mail.gmail.com>

On Mon, Dec 23, 2024 at 9:05 PM Stefan Kangas <stefankangas@gmail.com> wrote:
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Corwin Brust <corwin@bru.st>
> >> Date: Sun, 4 Feb 2024 09:25:32 -0600
> >> Cc: 68919@debbugs.gnu.org
> >>
> >> On Sun, Feb 4, 2024 at 1:08 AM Eli Zaretskii <eliz@gnu.org> wrote:
> >> >
> >> > We can do better than this, I think.  The following works in batch
> >> > mode:
> >> >
> >> >   emacs -batch --eval "(message \"%s\" (get 'uniscribe 'font-driver-superseded-by))"
> >> >    => harfbuzz
> >> >
> >>
> >> Thank you, Eli - let me know if this is better.
> >
> > LGTM, thanks.
>
> Corwin, could you please install this patch and close this bug?
>

Done with 0e43e35f96e..c29b798537e  emacs-30 -> emacs-30.
Thank you.

> >
> >> (Should we continue using frame-parameters in when display-graphic-p
> >> is t?  I assume not; this works in both cases and is thus better
> >> because it's simpler, or so I have thought.)
> >
> > Yes, for this particular feature there's no need to use
> > frame-parameters anymore, since the above test works in all kinds of
> > session.
>
> Not sure what to do about this part.
>

Nothing to be done, I believe. Here I think Eli confirms I was correct
to ignore `display-graphic-p' because the font-driver-superseded-by
will only eq harfbuz when Emacs was both built with support for
harfbuzz -and- actually succeeded in loading the DLL in the run-time,
(so I guess we load that DLL even in batch mode :)





      reply	other threads:[~2024-12-24  3:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-04  3:37 bug#68919: 30.0.50; etc/w32-feature.el: tests do not work under --batch Corwin Brust
2024-02-04  3:41 ` corwin
2024-02-04  7:08   ` Eli Zaretskii
2024-02-04 15:25     ` Corwin Brust
2024-02-04 15:34       ` Eli Zaretskii
2024-12-24  3:05         ` Stefan Kangas
2024-12-24  3:28           ` Corwin Brust [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJf-WoS=cY8ctCS7qtVNiwSTGnRaPyEEZWZDuXPnyM6NvM4qLw@mail.gmail.com' \
    --to=corwin@bru.st \
    --cc=68919-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.