From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Corwin Brust Newsgroups: gmane.emacs.bugs Subject: bug#67667: bug#68756: Uninstalling emacs does not remove Start Menu entries created during the installation Date: Sun, 11 Feb 2024 16:56:17 -0600 Message-ID: References: <37a30898d11190e4e6e03faafecde143d90b7d9d.camel@aegee.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000568f1d06112312e7" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36212"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68756@debbugs.gnu.org, 67667@debbugs.gnu.org To: Stefan Kangas , =?UTF-8?Q?=D0=94=D0=B8=D0=BB=D1=8F=D0=BD_?= =?UTF-8?Q?=D0=9F=D0=B0=D0=BB=D0=B0=D1=83=D0=B7=D0=BE=D0=B2?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 11 23:57:07 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZIl1-0009BS-PO for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Feb 2024 23:57:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZIkl-0003i9-0p; Sun, 11 Feb 2024 17:56:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZIkg-0003hH-Gx for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2024 17:56:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZIkg-0005nl-8J for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2024 17:56:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZIkw-00080e-9g for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2024 17:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Corwin Brust Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Feb 2024 22:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67667 X-GNU-PR-Package: emacs Original-Received: via spool by 67667-submit@debbugs.gnu.org id=B67667.170769221630761 (code B ref 67667); Sun, 11 Feb 2024 22:57:02 +0000 Original-Received: (at 67667) by debbugs.gnu.org; 11 Feb 2024 22:56:56 +0000 Original-Received: from localhost ([127.0.0.1]:56128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZIkp-0007zw-7F for submit@debbugs.gnu.org; Sun, 11 Feb 2024 17:56:56 -0500 Original-Received: from mail-oa1-f54.google.com ([209.85.160.54]:54609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZIkl-0007zT-R7; Sun, 11 Feb 2024 17:56:52 -0500 Original-Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-21959151f4fso1061058fac.1; Sun, 11 Feb 2024 14:56:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707692189; x=1708296989; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pdRpbugKJD/gh9Fr9Nv3QkqvO/r6Tvl9Yke2BKGBE4U=; b=rjE3lbdQoL4HYpYg/JX8wzUNQ5z6xQGXk6Fy1nWQWjC/NnZHCgWKbmXRuoBhl5p7Zo 7nuDTCFZcjOjq6errWXxI8BFoo42+ghBzCEypgK3FNwtFl7altjpmeVpTA1FQSPksfTZ epx2yWNR+V5ARiKg+dXKlgiMvHHOKLIbiAA78wmn0W19dwnpQBWIQuoUIraEjk4ZtNba AIgqq0YILfLGXBPb9PPz+u6r2VfR+2Rc4CDp0uTJn2L3amS16NQ0JG+pXDroq9j8XJ1F ybQ4ZOEGyDPzmr10PNQ5VtOD7fChcs5sh7zjLSuapkW8FA7h1ffQCOiCFxuuj4QN4sV9 1g5g== X-Forwarded-Encrypted: i=1; AJvYcCWUI+x8QGPkWZ+v3aOzPwTbJW5fl8na7qzeaeYhPL58QO84+fUy4aDKf8R5MRAhttLjT+lMDnHoiHIRo9of6qjJBCvzJTg= X-Gm-Message-State: AOJu0Yzjm7VHRQzRWoZGZduc8JGpn8yjvStdsUkX2X0hUd3beeWS2h9x Oo8CjHP9LWGmNhpy5wEwKKHErsY08WuithwRc8EYnIsvT5fXJwp8Ed/mzWGkQRpQj5cSL5YbGH0 56DmELVkPTY7SKOQ+/0a8fmRdMzw= X-Google-Smtp-Source: AGHT+IFrSMIp9Se23hJKW0TPRs8SSZb/DbJYLJBrH6NSZvZP0PddDgzP+GkrwaCd9/JeWUUgpekNr59Wmqn7GEZL3Nk= X-Received: by 2002:a05:6871:112:b0:219:3b40:702a with SMTP id y18-20020a056871011200b002193b40702amr4271753oab.35.1707692189394; Sun, 11 Feb 2024 14:56:29 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279877 Archived-At: --000000000000568f1d06112312e7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable tags 68756 + patch thanks =D0=94=D0=B8=D0=BB=D1=8F=D0=BD, I have created an installer based on the a= ttached patch and posted it to my own site. If you try that out please let me know what you think. https://bru.st/i/emacs-29.2.50_bug%2358756-installer.exe Note, this is based on the "tip" of the emacs-29 branch, and not built from the release sources for no other reason than expediency: I am running a CI locally so I can easily test changes to the NSI installer without (especially) compiling other things. And that also means I'm quite open to trying things, if we come up with more adventurous changes than those proposed here. Reprising your original expectations: > =E2=80=A2 Uninstalling emacs should remove the Start Menu directories, cr= eated during installing emacs. This is fixed, I believe, however a bug remains (I will file a new bug given we wind up taking things in pieces, as I'm suggesting): customizing the name of the Start Menu folder isn't working for me with or without this patch. Meanwhile: > =E2=80=A2 Installing emacs should ask to first remove the previously inst= alled emacs version, as long as it does not do inplace upgrade (substitutio= n). Per this patch I did not add any Sections or controls, however a given uninstaller will no-longer delete any other versions beside the one it installed. I am open to better and more dramatic changes, but I think it might make sense to work in stages, perhaps under quite granular bug reports. In any event, I expect to "work my way up" to any more complex changes needed to the NSI script incrementally. Stefan, I think the attached minimal change, plus the other patch for not needing to "accept" licensing in 67667 (which tracker I've added in CC), would be a good basis for making a 29.2_2. Ideally, we could push these two and then I will create a 29.2_2 set. From there, I'll probably focus on improving things for the 30.1 series pre-tests notwithstanding "show stoppers" with the top-of-stack 29.x binaries. I can work on (each of) this smaller changes as much as needed, but I'd like to keep the installer simple while we do. (E.g. defer adding any new Sections/pages or controls we can live without until Emacs 30.) As an example of something not addressed by the patch, only the mostly recently installed Emacs can be uninstalled. To address that will require giving each uninstaller a unique name as part of creating it under the installation target directory. I'm fairly confident I'll get that right, but I'm not as confident as I am of the one attached. Moreover, I would prioritize fixing the issue of (potentially) deleting several installed versions without mentioning (which, =D0=94=D0=B8= =D0=BB=D1=8F=D0=BD, thank you again for reporting that that is happening). Corwin --000000000000568f1d06112312e7 Content-Type: application/octet-stream; name="0001-admin-nt-dist-build-emacs.nsi-Uninstall-delete-one-version-only.patch" Content-Disposition: attachment; filename="0001-admin-nt-dist-build-emacs.nsi-Uninstall-delete-one-version-only.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lsi1vvja0 KiBhZG1pbi9udC9kaXN0LWJ1aWxkL2VtYWNzLm5zaTogKFVuaW5zdGFsbCkgZGVsZXRlIG9ubHkg b25lIHZlcnNpb24KClByZXZpb3VzbHksIHRoZSB1bmluc3RhbGxlciB3b3VsZCByZWN1cnNpdmVs eSwgdW5jb25kaXRpb25hbGx5LCByZW1vdmUKdGhlIHBhcmVudCBmb2xkZXIsIHJhdGhlciB0aGFu IHRoZSBzdWItZm9sZGVyIGNvbnRhaW5pbmcgdGhlIGJpbmFyaWVzCmNvcnJpc3BvbmRpbmcgdG8g dGhlIGluc3RhbGxlci4gIE5vdyBVbmluc3RhbGwgd2lsbCBhbHdheXMgcmVtb3ZlIHRoZQpmaWxl cyBjb3BpZWQgZHVyaW5nIEluc3RhbGwgYW5kIHJlbW92ZSAoZS5nLikgIlByb2dyYW0gRmlsZXNc RW1hY3MiIG9ubHkKaWYgbm8gb3RoZXIgKGUuZy4pICBjb3BpZXMgb2YgRW1hY3MgKG9yIG90aGVy IGZpbGVzKSByZW1haW4KdGhlcmVpbi4gQWRkaXRpb25hbGx5LCB0aGUgdW5pbnN0YWxsZXIgZGlk IG5vdCByZW1vdmUgdGhlIFNob3J0Y3V0IHRvCnJ1bmVtYWNzLmV4ZSwgcHJldmVudGluZyBkZWxl dGlvbiBvZiB0aGUgU3RhcnQgTWVudSBlbnRyeS4gKEJ1ZyM1Njg1NikKLS0tCiBhZG1pbi9udC9k aXN0LWJ1aWxkL2VtYWNzLm5zaSB8IDggKysrKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvYWRtaW4vbnQvZGlzdC1idWls ZC9lbWFjcy5uc2kgYi9hZG1pbi9udC9kaXN0LWJ1aWxkL2VtYWNzLm5zaQppbmRleCA1NTdiYjEw NmRkZS4uYmM5ZGI2MWI5YWUgMTAwNjQ0Ci0tLSBhL2FkbWluL250L2Rpc3QtYnVpbGQvZW1hY3Mu bnNpCisrKyBiL2FkbWluL250L2Rpc3QtYnVpbGQvZW1hY3MubnNpCkBAIC02NiwxMiArNjYsMTYg QEAgU2VjdGlvbiAiVW5pbnN0YWxsIgogICAjIEFsd2F5cyBkZWxldGUgdW5pbnN0YWxsZXIgZmly c3QKICAgRGVsZXRlICIkSU5TVERJUlxVbmluc3RhbGwuZXhlIgogCi0gICMgbm93IGRlbGV0ZSBp bnN0YWxsZWQgZGlyZWN0b3J5Ci0gIFJNRGlyIC9yICIkSU5TVERJUiIKKyAgIyByZWN1cnNpdmVs eSBkZWxldGUgZGlyZWN0b3J5IGZvciB0aGlzIHZlcnNpb24KKyAgUk1EaXIgL3IgIiRJTlNURElS XGVtYWNzLSR7VkVSU0lPTl9CUkFOQ0h9IgorCisgICMgcmVtb3ZlIHRoZSBFbWFjcyBkaXJlY3Rv cnkgaW4gUHJvZ3JhbSBGaWxlcyAoaWYgZW1wdHkpCiAgIFJNRGlyICIkSU5TVERJUiIKIAogICAh aW5zZXJ0bWFjcm8gTVVJX1NUQVJUTUVOVV9HRVRGT0xERVIgQXBwbGljYXRpb24gJFN0YXJ0TWVu dUZvbGRlcgogCisgICMgcmVtb3ZlIFN0YXJ0IE1lbnUgUHJvZ3JhbSBzaG9ydGN1dHMKKyAgRGVs ZXRlICIkU01QUk9HUkFNU1wkU3RhcnRNZW51Rm9sZGVyXEVtYWNzLmxuayIKICAgRGVsZXRlICIk U01QUk9HUkFNU1wkU3RhcnRNZW51Rm9sZGVyXFVuaW5zdGFsbC5sbmsiCiAgIFJNRGlyICIkU01Q Uk9HUkFNU1wkU3RhcnRNZW51Rm9sZGVyIgogU2VjdGlvbkVuZAotLSAKMi4zNi4xCgo= --000000000000568f1d06112312e7--