From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Corwin Brust Newsgroups: gmane.emacs.devel Subject: Re: Windows binaries and installer fixes for 30.0.93 Date: Mon, 23 Dec 2024 10:02:13 -0600 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34885"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs developers To: Francis Wright Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 23 17:03:22 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tPktt-0008tB-SE for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Dec 2024 17:03:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tPkt7-00053g-VX; Mon, 23 Dec 2024 11:02:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPkt2-00053N-WD for emacs-devel@gnu.org; Mon, 23 Dec 2024 11:02:29 -0500 Original-Received: from mail-ot1-f43.google.com ([209.85.210.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tPkt1-00017g-Cp for emacs-devel@gnu.org; Mon, 23 Dec 2024 11:02:28 -0500 Original-Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-71e111248a2so129725a34.0 for ; Mon, 23 Dec 2024 08:02:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734969745; x=1735574545; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rKGaF2BNBXwGyqh2DRymXneeY5E/eTLwyq8IQFfl9vY=; b=Tg2GTeGYxaHSBMzWRGpwh9knU48xfX9swjc2NGJJqY1x5VaoUb9cQLdbx8GOJAlMh3 xPOC5ws1s8Nb30O9TzQea3oztuJCxonBjk3x0Ra6y7dLs+EQHyasCqFoooFiiQIGLtVM jHhe3iWKnfWc0RdsXaBQdZzhbp2MmxJHpyc7/199bAHbxSo8sEHC6uzKRGk5kIvnOx9y e5jBt6f3NqZAXOgD46UE5/5KRH+T9B8LbkwB5f3EildikWIwP3ZgJ6q9qcAcAUBOkR2u +gIwnLdC/Y3ymHKgAWExy3x8gJ34Gz7hjs0uwEQfmu+iTbYviyxBKwPDhQdtfCXvTU9P eVTw== X-Gm-Message-State: AOJu0YwVNMLmskz0XA7dZFiKGkLap+NI/y/QZUomdnKh4cotsWK6M5i8 6p/vx35iNcZQsKPThO9AiZCJmp3gwXRe+Ov9tAdQl2aBQ/zPueLwuNm4bxP5Ow5uUt/BS0hhFAL nzFqvZjBAJ5k5OPmejvUrZ89uY+0= X-Gm-Gg: ASbGncuMOwrUBBkqjRDrxwHMQOEqM/EN48O8+7FP9+qHQx8rv41T8wHCs0hGbBBoEpR 522rtjSZ386oS+vQO54sOUjyeI7JZS6gIXjMh X-Google-Smtp-Source: AGHT+IGu7OIZlmEqN6QyY44mM8X9T6gRQwPbVhxPKh0VD5IsPwGTrLWYG3Pzdpi7fPljmDpVNNl09hwkwgb1G/HQp+0= X-Received: by 2002:a05:6830:d18:b0:717:f7b9:e229 with SMTP id 46e09a7af769-720ff94cc30mr3839086a34.7.1734969745339; Mon, 23 Dec 2024 08:02:25 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=209.85.210.43; envelope-from=mplscorwin@gmail.com; helo=mail-ot1-f43.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.165, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326914 Archived-At: Hi Francis, more detail in-line below, but: thanks so much for your work testing. Based on what you've said I suspect the installer is where we want it to be for Emacs 30.1 now. Please review my additional responses/comments and let me know if you agree (or, if not, what else you might be critical to fix before the release is cut). On Mon, Dec 23, 2024 at 4:29=E2=80=AFAM Francis Wright wrote: > > Thanks for the update. The _4 version of the installer seems to behave as= I would expect on Windows. It creates a Start menu link called Emacs that = runs Emacs. I presume that the next version of Emacs will overwrite that li= nk so that by default users will just have that one link that runs the late= st version of Emacs, although older versions will still be installed, but n= ot accessible via the Start menu. I was able to uninstall Emacs 30.0.93 via= the Apps Settings page. Everything that was supposed to disappear did so, = and nothing else disappeared. So this all looks good to me. > The installer creates one Start Menu folder per run (given that creating Start Menu shortcuts was not when the installer was run). Each shortcut is named for the release version (e.g. "emacs-30.0.93" in the case of all of these versions of the pretest installer). This isn't new behavior but is the way the installer has worked for years (long before I was using it myself to build the binary releases). We have talked about adding more choices/controls to the installer page, for example we could offer a page with choices like this: How would you like to install? (x) separate folders and Start Menu shortcuts for each install Emacs ( ) Rolling updates to one copy of Emacs on my system I have been of view that it will be best to take on this type of new functionality in the master (not release) branch, meaning after we get the installer stable and free from obvious bugs with what it already is supposed to be able to do (hopefully in time for Emacs 30.1). > However, the installer still displays the Choose Start Menu Folder dialog= ue, even though it no longer uses a Start menu folder, so it might be bette= r to suppress that dialogue. Alternatively, you could keep the folder and p= ut the link to the executable in it, so that users would see all the instal= led versions of Emacs in the Start menu. That would be consistent with the = recent behaviour of the installer and might be a better option. > The Start Menu related options are not ignored (although checking the box to suppress creating shortcuts should work now). I added the Uninstaller regkey so that we can launch uninstaller via the Control Panel but that didn't (shouldn't have, doesn't seem to ) cause anything about launching Emacs (or the uninstaller) via the start menu shortcuts (when they are enabled to be created during installation). Overall your (I perceive) expectation that the Windows Installer should effectively default to "in-place" upgrades of a single version of Emacs makes sense to me, but: that isn't what it has ever done in the past (at least, not by design) and it would be a big enough change I'd much rather do it on master where we'll have a good long time after installing to hear back from people who might find the new behavior surprising, new options confusing, etc. I'm wide open to ideas/suggestions on how to spiff-up the installer but I think, for this round of patching, we should focus on making it do what it "has always done" without major defects. After that we can turn our attention to improvements, knowing that the 30.1 installer won't be as terrible as the 29.x series installers were. TDYT? With Gratitude and Curiosity, Corwin