bug#18938: Emacs 24.3: newline-and-indent has two undo boundaries

bug#18938: Emacs 24.3: newline-and-indent has two undo boundaries

[Samuel Wales]

Reporting as suggested by Stefan.

In order to bunch up undos by 1 instead of the hardcoded 20, I do this:

  (add-hook 'post-self-insert-hook #'undo-boundary 'append)

This or advice used to work, then around Emacs 24.1 it stopped
working.  Stefan patched it in 24.3.  It now works in most cases.  The
history is in this Debian bug:

  Re: [O] bug#11774: bug#11774: org-mode causes undo boundaries to be lost

I use undo-tree 0.6.6.  The bug also occurs with it turned off.

When I press RET when it is bound to newline-and-indent, the newline
and the indentation are undone separately.  I expected the RET to be
undone.

This is a minor issue for me, but might point to other cases.

Thanks.

Samuel

bug#18938: Acknowledgement (Emacs 24.3: newline-and-indent has two undo boundaries)

[Samuel Wales]

I found more places where this bug occurs.  A major [i.e. common] one
is that M-RET in Org will create a new headline, but undo requires two
steps.

-- 
The Kafka Pandemic: http://thekafkapandemic.blogspot.com

The disease DOES progress.  MANY people have died from it.  And
ANYBODY can get it.

Denmark: free Karina Hansen NOW.

bug#18938: Emacs 24.3: newline-and-indent has two undo boundaries

[Noam Postavsky]

tags 18938 fixed
close 18938 24.4
quit

Samuel Wales <samologist@gmail.com> writes:

> Reporting as suggested by Stefan.
>
> In order to bunch up undos by 1 instead of the hardcoded 20, I do this:
>
>   (add-hook 'post-self-insert-hook #'undo-boundary 'append)
>
> This or advice used to work, then around Emacs 24.1 it stopped
> working.  Stefan patched it in 24.3.  It now works in most cases.  The
> history is in this Debian bug:
>
>   Re: [O] bug#11774: bug#11774: org-mode causes undo boundaries to be lost
>
> I use undo-tree 0.6.6.  The bug also occurs with it turned off.
>
> When I press RET when it is bound to newline-and-indent, the newline
> and the indentation are undone separately.  I expected the RET to be
> undone.

Seems to be fixed in 24.4

bug#18938: Emacs 24.3: newline-and-indent has two undo boundaries

[Samuel Wales]

yes, it seems to be fixed in 24.4.1 on debian jessie.  i do not have
access to other versions.

thank you.

On 5/31/18, Noam Postavsky <npostavs@gmail.com> wrote:
> tags 18938 fixed
> close 18938 24.4
> quit
>
> Samuel Wales <samologist@gmail.com> writes:
>
>> Reporting as suggested by Stefan.
>>
>> In order to bunch up undos by 1 instead of the hardcoded 20, I do this:
>>
>>   (add-hook 'post-self-insert-hook #'undo-boundary 'append)
>>
>> This or advice used to work, then around Emacs 24.1 it stopped
>> working.  Stefan patched it in 24.3.  It now works in most cases.  The
>> history is in this Debian bug:
>>
>>   Re: [O] bug#11774: bug#11774: org-mode causes undo boundaries to be
>> lost
>>
>> I use undo-tree 0.6.6.  The bug also occurs with it turned off.
>>
>> When I press RET when it is bound to newline-and-indent, the newline
>> and the indentation are undone separately.  I expected the RET to be
>> undone.
>
> Seems to be fixed in 24.4
>


-- 
The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>

The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.

"You’ve really gotta quit this and get moving, because this is murder
by neglect." ---
<http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.