bug#20590: mouse-highlight does not do as documented

bug#20590: mouse-highlight does not do as documented

[Samuel Wales]

mouse-highlight does not do as documented, which seems to be a bug.

i confirmed with emacs -Q.  i did not find a similar bug report.

===

"If the value is an integer, highlighting is only shown
after moving the mouse, while keyboard input turns off the
highlight even when the mouse is over the clickable text."

in my usage, highlighting shows when mouse has not moved.
it also shows when there is keyboard input.

i find highlighting highly distracting unless i am using the
mouse, yet i find it useful when i do use the mouse.  it is so
distracting that i have to turn it off unless this is fixed.

(inb4: i find that the following variables are not useful for
me in practice: mouse-avoidance-mode, track-mouse,
make-pointer-invisible.  there is no setting for mouse-avoidance-mode
that works for me.  banish does not work for me.  i do not want to fix
mouse-avoidance-mode.  i want to fix mouse-highlight.)

i use unclutter(1), which works perfectly for me to turn off the mouse,
but of course does not turn off the highlighting.  if mouse-highlight
could do as documented, it would be great.

thanks.


In GNU Emacs 24.4.1 (x86_64-pc-linux-gnu, GTK+ Version 3.4.2)
 of 2015-01-11 on maritornes, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.11204000
System Description:	Debian GNU/Linux 7.8 (wheezy)

Configured using:
 `configure --build x86_64-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/lib
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.4/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.4/site-lisp:/usr/share/emacs/site-lisp
 --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib
 --libexecdir=/usr/lib --localstatedir=/var/lib
 --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.4/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.4/site-lisp:/usr/share/emacs/site-lisp
 --with-x=yes --with-x-toolkit=gtk3 --with-toolkit-scroll-bars
 'CFLAGS=-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat
 -Werror=format-security -Wall' CPPFLAGS=-D_FORTIFY_SOURCE=2
 LDFLAGS=-Wl,-z,relro'

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

bug#20590: mouse-highlight does not do as documented

[Eli Zaretskii]

> Date: Sat, 16 May 2015 11:09:33 -0700
> From: Samuel Wales <samologist@gmail.com>
> 
> mouse-highlight does not do as documented, which seems to be a bug.
> 
> i confirmed with emacs -Q.  i did not find a similar bug report.
> 
> ===
> 
> "If the value is an integer, highlighting is only shown
> after moving the mouse, while keyboard input turns off the
> highlight even when the mouse is over the clickable text."
> 
> in my usage, highlighting shows when mouse has not moved.
> it also shows when there is keyboard input.

I cannot reproduce this.  You didn't show a precise recipe you used,
so here's mine:

 . emacs -Q
 . C-h v mouse-highlight RET
 . move the mouse pointer above the hyper-link labeled "C source code"
   and observe the highlight
 . type some character -- the highlight stays on
 . M-x set-variable RET mouse-highlight RET 1 RET
 . type some character -- the highlight goes off
 . move the mouse pointer a bit -- the highlight goes on

So the highlight behaves as documented for me.

For the record, I tried both Emacs 24.4, which is what you seem to
have, and the latest development sources.

bug#20590: mouse-highlight does not do as documented

[Johan Bockgård]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Sat, 16 May 2015 11:09:33 -0700
>> From: Samuel Wales <samologist@gmail.com>
>> 
>> mouse-highlight does not do as documented, which seems to be a bug.
>> 
>> i confirmed with emacs -Q.  i did not find a similar bug report.
>> 
>> ===
>> 
>> "If the value is an integer, highlighting is only shown
>> after moving the mouse, while keyboard input turns off the
>> highlight even when the mouse is over the clickable text."
>> 
>> in my usage, highlighting shows when mouse has not moved.
>> it also shows when there is keyboard input.
>
> I cannot reproduce this.  You didn't show a precise recipe you used,
> so here's mine:
>
>  . emacs -Q
>  . C-h v mouse-highlight RET
>  . move the mouse pointer above the hyper-link labeled "C source code"
>    and observe the highlight
>  . type some character -- the highlight stays on
>  . M-x set-variable RET mouse-highlight RET 1 RET
>  . type some character -- the highlight goes off
>  . move the mouse pointer a bit -- the highlight goes on
>
> So the highlight behaves as documented for me.
>
> For the record, I tried both Emacs 24.4, which is what you seem to
> have, and the latest development sources.

The problem was introduced by

commit 742516e02048d3bbfba4e6e13dd19afa097bbd3b
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date:   Wed Sep 11 12:56:33 2013 +0400

    Ifdef away frame tool bar code when it is not really used.
    ...


The bug does not exist on Windows. I think this should fix it:


diff --git a/src/xterm.c b/src/xterm.c
index d9032fa..0537491 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -7056,17 +7056,18 @@ handle_one_xevent (struct x_display_info *dpyinfo,
 
       f = any;
 
-#if ! defined (USE_GTK)
       /* If mouse-highlight is an integer, input clears out
 	 mouse highlighting.  */
       if (!hlinfo->mouse_face_hidden && INTEGERP (Vmouse_highlight)
+#if ! defined (USE_GTK)
 	  && (f == 0
-	      || !EQ (f->tool_bar_window, hlinfo->mouse_face_window)))
+	      || !EQ (f->tool_bar_window, hlinfo->mouse_face_window))
+#endif
+	  )
         {
           clear_mouse_face (hlinfo);
           hlinfo->mouse_face_hidden = true;
         }
-#endif
 
 #if defined USE_MOTIF && defined USE_TOOLKIT_SCROLL_BARS
       if (f == 0)

bug#20590: mouse-highlight does not do as documented

[Samuel Wales]

hi eli,

thanks for your reply.  i tried your recipe and it is still broken.

i am using debian backport.


samuel


On 5/16/15, Eli Zaretskii <eliz@gnu.org> wrote:
>  . emacs -Q
>  . C-h v mouse-highlight RET
>  . move the mouse pointer above the hyper-link labeled "C source code"
>    and observe the highlight
>  . type some character -- the highlight stays on
>  . M-x set-variable RET mouse-highlight RET 1 RET
>  . type some character -- the highlight goes off
>  . move the mouse pointer a bit -- the highlight goes on

bug#20590: mouse-highlight does not do as documented

[Eli Zaretskii]

> From: Johan Bockgård <bojohan@gnu.org>
> Cc: Samuel Wales <samologist@gmail.com>,  20590@debbugs.gnu.org
> Date: Sat, 16 May 2015 22:06:02 +0200
> 
> >  . emacs -Q
> >  . C-h v mouse-highlight RET
> >  . move the mouse pointer above the hyper-link labeled "C source code"
> >    and observe the highlight
> >  . type some character -- the highlight stays on
> >  . M-x set-variable RET mouse-highlight RET 1 RET
> >  . type some character -- the highlight goes off
> >  . move the mouse pointer a bit -- the highlight goes on
> >
> > So the highlight behaves as documented for me.
> >
> > For the record, I tried both Emacs 24.4, which is what you seem to
> > have, and the latest development sources.
> 
> The problem was introduced by
> 
> commit 742516e02048d3bbfba4e6e13dd19afa097bbd3b
> Author: Dmitry Antipov <dmantipov@yandex.ru>
> Date:   Wed Sep 11 12:56:33 2013 +0400
> 
>     Ifdef away frame tool bar code when it is not really used.
>     ...
> 
> 
> The bug does not exist on Windows. I think this should fix it:

Looks good to me, please push.

Thanks.

bug#20590: mouse-highlight does not do as documented

[Johan Bockgård]

Eli Zaretskii <eliz@gnu.org> writes:

> Looks good to me, please push.

Done.

bug#20590: mouse-highlight does not do as documented

[Samuel Wales]

thanks!

-- 
The Kafka Pandemic: http://thekafkapandemic.blogspot.com

Ramsay's disease DOES progress.  MANY people have died from it.  And
ANYBODY can get it.

Denmark: free Karina Hansen NOW.