From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: steckerhalter Newsgroups: gmane.emacs.bugs Subject: bug#21319: `package-install-file' fails with CRLF (Windows) line endings Date: Sat, 22 Aug 2015 06:30:30 +0200 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1440221968 20645 80.91.229.3 (22 Aug 2015 05:39:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 22 Aug 2015 05:39:28 +0000 (UTC) To: 21319@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 22 07:39:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZT1WJ-0003Ss-8g for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Aug 2015 07:39:11 +0200 Original-Received: from localhost ([::1]:45506 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZT1WI-000614-EV for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Aug 2015 01:39:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZT1WE-00060C-6G for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2015 01:39:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZT1WB-0006ek-1g for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2015 01:39:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42733) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZT1WA-0006ee-Vn for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2015 01:39:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZT1WA-0000zZ-GB for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2015 01:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: steckerhalter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Aug 2015 05:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21319 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14402219163780 (code B ref -1); Sat, 22 Aug 2015 05:39:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Aug 2015 05:38:36 +0000 Original-Received: from localhost ([127.0.0.1]:34943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZT1Vj-0000yt-MU for submit@debbugs.gnu.org; Sat, 22 Aug 2015 01:38:36 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34867) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZT0Rw-0006Ae-Vr for submit@debbugs.gnu.org; Sat, 22 Aug 2015 00:30:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZT0Rv-0001Z1-JG for submit@debbugs.gnu.org; Sat, 22 Aug 2015 00:30:36 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:48012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZT0Rv-0001Yx-Gc for submit@debbugs.gnu.org; Sat, 22 Aug 2015 00:30:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZT0Ru-00077a-EK for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2015 00:30:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZT0Rr-0001WA-8A for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2015 00:30:34 -0400 Original-Received: from mail-ig0-f181.google.com ([209.85.213.181]:34250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZT0Rr-0001Vp-4B for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2015 00:30:31 -0400 Original-Received: by igui7 with SMTP id i7so30829400igu.1 for ; Fri, 21 Aug 2015 21:30:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:date:message-id:subject:from :to:content-type; bh=CqD3liGnSDux2ULo4eexBEnpMF0A0RcfvM1lagvzTew=; b=lQIzpjgzhLs6uo231qEeqR1fUpLzgD5Vs4ay4nmlSKM+3Qb5MH3Kf6tWoMOJxH3WC3 G/nPNh1e00SoR4lX+Lvrag76onxKWhfpax80RU+L2SPmOdvPOt17CRz95IFbyocd8aQN rBpd1rn6tws7PXAq0QMZ3Mo+J8ZuvxE9KzDZgE58JQjEWi93aRJMSdo13YbWNE55ev9y JisBEFmtatLjy0rnliuS0g7qm9832S1Yn/iURtTLkC50cf+eVRh86fvkzfcu1bjj54LI aFl0qjnIedribqcZ6Qu7yvSI5lbK7dIaASqVfbcnVNeWtlCMyUtvhQVD6IaH4BxOmIbu rv4A== X-Gm-Message-State: ALoCoQnV0Gcuj8Z3MsqROguJqFdORsY16MDTWgXc7shyn0COzGuxtYcO25RD/DftEGlvQwSsqMTb X-Received: by 10.50.50.174 with SMTP id d14mr6433564igo.84.1440217830108; Fri, 21 Aug 2015 21:30:30 -0700 (PDT) Original-Received: by 10.64.11.232 with HTTP; Fri, 21 Aug 2015 21:30:30 -0700 (PDT) X-Originating-IP: [46.126.219.77] X-Google-Sender-Auth: rIbyfnLYZNKx6-AHSoUTjZFTH88 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Sat, 22 Aug 2015 01:38:34 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105685 Archived-At: package.el contains this code: (defun package-install-file (file) "Install a package from a file. The file can either be a tar file or an Emacs Lisp file." (interactive "fPackage file name: ") (with-temp-buffer (insert-file-contents-literally file) (when (string-match "\\.tar\\'" file) (tar-mode)) (package-install-from-buffer))) Since `insert-file-contents-literally' does not do any conversion `package-buffer-info' fails to parse the info if the file is .el and contains CRLF line endings. It then errors out with: Debugger entered--Lisp error: (error "Package lacks a \"Version\" or \"Package-Version\" header") signal(error ("Package lacks a \"Version\" or \"Package-Version\" header")) error("Package lacks a \"Version\" or \"Package-Version\" header") package-buffer-info() This affects all recent Emacs versions (including trunk). What we did now is to replace `insert-file-contents-literally' with `insert-file-contents' dynamically for non-tar files and that seems to work, although I'm not sure if that's a good solution since I don't know if there might be side-effects somewhere that can cause other problems. The other solution I can think of might be to adapt the regexp in `package-buffer-info` so that in can deal with CRLF. cheers, steckerhalter