From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jay McCarthy Newsgroups: gmane.emacs.bugs Subject: bug#24579: [PATCH] borderless windows on OS X Date: Sat, 1 Oct 2016 18:18:00 -0400 Message-ID: References: <20161001212613.GA40646@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=94eb2c07ce247f1034053dd515d7 X-Trace: blaine.gmane.org 1475360391 5445 195.159.176.226 (1 Oct 2016 22:19:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 1 Oct 2016 22:19:51 +0000 (UTC) Cc: 24579@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 02 00:19:47 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqScp-0005fN-1M for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Oct 2016 00:19:19 +0200 Original-Received: from localhost ([::1]:57311 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqScl-0007ej-FH for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Oct 2016 18:19:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqScc-0007ec-By for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 18:19:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqScY-0003rL-3H for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 18:19:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35193) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqScX-0003r5-VQ for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 18:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bqScX-00074g-LR for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 18:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jay McCarthy Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Oct 2016 22:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24579 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24579-submit@debbugs.gnu.org id=B24579.147536028927129 (code B ref 24579); Sat, 01 Oct 2016 22:19:01 +0000 Original-Received: (at 24579) by debbugs.gnu.org; 1 Oct 2016 22:18:09 +0000 Original-Received: from localhost ([127.0.0.1]:41383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqSbh-00073V-IO for submit@debbugs.gnu.org; Sat, 01 Oct 2016 18:18:09 -0400 Original-Received: from mail-it0-f52.google.com ([209.85.214.52]:37093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqSbf-00073E-86 for 24579@debbugs.gnu.org; Sat, 01 Oct 2016 18:18:07 -0400 Original-Received: by mail-it0-f52.google.com with SMTP id j69so88885023itb.0 for <24579@debbugs.gnu.org>; Sat, 01 Oct 2016 15:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KVpp3YY6kKihRj0CRiacXtKsH5Fo2hfMILUnA9PCZPw=; b=ZTP6F8dqQnIN2U8Dihdm9+L3hJlwc7X2DQGRpIbw3pJX2AHl+VDDU5r2lHbW7rq7PB fVYqgxYQ555Tx8M/nIRA2bE1EOc6zwrGebvPITu8C5BHB4f4FlEX1S8j8rVB2ahppjfm iRSJpc53R0uYHWfrX3+rhR9Q4nIQKpBFQJZjceICk79K7Y9VpP+pT08Wvj+7B16oLmYn 5L4tFKJTFRUAxRWETWmCr2ZkovF9IZOKV8rvtlAEbXJQbN9TV7+FvtPySIGyM4JTHUEb 2ZynHhtC6a7j37IW9WFQmKhY+7bKIu3R8DOnrOfcTKpgdAwsUmWl6UKx1PbYRFuSgBOA Ji5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KVpp3YY6kKihRj0CRiacXtKsH5Fo2hfMILUnA9PCZPw=; b=TdtDL9Zi8t/8fMskPLKL5rzjs+O9pM2WdW2k+QIinYh2fdZIsJwfJlS9mJaJRzLvN2 U6rZtEyDTJUrwSjwuVe+2KnyqtH/R6ybBqwLL1Ns7WZ/VhqCgkByJmyPLPicHJ5t462i Pb9eBNqrK0ZWFeJWOCymze3n5wKBipof/eJF5gGsHUvMVJncqe2V5eRehV/ZI32tAGnK GnXmvPrdKYzIz2Lt849FQ1rUy1+qLDWCZIQi9tTpPyOwixUKIbPHNR9FS20gxM/2lgcL cSdvmThsbv6IwXTOi4+Yjm92QNDBzfOFleW2nkdgDXpLIcGxjokXNoJ8FTzQKFa7f5rp sbIw== X-Gm-Message-State: AA6/9RmLQmqX20whYeABcF3TghOYKGn7rhJTCW+g+g7H3RIyQHRFgpMrp4O07ENM2V1i5DC087Fb4oOTFza2hw== X-Received: by 10.36.205.130 with SMTP id l124mr11923399itg.121.1475360281512; Sat, 01 Oct 2016 15:18:01 -0700 (PDT) Original-Received: by 10.64.35.231 with HTTP; Sat, 1 Oct 2016 15:18:00 -0700 (PDT) In-Reply-To: <20161001212613.GA40646@breton.holly.idiocy.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123879 Archived-At: --94eb2c07ce247f1034053dd515d7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I've attached a modified version with your requests. Regarding EmacsWindow, I think it would be good to keep it around and separate, so I didn't remove it in the patch. Jay On Sat, Oct 1, 2016 at 5:26 PM, Alan Third wrote: > On Fri, Sep 30, 2016 at 09:31:09PM -0400, Jay McCarthy wrote: >> There are two popular Emacs patches for OS X that make all its windows >> have no title bar: >> >> https://github.com/nikhilunni/BorderlessEmacs >> >> https://github.com/gwydirsam/emacs-mac-borderless >> >> This patch integrates these by providing a variable >> (ns-use-titled-windows) that allows this decision to be controlled at >> runtime. The default is to use titles, like normal. > > I=E2=80=99d prefer a variable name more like =E2=80=98ns-use-titlebar=E2= =80=99, as > =E2=80=98titled-windows=E2=80=99 doesn=E2=80=99t mean very much to me. > >> -- Some comments on the patch >> >> This is my first Emacs patch. I hope it's okay. >> >> The only difference between EmacsFSWindow and EmacsWindow is >> explicitly telling OS X that the window can be the subject of focus, >> which is required for borderless windows. (EmacsFSWindow has nothing >> to do with being fullscreen.) > > I=E2=80=99d no idea about this, do we even need both types? > >> I included a note in the Changelog, because it looks like all >> variables like this get put in, but it could be removed from my >> perspective... I have no need to satisfy my pride with my name in the >> log. However, I didn't add anything to NEWS, because it seems to not >> always mention things like this. > > The changelog is automatically updated from the git repository log, as > I understand it. We=E2=80=99ll commit it using your name so you=E2=80=99l= l be credited > anyway. :) > > Also, I don=E2=80=99t think this patch will be included before Emacs 26.1= as > it=E2=80=99s a new feature, not a bug fix, so the entry in cus-start.el m= ay > need to read 26.1. > > This one=E2=80=99s a real nit=E2=80=90pick: I don=E2=80=99t like the vers= ion number being on > the next line in the variable doctype. I don=E2=80=99t see any reason why= it > can=E2=80=99t be moved up on to the previous line next to the greater=E2= =80=90than > sign. And also change =E2=80=98windows=E2=80=99 to =E2=80=98frames=E2=80= =99 and =E2=80=98title=E2=80=99 to =E2=80=98titlebar=E2=80=99. > > I can=E2=80=99t see anything wrong other than my little moans above, and = it > certainly looks like it does what it=E2=80=99s supposed to do. Thanks for > doing this. > -- > Alan Third --=20 Jay McCarthy Associate Professor PLT @ CS @ UMass Lowell http://jeapostrophe.github.io "Wherefore, be not weary in well-doing, for ye are laying the foundation of a great work. And out of small things proceedeth that which is great." - D&C 64:33 --94eb2c07ce247f1034053dd515d7 Content-Type: application/octet-stream; name="0001-Add-ns-use-titlebar.patch" Content-Disposition: attachment; filename="0001-Add-ns-use-titlebar.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itrrezxo0 RnJvbSA5ZGM2OWZhOTcxYjg1NjE3ZjJhMWFmNjM4ZTJlYTQxYWVlYTA2ODYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXkgTWNDYXJ0aHkgPGpheS5tY2NhcnRoeUBnbWFpbC5jb20+ CkRhdGU6IEZyaSwgMzAgU2VwIDIwMTYgMjE6MDg6MjcgLTA0MDAKU3ViamVjdDogW1BBVENIIDEv MV0gQWRkIG5zLXVzZS10aXRsZWJhcgoKLS0tCiBsaXNwL2N1cy1zdGFydC5lbCB8ICAxICsKIHNy Yy9uc3Rlcm0ubSAgICAgIHwgMTQgKysrKysrKysrKysrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTMg aW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2N1cy1zdGFy dC5lbCBiL2xpc3AvY3VzLXN0YXJ0LmVsCmluZGV4IGQ5YWQwYTUuLjY3YmJiYTYgMTAwNjQ0Ci0t LSBhL2xpc3AvY3VzLXN0YXJ0LmVsCisrKyBiL2xpc3AvY3VzLXN0YXJ0LmVsCkBAIC00NDYsNiAr NDQ2LDcgQEAgbWluaWJ1ZmZlci1wcm9tcHQtcHJvcGVydGllcy0tc2V0dGVyCiAJICAgICAobnMt dXNlLW5hdGl2ZS1mdWxsc2NyZWVuIG5zIGJvb2xlYW4gIjI0LjQiKQogICAgICAgICAgICAgIChu cy11c2UtZnVsbHNjcmVlbi1hbmltYXRpb24gbnMgYm9vbGVhbiAiMjUuMSIpCiAgICAgICAgICAg ICAgKG5zLXVzZS1zcmdiLWNvbG9yc3BhY2UgbnMgYm9vbGVhbiAiMjQuNCIpCisgICAgICAgICAg ICAgKG5zLXVzZS10aXRsZS1iYXIgbnMgYm9vbGVhbiAiMjYuMSIpCiAJICAgICA7OyBwcm9jZXNz LmMKIAkgICAgIChkZWxldGUtZXhpdGVkLXByb2Nlc3NlcyBwcm9jZXNzZXMtYmFzaWNzIGJvb2xl YW4pCiAJICAgICA7OyBzeW50YXguYwpkaWZmIC0tZ2l0IGEvc3JjL25zdGVybS5tIGIvc3JjL25z dGVybS5tCmluZGV4IDFiNDRhNzMuLmNkNzgyOTQgMTAwNjQ0Ci0tLSBhL3NyYy9uc3Rlcm0ubQor KysgYi9zcmMvbnN0ZXJtLm0KQEAgLTY3NzUsMTEgKzY3NzUsMTMgQEAgLSAoQk9PTClpc09wYXF1 ZQogICBtYXhpbWl6aW5nX3Jlc2l6ZSA9IE5POwogI2VuZGlmCiAKLSAgd2luID0gW1tFbWFjc1dp bmRvdyBhbGxvY10KKyAgd2luID0gW1tFbWFjc0ZTV2luZG93IGFsbG9jXQogICAgICAgICAgICAg aW5pdFdpdGhDb250ZW50UmVjdDogcgogICAgICAgICAgICAgICAgICAgICAgIHN0eWxlTWFzazog KE5TV2luZG93U3R5bGVNYXNrUmVzaXphYmxlIHwKICNpZiBNQUNfT1NfWF9WRVJTSU9OX01BWF9B TExPV0VEID49IE1BQ19PU19YX1ZFUlNJT05fMTBfNwotICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIE5TV2luZG93U3R5bGVNYXNrVGl0bGVkIHwKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAobnNfdXNlX3RpdGxlYmFyID8KKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgTlNXaW5kb3dTdHlsZU1hc2tUaXRsZWQgOgorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBOU1dpbmRvd1N0eWxlTWFza0JvcmRlcmxlc3MpIHwKICNlbmRpZgog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5TV2luZG93U3R5bGVNYXNrTWluaWF0 dXJpemFibGUgfAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5TV2luZG93U3R5 bGVNYXNrQ2xvc2FibGUpCkBAIC02ODEyLDYgKzY4MTQsNyBAQCAtIChCT09MKWlzT3BhcXVlCiAg IFt3aW4gc2V0VGl0bGU6IG5hbWVdOwogCiAgIC8qIHRvb2xiYXIgc3VwcG9ydCAqLworICBpZiAo IG5zX3VzZV90aXRsZWJhciApIHsKICAgdG9vbGJhciA9IFtbRW1hY3NUb29sYmFyIGFsbG9jXSBp bml0Rm9yVmlldzogc2VsZiB3aXRoSWRlbnRpZmllcjoKICAgICAgICAgICAgICAgICAgICAgICAg ICBbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDogQCJFbWFjcyBGcmFtZSAlZCIsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5zX3dpbmRvd19udW1dXTsKQEAgLTY4MzMsNiAr NjgzNiw3IEBAIFRoaXMgYXZvaWRzIGFuIGV4dHJhIGNsZWFyIGFuZCByZWRyYXcgKGZsaWNrZXIp IGF0IGZyYW1lIGNyZWF0aW9uLiAgKi8KICAgfQogI2VuZGlmCiAgIEZSQU1FX1RPT0xCQVJfSEVJ R0hUIChmKSA9IDA7CisgIH0KIAogICB0ZW0gPSBmLT5pY29uX25hbWU7CiAgIGlmICghTklMUCAo dGVtKSkKQEAgLTg3NTksNiArODc2MywxMiBAQCBOaWwgbWVhbnMgdXNlIGZ1bGxzY3JlZW4gdGhl IG9sZCAoPCAxMC43KSB3YXkuICBUaGUgb2xkIHdheSB3b3JrcyBiZXR0ZXIgd2l0aAogVGhpcyB2 YXJpYWJsZSBpcyBpZ25vcmVkIG9uIE9TWCA8IDEwLjcgYW5kIEdOVXN0ZXAuICAqLyk7CiAgIG5z X3VzZV9zcmdiX2NvbG9yc3BhY2UgPSBZRVM7CiAKKyAgREVGVkFSX0JPT0wgKCJucy11c2UtdGl0 bGViYXIiLCBuc191c2VfdGl0bGViYXIsCisgICAgIGRvYzogLypOb24tbmlsIG1lYW5zIHRvIGlu Y2x1ZGUgYSB0aXRsZWJhciBvbiBmcmFtZXMuICBOaWwgbWVhbnMKK3RvIG9taXQgdGhlIHRpdGxl YmFyIG9uIE9TWCA+PSAxMC43LgorVGhpcyB2YXJpYWJsZSBpcyBpZ25vcmVkIG9uIE9TWCA8IDEw LjcuICBEZWZhdWx0IGlzIHQuICAqLyk7CisgIG5zX3VzZV90aXRsZWJhciA9IFlFUzsKKwogICAv KiBUT0RPOiBtb3ZlIHRvIGNvbW1vbiBjb2RlICovCiAgIERFRlZBUl9MSVNQICgieC10b29sa2l0 LXNjcm9sbC1iYXJzIiwgVnhfdG9vbGtpdF9zY3JvbGxfYmFycywKIAkgICAgICAgZG9jOiAvKiBX aGljaCB0b29sa2l0IHNjcm9sbCBiYXJzIEVtYWNzIHVzZXMsIGlmIGFueS4KLS0gCjIuMTAuMAoK --94eb2c07ce247f1034053dd515d7--