From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Martin via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70299: 30.0.50; go-ts-mode + tree-sitter-go@v0.20.0 no highlighting Date: Tue, 9 Apr 2024 12:55:55 +0100 Message-ID: References: <86y19nw1mh.fsf@gnu.org> <09BC30DC-A05E-4FF9-900F-C510C2AC04CE@gmail.com> Reply-To: Martin Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000006e905c0615a89b74" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9099"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 70299@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 09 13:57:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ruA6E-00028c-3O for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Apr 2024 13:57:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ruA5w-00076n-Rm; Tue, 09 Apr 2024 07:56:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruA5u-00075m-RC for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2024 07:56:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ruA5u-0005t7-Hc for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2024 07:56:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ruA62-0006Fl-7p for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2024 07:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Martin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Apr 2024 11:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70299 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70299-submit@debbugs.gnu.org id=B70299.171266378323987 (code B ref 70299); Tue, 09 Apr 2024 11:57:02 +0000 Original-Received: (at 70299) by debbugs.gnu.org; 9 Apr 2024 11:56:23 +0000 Original-Received: from localhost ([127.0.0.1]:48533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruA5O-0006Eo-Vj for submit@debbugs.gnu.org; Tue, 09 Apr 2024 07:56:23 -0400 Original-Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]:47135) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruA5M-0006Eb-Q6 for 70299@debbugs.gnu.org; Tue, 09 Apr 2024 07:56:22 -0400 Original-Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-5dca1efad59so3902828a12.2 for <70299@debbugs.gnu.org>; Tue, 09 Apr 2024 04:56:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1712663767; x=1713268567; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OybQONTXkliy8LNNb1LT7U/SMVJF73IG8kE2TX9WfvY=; b=Oghlg4D1YRFcKLFWUaRemqYTUnbYjANNQlLMOh1LpsJ4cpXLm1deMVkiwXKJ+dEbjT 1ykVjoFZNNuswI4vnvcjqSEowZ0mp4okXwjpWnIKQMZ3uFpzsy6nUza8RIp2airKsh0L Qk+0afDmCLdFjJ4gVcXbd0svxC9iBIubDbDNDMfNkSHeQg0IpY6cRhbYHdPwQC+UOYJ9 lZICP8T8LxE7FtFVN87Xanpm41ZbLZ/VmyGlLjXaWtxGcisfRoS76Pojwua/WhWUrhts mBqQh72kd/PJqS4P0FNkleA9eA1PsnQocs77cwcaajpumGDbGY8JMyOLq3VypuSrHKUm 5sDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712663767; x=1713268567; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OybQONTXkliy8LNNb1LT7U/SMVJF73IG8kE2TX9WfvY=; b=I62XHJCIxFksBChvkJBOqpaxcwidL5ShzyWgn2w9vQUezv4f7Zl7eeu9i0GhGanHZh PKuNa7u6UwZtO2U2gZSF12NXMS4KQnFQNpvv/YtdHpJz0f2B6kQGuFJurwsaAMDdZHKK chfA9UWuz6JzoXdLMHEKHqjFysjAjgjWpFADgXcpLZJINk5zqVV/QcaMmTnERjSZyfOJ IzgV1hxSclYIuK/WULE47N+1vSm6KJ0nW/dSHKnx76Nswvc8lg08EhaMVIYxGHqIc+iG pwUvRH3DnmQOTnU7yjhtQe+ZR6a5i28jjrzj4PLxNvcYwUs6qMNjqSwcZ0vKc5mNR43Q 42Dw== X-Forwarded-Encrypted: i=1; AJvYcCVRn2x3A3B7+bpfFRu8xH+xmuHaPRn4v9ZVnEaPFwsn1eQOmTFg9J2Ylto0glqIPxg1f7XX9g4wyJzOAyNod5glhDAxJbk= X-Gm-Message-State: AOJu0YymEN4FnCWubAoDk2N1d0afSsP7LBgmPymeiFA1tA8EdSGaoEcJ 0asfjPZMHA8vMPRK6H9R4RTBWXmS1fHuqxzI6grjRZcj57U/M5YpUOE6NpqzDXpsSU2afQdsQZ3 zqAeX6yAKZdbLH7Qz972uIzspFR8= X-Google-Smtp-Source: AGHT+IGj99Y22R0zfl1LxEpe/6IzScGT7Y3lZiXAWJrF/GExWjLysLj8I8cmzTPgLMaUgCfGR/gBpQi0CuaKiIYLVb4= X-Received: by 2002:a05:6a20:430c:b0:1a7:a72c:6f4 with SMTP id h12-20020a056a20430c00b001a7a72c06f4mr1830643pzk.41.1712663766664; Tue, 09 Apr 2024 04:56:06 -0700 (PDT) In-Reply-To: <09BC30DC-A05E-4FF9-900F-C510C2AC04CE@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282988 Archived-At: --0000000000006e905c0615a89b74 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I tried manually applying that patch to my local emacs - it didn't seem to fix the issue of no syntax highlighting? On Tue, Apr 9, 2024 at 6:47=E2=80=AFAM Yuan Fu wrote: > > > > On Apr 8, 2024, at 10:23 PM, Eli Zaretskii wrote: > > > >> Date: Tue, 9 Apr 2024 00:43:57 +0100 > >> From: Martin via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> - emacs -Q; > >> - M-x treesit-install-language-grammar > >> - go > >> - github.com/tree-sitter/tree-sitter-go > >> > >> - Open up a new buffer and use go-ts-mode > >> - Write some go-code > >> ``` > >> package my_pkg > >> type myStruct struct {} > >> func MyFunc(x context.Context) error {} > >> ``` > >> - Observe that there is no syntax highlighting > >> - Observe that treesit-explore-mode seems to work properly > >> - Conclude that there is something wrong with go-ts-mode's > >> highlighting. There is highlighting with tree-sitter-go v0.19.1, but > >> that grammar also seems to come with some bugs. > > > > Isn't this a duplicate of bug#70296? > > Yeah, Martin contacted me on Reddit because he didn=E2=80=99t know how to= report > this issue, and I told him he can use M-x bug-report-emacs, which he did. > Thanks Martin! > > Meanwhile I wrote a patch and sent it in bug#70296. Let me merge these tw= o > reports. > > Yuan --0000000000006e905c0615a89b74 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I tried manually applying=C2=A0that patch to my local emac= s - it didn't seem to fix the issue of no syntax highlighting?
On Tue, A= pr 9, 2024 at 6:47=E2=80=AFAM Yuan Fu <casouri@gmail.com> wrote:


> On Apr 8, 2024, at 10:23 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> Date: Tue, 9 Apr 2024 00:43:57 +0100
>> From:=C2=A0 Martin via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> - emacs -Q;
>> - M-x treesit-install-language-grammar
>>=C2=A0 - go
>>=C2=A0 - github.com/tree-sitter/tree-sitter-go
>>
>> - Open up a new buffer and use go-ts-mode
>> - Write some go-code
>> ```
>> package my_pkg
>> type myStruct struct {}
>> func MyFunc(x context.Context) error {}
>> ```
>> - Observe that there is no syntax highlighting
>> - Observe that treesit-explore-mode seems to work properly
>> - Conclude that there is something wrong with go-ts-mode's
>>=C2=A0 highlighting. There is highlighting with tree-sitter-go v0.1= 9.1, but
>>=C2=A0 that grammar also seems to come with some bugs.
>
> Isn't this a duplicate of bug#70296?

Yeah, Martin contacted me on Reddit because he didn=E2=80=99t know how to r= eport this issue, and I told him he can use M-x bug-report-emacs, which he = did. Thanks Martin!

Meanwhile I wrote a patch and sent it in bug#70296. Let me merge these two = reports.

Yuan
--0000000000006e905c0615a89b74--