From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.devel Subject: [PATCH] What's the quickest way to contribute? Date: Thu, 8 Jan 2015 18:59:09 +0100 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11c14f4affbc2f050c27cb89 X-Trace: ger.gmane.org 1420742645 2588 80.91.229.3 (8 Jan 2015 18:44:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 8 Jan 2015 18:44:05 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 08 19:44:02 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y9I3X-0007AU-CJ for ged-emacs-devel@m.gmane.org; Thu, 08 Jan 2015 19:43:39 +0100 Original-Received: from localhost ([::1]:47754 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9I3W-0003oY-MY for ged-emacs-devel@m.gmane.org; Thu, 08 Jan 2015 13:43:38 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9HMV-0005TC-RY for emacs-devel@gnu.org; Thu, 08 Jan 2015 12:59:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y9HMU-00087w-Cr for emacs-devel@gnu.org; Thu, 08 Jan 2015 12:59:11 -0500 Original-Received: from mail-qc0-x232.google.com ([2607:f8b0:400d:c01::232]:47702) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9HMU-00087l-8i for emacs-devel@gnu.org; Thu, 08 Jan 2015 12:59:10 -0500 Original-Received: by mail-qc0-f178.google.com with SMTP id p6so3459852qcv.9 for ; Thu, 08 Jan 2015 09:59:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=fqywbc29W38E7K2Ct5JMTHosMh2sVlDnBuhtV6wczFw=; b=wvTUoemUiuGPv0MBnYIlwDE5gDzwq6A1Rmp+tIUEGuyHqGtKojX8phJgTxSvUizHHA 3bEESVCHQnhYQZCcagduR+lJu7I3LMrUdCLrvf+vb/t+EjcVfSARYTkhho1y6zEE93+S St/FYPzUPg34Y40ly6CAyYAsOw1Hb9WPqLnkJnDC5EnBBmAMl4orsi0TugeRZ+pMRkja o1XOyeNXk5QwrAsCpyAOaG2cxo9XiBbRoEyCecwa5SwvVuup8Q5XYbr1kMiakfC8rLm1 DvZJ8dJFTNYfvQRUrYjDqSFDnkYNVElQ59xjJcF+6YICNx6uXG64nHtJKwWNSknQzKSa waqA== X-Received: by 10.140.40.70 with SMTP id w64mr17265826qgw.32.1420739949338; Thu, 08 Jan 2015 09:59:09 -0800 (PST) Original-Received: by 10.140.18.132 with HTTP; Thu, 8 Jan 2015 09:59:09 -0800 (PST) X-Google-Sender-Auth: SehRKVmiAyLruI80Y9-6eYifW44 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c01::232 X-Mailman-Approved-At: Thu, 08 Jan 2015 13:43:36 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:181073 Archived-At: --001a11c14f4affbc2f050c27cb89 Content-Type: text/plain; charset=UTF-8 Hi all, I like Emacs a lot and I'd like to contribute to the development. I have assigned the FSF Copyright and made some small contributions in the past, but so far my contributions have been moving slower than molasses. For instance, this one-liner, http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19493, has been hanging there for a few days now. The other one, https://debbugs.gnu.org/cgi/bugreport.cgi?bug=15920, is more than a year old. This one, https://debbugs.gnu.org/cgi/bugreport.cgi?bug=19460, Stefan himself asked me to report, and yet there's no answer so far. A few questions/ possible answers follow on why this is: 1. My patches / bug reports are lame. Then I'd appreciate at least some feedback pointing out the faults. I learn quickly. 2. I'm submitting to the wrong place, e.g. to the bug tracker instead of the devel list or vice versa. I'd like to know the proper and approved way to do this. 3. My patches / bug reports are low priority and are not worth applying / responding to. Then please let me know the priority areas in which contributions are more actively accepted. 4. The devs are swamped with bug reports and I should just wait a few months more until my turn. Well, I could help out in that area, since my intention is to start from small contributions into larger ones until I get experienced enough to get push access and get my work merged without a lengthy review. I could then help with the review of other people's one-liners. I've read http://lars.ingebrigtsen.no/2014/11/13/welcome-new-emacs-developers/ and http://www.emacswiki.org/emacs/GitForEmacsDevs, but I didn't find the answers to the questions that I'm posting here. Finally, I attach one more patch that I'd like some feedback on. I was browsing replace.el and found this type of code: (delq nil (mapcar #'(lambda (buf) (when (buffer-live-p buf) buf)) bufs)) instead of this: (cl-remove-if-not #'buffer-live-p bufs) If this were my package, I would change it without batting an eye, since the latter code is more clear and algorithmically faster. However, maybe my knowledge of Emacs's internals is lacking and the current way is better. Or maybe there's a policy against `cl-` functions. Or maybe there's a policy of not fixing things that aren't broke. I'd like to know these things. regards, Oleh --001a11c14f4affbc2f050c27cb89 Content-Type: text/x-patch; charset=US-ASCII; name="0001-lisp-replace.el-occur-1-Use-cl-seq.patch" Content-Disposition: attachment; filename="0001-lisp-replace.el-occur-1-Use-cl-seq.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i4ofhk640 RnJvbSAxZGE3ZDZmYjg4MDgzNDc3MmFkMTdhZWQ0Njg3MmQ0OTY0MWUxZjZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBPbGVoIEtyZWhlbCA8b2h3b2Vvd2hvQGdtYWlsLmNvbT4KRGF0 ZTogVGh1LCA4IEphbiAyMDE1IDE3OjQwOjU5ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gbGlzcC9y ZXBsYWNlLmVsIChvY2N1ci0xKTogVXNlIGBjbC1zZXEnLgoKKiBsaXNwL3JlcGxhY2UuZWwgKG9j Y3VyLTEpOiBVc2UgYGNsLXJlbW92ZS1pZi1ub3QnIGFuZCBgY2wtZmluZC1pZicKICBpbiBmYXZv ciBvZiBtb3JlIGNvbXBsZXggb3BlcmF0aW9ucy4KLS0tCiBsaXNwL3JlcGxhY2UuZWwgfCAxMSAr KysrKystLS0tLQogMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9saXNwL3JlcGxhY2UuZWwgYi9saXNwL3JlcGxhY2UuZWwKaW5kZXgg ZTA2MzZlMC4uYjkyZTNjZCAxMDA2NDQKLS0tIGEvbGlzcC9yZXBsYWNlLmVsCisrKyBiL2xpc3Av cmVwbGFjZS5lbApAQCAtMTQxNiwxNCArMTQxNiwxNSBAQCBTZWUgYWxzbyBgbXVsdGktb2NjdXIn LiIKICAgKHVubGVzcyBidWYtbmFtZQogICAgIChzZXRxIGJ1Zi1uYW1lICIqT2NjdXIqIikpCiAg IChsZXQgKG9jY3VyLWJ1ZgotCShhY3RpdmUtYnVmcyAoZGVscSBuaWwgKG1hcGNhciAjJyhsYW1i ZGEgKGJ1ZikKLQkJCQkJICAgKHdoZW4gKGJ1ZmZlci1saXZlLXAgYnVmKSBidWYpKQotCQkJCSAg ICAgICBidWZzKSkpKQorCShhY3RpdmUtYnVmcworICAgICAgICAgKGNsLXJlbW92ZS1pZi1ub3Qg IydidWZmZXItbGl2ZS1wIGJ1ZnMpKSkKICAgICA7OyBIYW5kbGUgdGhlIGNhc2Ugd2hlcmUgb25l IG9mIHRoZSBidWZmZXJzIHdlJ3JlIHNlYXJjaGluZyBpcyB0aGUKICAgICA7OyBvdXRwdXQgYnVm ZmVyLiAgSnVzdCByZW5hbWUgaXQuCi0gICAgKHdoZW4gKG1lbWJlciBidWYtbmFtZSAobWFwY2Fy ICdidWZmZXItbmFtZSBhY3RpdmUtYnVmcykpCisgICAgKHdoZW4gKGNsLWZpbmQtaWYKKyAgICAg ICAgICAgYChsYW1iZGEgKGJ1ZikgKGVxdWFsIChidWZmZXItbmFtZSBidWYpICxidWYtbmFtZSkp CisgICAgICAgICAgIGFjdGl2ZS1idWZzKQogICAgICAgKHdpdGgtY3VycmVudC1idWZmZXIgKGdl dC1idWZmZXIgYnVmLW5hbWUpCi0JKHJlbmFtZS11bmlxdWVseSkpKQorICAgICAgICAocmVuYW1l LXVuaXF1ZWx5KSkpCiAKICAgICA7OyBOb3cgZmluZCBvciBjcmVhdGUgdGhlIG91dHB1dCBidWZm ZXIuCiAgICAgOzsgSWYgd2UganVzdCByZW5hbWVkIHRoYXQgYnVmZmVyLCB3ZSB3aWxsIG1ha2Ug YSBuZXcgb25lIGhlcmUuCi0tIAoxLjguNAoK --001a11c14f4affbc2f050c27cb89--