From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Darren Hoo Newsgroups: gmane.emacs.devel Subject: Re: Input for TTY menus Date: Sun, 20 Oct 2013 02:58:53 +0800 Message-ID: References: <831u4llymo.fsf@gnu.org> <83r4bjoq33.fsf@gnu.org> <83bo2nnkel.fsf@gnu.org> <837gdbndpy.fsf@gnu.org> <83y55qn1dz.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c38c826d15a204e91ca4b2 X-Trace: ger.gmane.org 1382209139 32730 80.91.229.3 (19 Oct 2013 18:58:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Oct 2013 18:58:59 +0000 (UTC) Cc: emacs-devel To: Eli Zaretskii , =?ISO-8859-1?Q?Jan_Dj=E4rv?= , yandros@mit.edu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 19 20:59:02 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VXbjp-0002J6-54 for ged-emacs-devel@m.gmane.org; Sat, 19 Oct 2013 20:59:01 +0200 Original-Received: from localhost ([::1]:34103 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VXbjo-000136-S1 for ged-emacs-devel@m.gmane.org; Sat, 19 Oct 2013 14:59:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VXbjl-00012z-LH for emacs-devel@gnu.org; Sat, 19 Oct 2013 14:58:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VXbjk-0004ga-Gv for emacs-devel@gnu.org; Sat, 19 Oct 2013 14:58:57 -0400 Original-Received: from mail-we0-x229.google.com ([2a00:1450:400c:c03::229]:55274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VXbji-0004e0-RE; Sat, 19 Oct 2013 14:58:55 -0400 Original-Received: by mail-we0-f169.google.com with SMTP id q58so5101651wes.0 for ; Sat, 19 Oct 2013 11:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=GeVdI6NyVAMr3vJCQWuv7ltzKG1eHyHD34xdOjQAWgI=; b=PgJ7IGfL3rkieEL8fLvNc6culj4Y9/07V0K2tgNdaRxUEYjvjOdXW6EDQx9c0zlayt PhpyEMTpbfBWgt6u3BRM5g3Mc7sSvZszsfy3/BK3fTniUrqYn3BT+iH4wb13J8x/FiKh r5/POyFz6/onlNBFGfWdnA18tzQk77Lr3yevwaCM/iJVZ+P7uD7xrq/93S1IXtDjqyxh PBSkGBISj+38qtdPNvYQ7MfRvZYEx5BDHEFC0Yvei/rWBG4XAhcKyYufaxZvmtz1Tloq EZ08xnvGUXaxgr4gIvipSsna/t5D4JgTKZihKSYHwcTZk5EPQh4cHnfuFSdRUxc4Yw+6 HqzQ== X-Received: by 10.180.187.2 with SMTP id fo2mr3744475wic.65.1382209133809; Sat, 19 Oct 2013 11:58:53 -0700 (PDT) Original-Received: by 10.194.6.162 with HTTP; Sat, 19 Oct 2013 11:58:53 -0700 (PDT) In-Reply-To: <83y55qn1dz.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:164374 Archived-At: --001a11c38c826d15a204e91ca4b2 Content-Type: text/plain; charset=ISO-8859-1 On Fri, Oct 18, 2013 at 9:40 PM, Eli Zaretskii wrote: > What about my questions about the "Services" menu? I don't think you > answered those. Thanks chad for explaining what services menu for me. Jan, your 114716 commit totally removes the services menu. But I think some GUI users may use it, I sometimes use it while not quite often. How about bring it back? I have tested the following patch on OSX, While I tried Emacs on GNUStep it crashes , but I don't think the crash is related to this. I am curious that how many users use Emacs on GNUStep nowadays? === modified file 'lisp/menu-bar.el' --- lisp/menu-bar.el 2013-10-19 08:35:51 +0000 +++ lisp/menu-bar.el 2013-10-19 18:14:38 +0000 @@ -45,16 +45,24 @@ ;; The symbol used to be called `help', but that gets confused with the ;; help key. (setq menu-bar-final-items '(help-menu)) - (if (eq system-type 'darwin) - (setq menu-bar-final-items '(buffer services help-menu)) - (setq menu-bar-final-items '(buffer services hide-app quit)) - ;; Add standard top-level items to GNUstep menu. - (bindings--define-key global-map [menu-bar quit] - '(menu-item "Quit" save-buffers-kill-emacs - :help "Save unsaved buffers, then exit")) - (bindings--define-key global-map [menu-bar hide-app] - '(menu-item "Hide" ns-do-hide-emacs - :help "Hide Emacs")))) + (if (eq window-system nil) + ;; No services menu in text-mode. + (if (eq system-type 'darwin) + (setq menu-bar-final-items '(buffer help-menu)) + (setq menu-bar-final-items '(buffer hide-app quit))) + ;; We still want to use service menu in GUI. + (if (eq system-type 'darwin) + (setq menu-bar-final-items '(buffer services help-menu)) + (setq menu-bar-final-items '(buffer services hide-app quit)) + ;; Add standard top-level items to GNUstep menu. + (bindings--define-key global-map [menu-bar quit] + '(menu-item "Quit" save-buffers-kill-emacs + :help "Save unsaved buffers, then exit")) + (bindings--define-key global-map [menu-bar hide-app] + '(menu-item "Hide" ns-do-hide-emacs + :help "Hide Emacs"))) + (bindings--define-key global-map [menu-bar services] ; Set-up in ns-win. + (cons "Services" (make-sparse-keymap "Services"))))) ;; This definition is just to show what this looks like. ;; It gets modified in place when menu-bar-update-buffers is called. --001a11c38c826d15a204e91ca4b2 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Fri, Oct 18, 2013 at 9:40 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> What about= my questions about the "Services" menu? =A0I don't think you=
> answered those.

Thanks chad for explaining what =A0services men= u for me.

Jan,

your =A0114716 commit totally removes the= services menu.=A0But I think some GUI=A0
users may use it, I sometimes= use it while not quite often.

How about bring it back? I have tested the following patch o= n OSX,=A0
While I tried Emacs on GNUStep it crashes , but I don&#= 39;t think the crash is=A0
related to this.

<= div> I am curious that how many users use Emacs on GNUStep nowadays?
<= br>

=3D=3D=3D modif= ied file 'lisp/menu-bar.el'

--- lisp/menu-bar.= el 2013-10-19 08:35:51 +0= 000

+++ lisp/menu-bar.= el 2013-10-19 18:14:38 +0= 000

@@ -45,16 +45,24 @= @

=A0=A0 =A0 ;; The = symbol used to be called `help', but that gets confused with the

=A0=A0 =A0 ;; help= key.

=A0=A0 =A0 (setq m= enu-bar-final-items '(help-menu))

-=A0 (if (eq syste= m-type 'darwin)

-=A0 =A0 =A0 (setq= menu-bar-final-items '(buffer services help-menu))

-=A0 =A0 (setq men= u-bar-final-items '(buffer services hide-app quit))

-=A0 =A0 ;; Add st= andard top-level items to GNUstep menu.

-=A0 =A0 (bindings= --define-key global-map [menu-bar quit]

-=A0 =A0 =A0 '= (menu-item "Quit" save-buffers-kill-emacs

- =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 :help "Save unsaved buffers, then exit"))

-=A0 =A0 (bindings= --define-key global-map [menu-bar hide-app]

-=A0 =A0 =A0 '= (menu-item "Hide" ns-do-hide-emacs

-=A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 :help "Hide Emacs"))))

+=A0 (if (eq windo= w-system nil)

+=A0 =A0 =A0 ;; No= services menu in text-mode.

+=A0 =A0 =A0 (if (= eq system-type 'darwin)

+ =A0 (setq menu-bar-final-items '(buff= er help-menu))

+ (setq menu-bar-final-items '(buffer h= ide-app quit)))

+=A0 =A0 ;; We sti= ll want to use service menu in GUI.

+=A0 =A0 (if (eq s= ystem-type 'darwin)

+ (setq menu-bar-final-items '(buffer s= ervices help-menu))

+=A0 =A0 =A0 (setq= menu-bar-final-items '(buffer services hide-app quit))

+=A0 =A0 =A0 ;; Ad= d standard top-level items to GNUstep menu.

+=A0 =A0 =A0 (bind= ings--define-key global-map [menu-bar quit]

+ '(menu-item "Quit" save-buf= fers-kill-emacs

+ =A0 =A0 :help "Save unsaved buffers= , then exit"))

+=A0 =A0 =A0 (bind= ings--define-key global-map [menu-bar hide-app]

+ '(menu-item "Hide" ns-do-hi= de-emacs

+ =A0 =A0 :help "Hide Emacs")))<= /p>

+=A0 =A0 (bindings= --define-key global-map [menu-bar services] ; Set-up in ns-win.

+=A0 =A0 =A0 (cons= "Services" (make-sparse-keymap "Services")))))

= =A0

=A0;; This definit= ion is just to show what this looks like.

=A0;; It gets modi= fied in place when menu-bar-update-buffers is called.


--001a11c38c826d15a204e91ca4b2--