From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#32932: 27.0.50; render bugs on macOS Mojave Date: Wed, 31 Oct 2018 23:51:42 -0700 Message-ID: References: <20181019184828.GA2041@breton.holly.idiocy.org> <20181020200444.GA2501@breton.holly.idiocy.org> <20181024104242.GA40431@breton.holly.idiocy.org> <20181029160943.GA60662@breton.holly.idiocy.org> <20181031171253.GA69712@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1541055010 31614 195.159.176.226 (1 Nov 2018 06:50:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 1 Nov 2018 06:50:10 +0000 (UTC) Cc: Alan Third , 32932@debbugs.gnu.org To: Boris Buliga Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 01 07:50:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gI6nt-000863-BV for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Nov 2018 07:50:05 +0100 Original-Received: from localhost ([::1]:35705 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gI6pz-0000zF-FQ for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Nov 2018 02:52:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gI6pt-0000zA-H6 for bug-gnu-emacs@gnu.org; Thu, 01 Nov 2018 02:52:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gI6pn-00037C-Ng for bug-gnu-emacs@gnu.org; Thu, 01 Nov 2018 02:52:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53437) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gI6pm-00036D-4M for bug-gnu-emacs@gnu.org; Thu, 01 Nov 2018 02:52:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gI6pl-0008G1-MV for bug-gnu-emacs@gnu.org; Thu, 01 Nov 2018 02:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Nov 2018 06:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32932 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32932-submit@debbugs.gnu.org id=B32932.154105511231721 (code B ref 32932); Thu, 01 Nov 2018 06:52:01 +0000 Original-Received: (at 32932) by debbugs.gnu.org; 1 Nov 2018 06:51:52 +0000 Original-Received: from localhost ([127.0.0.1]:57695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gI6pc-0008FZ-0p for submit@debbugs.gnu.org; Thu, 01 Nov 2018 02:51:52 -0400 Original-Received: from mail-yb1-f181.google.com ([209.85.219.181]:45371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gI6pZ-0008FI-U1 for 32932@debbugs.gnu.org; Thu, 01 Nov 2018 02:51:50 -0400 Original-Received: by mail-yb1-f181.google.com with SMTP id 131-v6so7697699ybe.12 for <32932@debbugs.gnu.org>; Wed, 31 Oct 2018 23:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc:content-transfer-encoding; bh=GF2HcvuD7Y6NhZRF4spBbl3NmxZ/VI6qLD/v2aofXPI=; b=oMZraurKOYsPnk/MbtwV7jlX7tssunQAbxiJVwgOMjqc/FrlqYgcbVCBJCm2hdElP3 awF86yGfcrxktpJg3sRdQIKXwozJLXMfncanebB3QZqkMfP60pJQ4FyOMRcH92Ts5CSD 9nRcxG7bbgdQJtsiLIus5KgdAw/WngAbWRtLw9LgFoQisE1bAm1oJeDk4uJC4A0e52EJ ZLpO8w6ARjGFkBHheaI+1HCW1LtiD6aH2p5LJE4yoUEMiEF+7EujYgAYUNxrn4J+JNqS QukkLR1UrZoiCBTsC4E08VO0TRH9V5zN86HJmaYCT/otVH666g/qlJ+w92hwGq1bHBRR cReA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=GF2HcvuD7Y6NhZRF4spBbl3NmxZ/VI6qLD/v2aofXPI=; b=pSMa/9RfANq2TqN10gBAPdLj+cs5DErhMXOPs8q1jQFLdxrC397bwlxmLIUVJAtLJY XK2i0/KF2hTefvMzZUJVcQKLov5kreaLCyR+WcxGeFsJbw9YJlYolfGw2rFy5QsXpMvp jXac7hzt8YzJRTUkZKkzOn6J/5qshHN+Zh487u0xjcWgxruypWezk12Rb/2E2rFzBDyZ 0Bm3C0skyT95gANOGeni0jlujr2J01ShRR1VByc25cW24JO4p8uaW55cXOd8JIsWNQkE B3HFqCdSR2vrPDyp4lT5yOKSlYRpjNMZ3GkSSCqWukhru4m4nLzML5HGXHSz37d1fsxF G8Cg== X-Gm-Message-State: AGRZ1gIZP4s1qb1vyI9AdUzaQy1dvLTxccOpWXyo/UFt5TbXdT20Liki DqnWgiuWTmGKRBV7slwslxhMf8NiBmN6Tt6rHINVaUT0 X-Google-Smtp-Source: AJdET5fIIAdzOSpP0m9pm5s3n6ME3lqgPGXNsGx6L7Eq4aVdyUT6TAYiwHg+7is8zqYXDtg07zrnEYxBPV/DRLmaROs= X-Received: by 2002:a25:bb88:: with SMTP id y8-v6mr6332910ybg.283.1541055104272; Wed, 31 Oct 2018 23:51:44 -0700 (PDT) Original-Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Wed, 31 Oct 2018 23:51:42 -0700 In-Reply-To: X-Mailer: Airmail (528) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151885 Archived-At: On October 31, 2018 at 11:13:53 PM, Boris Buliga (boris@d12frosted.io(mailto:boris@d12frosted.io)) wrote: > Yes, I've also noticed blanks with ivy. > > But for sure this patch is a HUGE improvement. I had to work a little bit= on a > machine where I didn't install this patch and I have encountered a lot of= random > blanks. > > > -------------------------------------------------------------------------= ------- > > Aaron, > > I will hopefully be able to test with the following line commented out. > > w->phys_cursor_on_p =3D on_p; Just commenting that out will cause the cursor to ghost, but it fixes the problem for me otherwise. Tracing further, it seems that that getting set causes erase_phys_cursor to get called, which ultimately calls draw_phys_cursor_glyph, which calls draw_glyphs, which I believe is what is blanking the line. It appears to be more than just redrawing the glyph under the cursor. Another clue is that it appear to only blank from where the cursor is to the end of the line. Anything before that isn=E2=80=99t cleared. I=E2=80=99m sure I=E2=80=99m at the end of my depth here w/o diving a lot d= eeper. Hopefully this flurry of emails points you in the right direction, Alan. Thanks! Aaron