all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Aaron Jensen <aaronjensen@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Alan Third <alan@idiocy.org>,
	YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>,
	emacs-devel@gnu.org
Subject: Re: macOS metal rendering engine in mac port
Date: Tue, 25 May 2021 08:35:42 -0700	[thread overview]
Message-ID: <CAHyO48zYedpt+ZyMsSbkwr155tn3hbmR=L3KtSn8e-A9wef_vw@mail.gmail.com> (raw)
In-Reply-To: <83bl8zc8ku.fsf@gnu.org>

On Tue, May 25, 2021 at 5:16 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: Aaron Jensen <aaronjensen@gmail.com>
> > Date: Mon, 24 May 2021 23:26:37 -0700
> > Cc: emacs-devel@gnu.org, Alan Third <alan@idiocy.org>,
> >       YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
> >
> > > > Alan, I could understand why drawing glyphs would take longer (there's
> > > > more to draw when there are line numbers),
> > >
> > > ??? Because line numbers add ~3 glyphs to each line?  How can this explain any significant slowdown?  Do you see something similar if you add 3 characters to every line and benchmark the scroll?
> >
> > I added 3 characters to the end of every line of xdisp.c (//1) and it
> > went from 7.2s to 8.4s -- 17% (emacs -Q, no line numbers).
>
> The 17% is about twice what I'd expect, since adding 3 characters to
> each line of xdisp.c enlarges its text by only 9.3%.

Pure guess here, but it's also making a lot of empty lines non-empty
(14% more). Perhaps that has an added cost somehow?

> > The timing differences are primarily in display_line. gui_write_glyphs
> > is 15% slower, which is nowhere near 576ms. Profile attached.
> >
> > That certainly doesn't match the 78% slower for drawing glyphs in the
> > line number scenario.
> >
> > Any suggestions on what to try next?
>
> The numbers are so against my intuition that I'm not even sure in
> which direction to think...
>
> How did you compile Emacs? which compiler and what compiler and linker
> switches?  And what kind of CPU do you have there?  I'm looking for
> something that could explain why parts of code that should take like
> 20% of the total redisplay time are so dominant in your case.

clang, with -O2. Specifically these configure flags:

CFLAGS="-g3 -O2" \
--disable-silent-rules \
--with-xml2 \
--with-gnutls \
--without-dbus \
--with-imagemagick \
--with-modules \
--with-rsvg \
--with-ns \
--disable-ns-self-contained


This CPU: Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz

>
> Alan, do you see similar numbers (in percents) to what Aaron reports?
> Or is that something peculiar to his system?

What I get depends on frame size and whether or not I'm using
nativecomp or Alan's branch or master. I just a test with a smaller
frame size (on Alan's branch this time, just happens to be what I have
built) and saw 5.58 vs 6.8s: 22%. But then I ran the bench again w/
line numbers and couldn't get it below 7.2s, so there's quite a bit of
variability in the test runs.

Alan, I haven't forgotten about your question about latency and that
additional patch. I'm using that patch now and will work with it
through the day.



  parent reply	other threads:[~2021-05-25 15:35 UTC|newest]

Thread overview: 155+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21  1:17 macOS metal rendering engine in mac port Aaron Jensen
2021-05-21  6:07 ` Eli Zaretskii
2021-05-21  6:13   ` Aaron Jensen
2021-05-21  7:35 ` Alan Third
2021-05-21 15:27   ` Aaron Jensen
2021-05-21 17:39     ` Alan Third
     [not found]       ` <CAHyO48ys2sYxbZuho1NutqNAM-z0tTaKwuR1TxUuhMZG5XJ0aA@mail.gmail.com>
2021-05-22 16:01         ` Aaron Jensen
2021-05-22 16:30           ` Eli Zaretskii
2021-05-22 16:46             ` Eli Zaretskii
2021-05-22 17:00               ` Eli Zaretskii
2021-05-22 18:44         ` Alan Third
2021-05-22 18:59           ` Aaron Jensen
2021-05-22 19:57             ` Alan Third
2021-05-22 21:20               ` Aaron Jensen
2021-05-23 11:47                 ` Alan Third
2021-05-23 16:09                   ` Stefan Monnier
2021-05-23 16:13                   ` Aaron Jensen
2021-05-23 17:06                     ` Aaron Jensen
2021-05-23 17:21                       ` Eli Zaretskii
2021-05-23 18:38                         ` Aaron Jensen
2021-05-23 18:48                           ` Eli Zaretskii
2021-05-23 19:49                             ` Aaron Jensen
2021-05-24  0:00                           ` Aaron Jensen
2021-05-24  0:04                             ` Aaron Jensen
     [not found]                               ` <CAHyO48z1m5aeqwqmZds3yuYiJ=rdHZ79JPVyuh1kHVU0Rw47EA@mail.gmail.com>
2021-05-24  6:51                                 ` Aaron Jensen
2021-05-24  7:37                                   ` Eli Zaretskii
2021-05-24  8:07                                     ` Aaron Jensen
2021-05-24  8:48                                       ` Eli Zaretskii
2021-05-24 15:32                                         ` Aaron Jensen
2021-05-24 16:28                                           ` Eli Zaretskii
2021-05-24 16:31                                             ` Aaron Jensen
2021-05-24 16:43                                               ` Eli Zaretskii
2021-05-24 17:58                                                 ` Aaron Jensen
2021-05-24 18:03                                                   ` Eli Zaretskii
2021-05-24 18:16                                                     ` Alan Third
2021-05-24 18:18                                                     ` Aaron Jensen
2021-05-24 18:54                                                       ` Eli Zaretskii
2021-05-24 19:07                                                         ` Aaron Jensen
2021-05-24 19:21                                                           ` Eli Zaretskii
2021-05-24 19:27                                                             ` Eli Zaretskii
2021-05-24 20:21                                                               ` Aaron Jensen
2021-05-25  2:31                                                                 ` Eli Zaretskii
     [not found]                                                                   ` <CAHyO48yxxdURvZSzrWn-F+6wKwHgpwcoXD7_w0NmWLcfBKkUkw@mail.gmail.com>
2021-05-25  5:41                                                                     ` Eli Zaretskii
2021-05-25  6:26                                                                       ` Aaron Jensen
2021-05-25 12:16                                                                         ` Eli Zaretskii
2021-05-25 12:23                                                                           ` Alan Third
2021-05-25 12:56                                                                           ` Alan Third
2021-05-25 13:00                                                                             ` Eli Zaretskii
2021-05-25 13:07                                                                               ` Alan Third
2021-05-25 13:18                                                                                 ` Eli Zaretskii
2021-05-25 13:34                                                                                   ` Alan Third
2021-05-25 13:47                                                                                     ` Eli Zaretskii
2021-05-25 13:50                                                                                       ` Alan Third
2021-05-27 16:55                                                                             ` Eli Zaretskii
2021-05-27 17:40                                                                               ` Alan Third
2021-05-27 17:47                                                                                 ` Eli Zaretskii
2021-05-27 17:51                                                                                   ` Alan Third
2021-05-27 17:53                                                                                     ` Aaron Jensen
2021-05-27 18:59                                                                                       ` Eli Zaretskii
2021-05-27 19:02                                                                                         ` Aaron Jensen
2021-05-27 19:22                                                                                           ` Eli Zaretskii
2021-05-27 19:37                                                                                             ` Aaron Jensen
2021-05-28 17:58                                                                                               ` Eli Zaretskii
2021-05-28 18:21                                                                                                 ` Aaron Jensen
2021-05-28 19:00                                                                                                   ` Eli Zaretskii
2021-05-25 15:35                                                                           ` Aaron Jensen [this message]
2021-05-25 17:34                                                                             ` Eli Zaretskii
2021-05-25 17:48                                                                               ` Aaron Jensen
2021-05-25  9:01                                                                     ` Alan Third
2021-05-24 12:47                                 ` Eli Zaretskii
2021-05-24 16:10                                   ` Aaron Jensen
2021-05-23 21:20                       ` Alan Third
2021-05-23 22:04                         ` Alan Third
2021-05-23 22:12                           ` Alan Third
2021-05-23 21:08                     ` Alan Third
2021-05-23 22:37                       ` Aaron Jensen
2021-05-24  9:01                         ` Alan Third
2021-05-25 16:31                           ` Aaron Jensen
2021-05-26  0:32                             ` Aaron Jensen
2021-05-26  6:23                               ` Alan Third
2021-05-26  6:26                                 ` Aaron Jensen
2021-05-26  7:35                                   ` Aaron Jensen
2021-05-28 17:39                                 ` Aaron Jensen
2021-05-28 18:32                                   ` Alan Third
2021-05-28 19:00                                     ` Aaron Jensen
2021-05-28 19:29                                       ` Alan Third
2021-05-28 22:07                                         ` Aaron Jensen
2021-05-29  6:07                                           ` Eli Zaretskii
2021-05-29  7:01                                             ` Aaron Jensen
2021-05-29  7:05                                               ` Eli Zaretskii
2021-05-29  8:52                                                 ` Aaron Jensen
2021-05-29  9:06                                                   ` Aaron Jensen
2021-05-29  9:21                                                     ` Eli Zaretskii
2021-05-29  9:35                                                       ` Alan Third
2021-05-29  9:41                                                         ` Eli Zaretskii
2021-05-29 16:18                                                         ` Aaron Jensen
2021-05-29 16:49                                                           ` Eli Zaretskii
2021-05-29 17:05                                                             ` Aaron Jensen
2021-05-29 17:20                                                               ` Aaron Jensen
2021-05-29 17:43                                                                 ` Eli Zaretskii
2021-05-29 18:00                                                                   ` Dmitry Gutov
2021-05-29 18:15                                                                     ` Eli Zaretskii
2021-05-29 18:52                                                                       ` Dmitry Gutov
2021-05-29 19:06                                                                       ` Stefan Monnier
2021-05-29 19:10                                                                         ` Eli Zaretskii
2021-05-29 17:34                                                               ` Eli Zaretskii
2021-05-29 18:22                                                                 ` Aaron Jensen
2021-05-29 18:27                                                                   ` Aaron Jensen
2021-05-29 18:40                                                                   ` Eli Zaretskii
2021-05-29 19:30                                                                     ` Aaron Jensen
2021-05-29 20:03                                                                       ` Eli Zaretskii
2021-05-29 21:03                                                                         ` Aaron Jensen
2021-05-29 21:05                                                                           ` Aaron Jensen
2021-05-29 21:40                                                                             ` Aaron Jensen
2021-05-30  4:44                                                                               ` Aaron Jensen
2021-05-30  7:01                                                                                 ` Eli Zaretskii
2021-05-30  6:27                                                                               ` Eli Zaretskii
2021-05-30  7:04                                                                                 ` Aaron Jensen
2021-05-30  9:36                                                                                   ` Eli Zaretskii
2021-05-30 15:46                                                                                     ` Aaron Jensen
2021-05-30 16:03                                                                                       ` Eli Zaretskii
2021-05-30 16:16                                                                                         ` Aaron Jensen
2021-05-30 16:35                                                                                           ` Eli Zaretskii
2021-05-30 17:00                                                                                             ` Aaron Jensen
2021-05-30 17:18                                                                                               ` Eli Zaretskii
2021-05-30 23:59                                                                                                 ` Aaron Jensen
2021-05-31  2:28                                                                                                   ` Eli Zaretskii
2021-05-31  2:30                                                                                                     ` Aaron Jensen
2021-06-03 21:42                                                                                                       ` Alan Third
2021-06-03 21:43                                                                                                         ` Aaron Jensen
2021-09-15 13:16                                                                                                         ` Aaron Jensen
2021-09-15 19:30                                                                                                           ` Illia Ostapyshyn
2021-09-15 19:54                                                                                                             ` Alan Third
2021-09-16 15:59                                                                                                               ` Y. E. via Emacs development discussions.
2021-09-17 17:31                                                                                                                 ` Alan Third
2021-09-17 17:43                                                                                                                   ` Aaron Jensen
2021-09-18  5:42                                                                                                                   ` Y. E. via Emacs development discussions.
2021-09-20 21:22                                                                                                                   ` Illia Ostapyshyn
2021-09-21  7:22                                                                                                                     ` Y. E. via Emacs development discussions.
2021-09-21 18:48                                                                                                                       ` Alan Third
2021-09-27 10:07                                                                                                                         ` Alan Third
2021-10-04 14:58                                                                                                                           ` Aaron Jensen
2021-10-25 19:39                                                                                                                           ` Illia Ostapyshyn
2021-10-26 12:16                                                                                                                             ` Alan Third
2021-10-26 13:26                                                                                                                               ` Aaron Jensen
2021-09-16 10:01                                                                                                           ` Rudolf Adamkovič
2021-05-30  6:22                                                                           ` Eli Zaretskii
2021-05-29  9:12                                                   ` Alan Third
2021-05-29  9:26                                                     ` Eli Zaretskii
2021-05-29  9:32                                                       ` Alan Third
2021-05-29  9:37                                                         ` Eli Zaretskii
2021-05-29  9:39                                                           ` Eli Zaretskii
2021-05-29  9:44                                                             ` Alan Third
2021-05-29 14:12                                                             ` Alan Third
2021-05-23 23:32                       ` Tim Cross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHyO48zYedpt+ZyMsSbkwr155tn3hbmR=L3KtSn8e-A9wef_vw@mail.gmail.com' \
    --to=aaronjensen@gmail.com \
    --cc=alan@idiocy.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mituharu@math.s.chiba-u.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.