From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call Date: Mon, 2 Sep 2024 12:21:25 -0700 Message-ID: References: <1191195d-1528-dc2a-64e0-15426e4b5608@yandex.ru> <75342f40-d576-e1c6-3d63-692b80e78bfe@yandex.ru> <90f8ce9c-4a60-4af9-8ed7-eeddff557129@yandex.ru> <2345189c-0033-4357-841c-1a6c7bc51a3c@yandex.ru> <79c2bec9-ceea-4bca-834e-245a9f2c756a@yandex.ru> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000dff936062127d880" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12747"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60321-done@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 02 21:23:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1slCe1-00038a-Se for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Sep 2024 21:23:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1slCdk-0000l4-4B; Mon, 02 Sep 2024 15:23:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slCdj-0000kW-2w for bug-gnu-emacs@gnu.org; Mon, 02 Sep 2024 15:23:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1slCdi-0003Pz-0M for bug-gnu-emacs@gnu.org; Mon, 02 Sep 2024 15:23:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:In-Reply-To:From:References:Mime-Version:To:Subject; bh=95vO/2qFIsv/8vdacvUlZ05mhkWPXRotUg4ccKSRloY=; b=h9a7Klp06hkEm7pWPLmHVILTB3JQ1fhIJqFkuyyjWGf0VoloZOnrskwkNg48sXWmh2OZVKHP8EVgUfFzbDRa/+zNoyRvH4xNlsuvZcFBuXDruheujETmahdcpH7ibN6A0GJSe895Wx2nDI/PbsdWL9rgpMrZHN+d4d/Ek3QWFDE56mFcpSjY7F0XvYUqLRjHPiTIQRV3bz1KJa7/0VwyDGx/A5KHtfFcxfKLOH7WmZR0TsJ3c/ix256MRLgBp+KM7kLQaWoo73RR0PINXgkJsTV5fTBINi4xer18xkXHMmdKi+4P8l7IJhEC5TtO+SfMFZWpPf2DBwXcY4QGKKumGg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1slCeh-0002fM-6A for bug-gnu-emacs@gnu.org; Mon, 02 Sep 2024 15:24:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Sep 2024 19:24:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60321 X-GNU-PR-Package: emacs Original-Received: via spool by 60321-done@debbugs.gnu.org id=D60321.172530501610183 (code D ref 60321); Mon, 02 Sep 2024 19:24:03 +0000 Original-Received: (at 60321-done) by debbugs.gnu.org; 2 Sep 2024 19:23:36 +0000 Original-Received: from localhost ([127.0.0.1]:52498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slCeG-0002eA-8w for submit@debbugs.gnu.org; Mon, 02 Sep 2024 15:23:36 -0400 Original-Received: from mail-lj1-f170.google.com ([209.85.208.170]:46589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slCeE-0002dq-52 for 60321-done@debbugs.gnu.org; Mon, 02 Sep 2024 15:23:34 -0400 Original-Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2f43de7ad5eso58565941fa.1 for <60321-done@debbugs.gnu.org>; Mon, 02 Sep 2024 12:22:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725304887; x=1725909687; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:in-reply-to:from:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=95vO/2qFIsv/8vdacvUlZ05mhkWPXRotUg4ccKSRloY=; b=aeabzOTWW3dhLkNn53TlcoZw3oIvJ6a3M99bB4sU/FPfxliH7W9ZYXWN4a+x1lT6Hv cUgpKxirH/F6ZwXHaTxAiXEZQxD3rut9SBG6+PGoY+UH0W5Nu9TrnCwKtbuvsCOEWsMN F8ys7Be8p7wodi3mQqaOaOe8pqRB4FeyCcqpV5VvG55QTsoXeejPQK6KdJDXkAaKwdFD EHB8RN+9JWctsrWCv8pZ/UfElpYWAHVkQ/IgMREjdvz3C6sBA0JQPBpv4dOKFFnGKlPO YS4vO1HUjo1c66EQIVZUINXRaz7Z2PrraFp9e3K3GSQzut2fAot3barRrXOAICFMGRLb pXFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725304887; x=1725909687; h=cc:to:subject:message-id:date:in-reply-to:from:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=95vO/2qFIsv/8vdacvUlZ05mhkWPXRotUg4ccKSRloY=; b=ue04gpmTNAUa8DiowlHUcOEq9Gx80t9xgspzzYzzLkjfA+6LPgCQv9yZyIOO1FeBDK P2philk7qFOol6+B2VLQeYiAkOMeONhh0A2nm+Pz6zEHdK56ppu6xyTj2JClBtGQKk87 +DC0MC4NMZX1pMUec5ZRs5MTeN3Sgeu+3yc1qjd9WIFx1pi9slkeXZ1whVX6APw5sy0X hpyl++RaBQfDafHvmvy4Ahm6oJ1/PikdLccN8/wqFS9Qkv1ZrckubPYbWFyqGHy9wkgo JSSP88zHE6NQLLLSjqZvpBm8LVwfbVgeAz/Tvi6bBFruYTY+sJSkn5/Cl7+EfG15NQfW NJuA== X-Gm-Message-State: AOJu0YzisOpys3HwbIa+8sccNpgDVqlJTCFCiPR4cyEMcUoKpRwrtoaA kY3KWQqSkdB84fmZziCSWyDjsO1hKJAi/xhyVd2a5xpnQ0/YK9wLvFVeGOcxFY9/eKKJfppqbzu bUZJ8HspBTecjr5KMCpcdQ8sQ0CI= X-Google-Smtp-Source: AGHT+IH3TVojiZr+2GRsXQQ7SdrqkxmxWDLu3mu0UhIFtDOhdpRspCfkyMz14+mqFIwLIMDfsUKtFbUhJK5n/mlXYuQ= X-Received: by 2002:a05:651c:b0d:b0:2ef:268a:a194 with SMTP id 38308e7fff4ca-2f6265506e5mr61080151fa.9.1725304886259; Mon, 02 Sep 2024 12:21:26 -0700 (PDT) Original-Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Mon, 2 Sep 2024 12:21:25 -0700 In-Reply-To: <79c2bec9-ceea-4bca-834e-245a9f2c756a@yandex.ru> X-Superhuman-Draft-ID: draft00b96d9d6114c147 X-Mailer: Superhuman iOS 11385 X-Superhuman-ID: m0ldyxoe.7b5f592c-c3a2-43b3-82d7-0ed2e1962511 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291121 Archived-At: --000000000000dff936062127d880 Content-Type: text/plain; charset="UTF-8" Thank you, and thanks for your help. Aaron On Mon, Sep 2 2024 at 3:01 PM, Dmitry Gutov wrote: > On 02/09/2024 04:56, Aaron Jensen wrote: > > It seems to me that anything other than 0 spaces would look inconsistent > with the first element (the hash), and its closing brace in particular. > > Yeah, that's my sense as well, even if it looks awful, but you get what > you get. > > * Support for the new option in ruby-ts-mode (it's good to have parity). > Could you take the attached patch for a spin? Seems to work here, but I'd > like to have an extra confirmation. > > I don't have the treesitter stuff installed at the moment, will try this > out shortly. > > Thanks in advance. > > I installed it and gave it a run on a few things. I didn't observe any > issues with it. > > Great! > > I've pushed both patches to emacs-30 (6c15b7710d4 and 24f12bdd77e) and now > marking the issue as done. Thanks again for the patch. > > To summarize for future readers: the default behavior doesn't change - at > least not now - you need to customize the option for different indentation. > --000000000000dff936062127d880 Content-Type: text/html; charset="UTF-8"
Thank you, and thanks for your help.


Aaron

On Mon, Sep 2 2024 at 3:01 PM, Dmitry Gutov <dgutov@yandex.ru> wrote:

On 02/09/2024 04:56, Aaron Jensen wrote:

It seems to me that anything other than 0 spaces would look inconsistent with the first element (the hash), and its closing brace in particular.

Yeah, that's my sense as well, even if it looks awful, but you get what you get.

* Support for the new option in ruby-ts-mode (it's good to have parity). Could you take the attached patch for a spin? Seems to work here, but I'd like to have an extra confirmation.

I don't have the treesitter stuff installed at the moment, will try this out shortly.

Thanks in advance.

I installed it and gave it a run on a few things. I didn't observe any issues with it.

Great!

I've pushed both patches to emacs-30 (6c15b7710d4 and 24f12bdd77e) and now marking the issue as done. Thanks again for the patch.

To summarize for future readers: the default behavior doesn't change - at least not now - you need to customize the option for different indentation.

--000000000000dff936062127d880--