From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#30553: 26.0.91; underline appears beneath line-spacing rather than beneath text Date: Wed, 21 Feb 2018 08:17:34 -0800 Message-ID: References: <83r2pf78x5.fsf@gnu.org> <83fu5v6kdi.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1519229777 5418 195.159.176.226 (21 Feb 2018 16:16:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Feb 2018 16:16:17 +0000 (UTC) Cc: 30553@debbugs.gnu.org To: Alp Aker Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 21 17:16:13 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eoX3z-0000x1-UF for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Feb 2018 17:16:12 +0100 Original-Received: from localhost ([::1]:33455 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoX62-0002wc-1p for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Feb 2018 11:18:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoX5s-0002vF-4t for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2018 11:18:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoX5n-0002vi-25 for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2018 11:18:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46768) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eoX5m-0002va-Tb for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2018 11:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eoX5m-0003Vp-P7 for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2018 11:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Feb 2018 16:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30553 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30553-submit@debbugs.gnu.org id=B30553.151922986313465 (code B ref 30553); Wed, 21 Feb 2018 16:18:02 +0000 Original-Received: (at 30553) by debbugs.gnu.org; 21 Feb 2018 16:17:43 +0000 Original-Received: from localhost ([127.0.0.1]:54664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eoX5T-0003V6-Fg for submit@debbugs.gnu.org; Wed, 21 Feb 2018 11:17:43 -0500 Original-Received: from mail-qk0-f169.google.com ([209.85.220.169]:34301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eoX5R-0003Uu-B5 for 30553@debbugs.gnu.org; Wed, 21 Feb 2018 11:17:41 -0500 Original-Received: by mail-qk0-f169.google.com with SMTP id l206so2651430qke.1 for <30553@debbugs.gnu.org>; Wed, 21 Feb 2018 08:17:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=bmfIokrM7/WS9Dl/MND3WvQqGiduXfgoz1SDPdIQ5bk=; b=UDMELsKDw3vY+gE52J7lboXLJgbUdGuHBS4lMUJVhCZKRHLkHzcc6UAEV2Sm9yefer MYrellbHDrrG5FX/L3dhryiMxybcKiH9DTvGEGHunQsYIJMIP7p27ftL4eW/KdFtx9tx kDwz4uSsK0YShA7Gw1y4XQFxxag1gvUWjiwF24QaWMNucxBecvt9jfFOCANuZli4FMpT KPq89hjklbrdf9OD760OEoswMjN2OHMda/BALhMsYioDOyArVXY+e7DxG2xIlWHqK3um wBLGpTJuNY5kNj1B0CPBLqZ8AvLHzhavCZdfrKhx70nib4IB8HFkn3p+zsLbqbByORnr 0OaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=bmfIokrM7/WS9Dl/MND3WvQqGiduXfgoz1SDPdIQ5bk=; b=VY+if9YvcdteVKqWpm+chOFdZRjATP+I3V8SW2QawmVoyQRFXoogEOpA9wGcIiOuvG 2s3GXeM2eit3ypG2RR9hrYef7ycq7JlBa0KR3L+BeW70SErZ5JJqFxqVaeY4UCDMRu+D PAP28+hGmbg2zSV4bZ7y+OE84mHbQMhPVB2JBKGQkDV07ZPn5HDPO8wSXwYPByQKwXF5 dmR1zYSIpXPp5iwPjR1KWK6De3O2cgC55dQuHj3Fw127GxSyB4+IRccopb+cekjSXCNG IoLL/X9fJ0VWs86ZHyieb7KlscsT1BecG1EWmhPt9dZa0weBcFuqZFuQnCwqDLxgov9n kkkA== X-Gm-Message-State: APf1xPBWSqHSwiw6GuSxoyVX/XQIwvs0CYaSrOrwD37BIcrUU/pJUVAr yfwmnm1FTkTlSktOuXqPMvF/urco/QfvfItMbZU= X-Google-Smtp-Source: AH8x2255zGqg97YYO9/emOZbVY3HNzhjagD7hiV6zstvfMShWu8g2g1tbfqgsrzRVb9hzUJufFxC7AqW+wZZD0R2KxA= X-Received: by 10.55.162.73 with SMTP id l70mr6167327qke.124.1519229855862; Wed, 21 Feb 2018 08:17:35 -0800 (PST) Original-Received: by 10.237.54.65 with HTTP; Wed, 21 Feb 2018 08:17:34 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143555 Archived-At: On Wed, Feb 21, 2018 at 5:47 AM, Alp Aker wrote: > On Wed, Feb 21, 2018 at 1:03 AM, Aaron Jensen wrote: > Something like that should already be possible. Underline placement is > determined by the following rules, considered in this order: > > 1. If x-underline-at-descent-line is non-nil, underline at the descent line, > where the descent line is the bottom of the current glyph row, inclusive of > extra line spacing. I'm specifically talking about this rule. I am suggesting that this change to not include the extra line spacing. Typographically, I cannot think of a good reason to include the extra line spacing. It ends up putting the underline above the next line effectively, which looks terrible (see my original screenshots). Given that rule #3 you mention below uses half the descent, it seems like the full descent + 1px could be used for this, which would put the underline in a sensible place (probably the place it is today when line-spacing is nil). > 2. If x-use-underline-position-properties is non-nil and the font has > underline > position info, use that. > > 3. If the current font can be determined, use half of the font's descent, > "descent" here meaning the maximum amount by which a character from the font > descends below the baseline. > > 4. Otherwise, use the default offset (1 point). > > The only one of these possibilities that should be affected a change in line > spacing is 1. Is that not what you see? >