From: Aaron Jensen <aaronjensen@gmail.com>
To: Alp Aker <alptekin.aker@gmail.com>
Cc: 30553@debbugs.gnu.org
Subject: bug#30553: 26.0.91; underline appears beneath line-spacing rather than beneath text
Date: Wed, 21 Feb 2018 08:17:34 -0800 [thread overview]
Message-ID: <CAHyO48zOPawOCjdJJq9=8cnuVXSbcVSCQktThMLkrhWcFunTgw@mail.gmail.com> (raw)
In-Reply-To: <CACxch4qL6sr5utZDg7iEPmc7LN4zuHZrZNSJGpW9NM-efkZwTg@mail.gmail.com>
On Wed, Feb 21, 2018 at 5:47 AM, Alp Aker <alptekin.aker@gmail.com> wrote:
> On Wed, Feb 21, 2018 at 1:03 AM, Aaron Jensen <aaronjensen@gmail.com> wrote:
> Something like that should already be possible. Underline placement is
> determined by the following rules, considered in this order:
>
> 1. If x-underline-at-descent-line is non-nil, underline at the descent line,
> where the descent line is the bottom of the current glyph row, inclusive of
> extra line spacing.
I'm specifically talking about this rule. I am suggesting that this
change to not include the extra line spacing. Typographically, I
cannot think of a good reason to include the extra line spacing. It
ends up putting the underline above the next line effectively, which
looks terrible (see my original screenshots). Given that rule #3 you
mention below uses half the descent, it seems like the full descent +
1px could be used for this, which would put the underline in a
sensible place (probably the place it is today when line-spacing is
nil).
> 2. If x-use-underline-position-properties is non-nil and the font has
> underline
> position info, use that.
>
> 3. If the current font can be determined, use half of the font's descent,
> "descent" here meaning the maximum amount by which a character from the font
> descends below the baseline.
>
> 4. Otherwise, use the default offset (1 point).
>
> The only one of these possibilities that should be affected a change in line
> spacing is 1. Is that not what you see?
>
next prev parent reply other threads:[~2018-02-21 16:17 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 18:16 bug#30553: 26.0.91; underline appears beneath line-spacing rather than beneath text Aaron Jensen
2018-02-20 19:33 ` Eli Zaretskii
2018-02-20 19:44 ` Aaron Jensen
2018-02-21 1:46 ` Alp Aker
2018-02-21 4:23 ` Eli Zaretskii
2018-02-21 4:27 ` Aaron Jensen
2018-02-21 5:01 ` Alp Aker
2018-02-21 6:03 ` Aaron Jensen
2018-02-21 13:47 ` Alp Aker
2018-02-21 16:17 ` Aaron Jensen [this message]
2018-02-21 17:56 ` Eli Zaretskii
2018-02-22 2:15 ` Aaron Jensen
2018-02-22 6:26 ` Eli Zaretskii
2018-02-22 6:29 ` Aaron Jensen
2018-02-22 7:21 ` Eli Zaretskii
2018-02-25 22:09 ` Aaron Jensen
2018-02-26 15:42 ` Eli Zaretskii
2018-02-26 16:01 ` Aaron Jensen
2018-02-26 19:25 ` Eli Zaretskii
2018-02-26 20:21 ` Aaron Jensen
2018-02-26 20:41 ` Eli Zaretskii
2018-02-26 20:46 ` Eli Zaretskii
2018-02-26 21:05 ` Aaron Jensen
2018-02-27 14:19 ` Aaron Jensen
2018-02-27 16:18 ` Eli Zaretskii
2018-02-28 15:19 ` Aaron Jensen
2018-02-28 16:14 ` Eli Zaretskii
2018-02-28 17:41 ` Aaron Jensen
2018-02-28 17:56 ` Eli Zaretskii
2018-03-01 8:36 ` Aaron Jensen
2018-03-08 6:31 ` Aaron Jensen
2018-03-08 13:45 ` Eli Zaretskii
2018-03-10 11:18 ` Eli Zaretskii
2018-03-10 17:47 ` Aaron Jensen
2018-03-10 18:48 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHyO48zOPawOCjdJJq9=8cnuVXSbcVSCQktThMLkrhWcFunTgw@mail.gmail.com' \
--to=aaronjensen@gmail.com \
--cc=30553@debbugs.gnu.org \
--cc=alptekin.aker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.