bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode

bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode

[Aaron Jensen]

repro.el:

(global-auto-revert-mode t)

emacs -Q -l repro.el

C-x C-f

/sudo::/

Enter the wrong password. Try entering the wrong password again (type
maybe 10 characters)

Expected:

Emacs does not hang and I can keep typing, hit enter and then try again.

Actual:

Emacs hangs after a few characters.


In GNU Emacs 27.0.50 (build 1, x86_64-apple-darwin18.2.0, NS appkit-1671.10 Version 10.14.1 (Build 18B75))
 of 2018-12-04 built on aaron-mbt.local
Repository revision: 12e922156c86a26fa4bb2cb9e7d2b3fd639e4707
Repository branch: master
Windowing system distributor 'Apple', version 10.3.1671
System Description:  Mac OS X 10.14.2

Recent messages:
Analyzing the buffer...done
Guessing...done
Local rules set
Appointment reminders enabled (no diary file found)
Added 2 events for today
Saving file /Users/aaronjensen/.emacs.d/.cache/work.org...
Wrote /Users/aaronjensen/.emacs.d/.cache/work.org
Showing all blocks ... done
Showing all blocks ... done
Added 2 events for today

Configured using:
 'configure --disable-dependency-tracking --disable-silent-rules
 --enable-locallisppath=/usr/local/share/emacs/site-lisp
 --infodir=/usr/local/Cellar/emacs-plus/HEAD-12e9221/share/info/emacs
 --prefix=/usr/local/Cellar/emacs-plus/HEAD-12e9221 --with-xml2
 --without-dbus --with-gnutls --with-imagemagick --with-modules
 --with-rsvg --with-ns --disable-ns-self-contained'

Configured features:
RSVG IMAGEMAGICK GLIB NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_SCROLL_BARS NS MODULES THREADS LCMS2 GMP

Important settings:
  value of $LC_CTYPE: en_US.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
  global-magit-file-mode: t
  magit-file-mode: t
  magit-auto-revert-mode: t
  global-evil-surround-mode: t
  evil-surround-mode: t
  diff-auto-refine-mode: t
  pupo-mode: t
  purpose-mode: t
  company-statistics-mode: t
  company-posframe-mode: t
  auto-compile-mode: t
  elisp-slime-nav-mode: t
  eros-mode: t
  lispyville-mode: t
  lispy-mode: t
  nameless-mode: t
  eval-sexp-fu-flash-mode: t
  goto-address-prog-mode: t
  bug-reference-prog-mode: t
  auto-highlight-symbol-mode: t
  dtrt-indent-mode: t
  flycheck-pos-tip-mode: t
  global-flycheck-mode: t
  highlight-numbers-mode: t
  highlight-parentheses-mode: t
  rainbow-delimiters-mode: t
  show-smartparens-global-mode: t
  show-smartparens-mode: t
  evil-escape-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  global-git-gutter+-mode: t
  git-gutter+-mode: t
  global-git-commit-mode: t
  async-bytecomp-package-mode: t
  recentf-mode: t
  desktop-save-mode: t
  ivy-prescient-mode: t
  company-prescient-mode: t
  prescient-persist-mode: t
  company-mode: t
  global-wakatime-mode: t
  wakatime-mode: t
  hl-todo-mode: t
  doom-modeline-mode: t
  eldoc-in-minibuffer-mode: t
  winner-mode: t
  global-spacemacs-whitespace-cleanup-mode: t
  spacemacs-whitespace-cleanup-mode: t
  ws-butler-global-mode: t
  ws-butler-mode: t
  winum-mode: t
  global-vi-tilde-fringe-mode: t
  vi-tilde-fringe-mode: t
  save-place-mode: t
  savehist-mode: t
  projectile-rails-global-mode: t
  projectile-mode: t
  persp-mode: t
  global-origami-mode: t
  origami-mode: t
  eyebrowse-mode: t
  evil-mc-mode: t
  global-anzu-mode: t
  anzu-mode: t
  editorconfig-mode: t
  counsel-mode: t
  ivy-mode: t
  delete-selection-mode: t
  clean-aindent-mode: t
  hybrid-mode: t
  which-key-mode: t
  override-global-mode: t
  global-undo-tree-mode: t
  undo-tree-mode: t
  evil-mode: t
  evil-local-mode: t
  spacemacs-leader-override-mode: t
  global-spacemacs-leader-override-mode: t
  global-hl-line-mode: t
  xterm-mouse-mode: t
  global-auto-revert-mode: t
  shell-dirtrack-mode: t
  ido-vertical-mode: t
  global-page-break-lines-mode: t
  page-break-lines-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t
  hs-minor-mode: t

Load-path shadows:
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/ht-20181216.1137/ht hides /Users/aaronjensen/.emacs.d/core/libs/ht
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/inf-ruby-20180521.1348/inf-ruby hides /usr/local/share/emacs/site-lisp/ruby/inf-ruby
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-stan hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-stan
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-exp hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-exp
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-J hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-J
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-eshell hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-eshell
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-emacs-lisp hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-emacs-lisp
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-gnus hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-gnus
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-css hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-css
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-lob hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-lob
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-forth hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-forth
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-macs hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-macs
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-version hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-version
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-scheme hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-scheme
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ox hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ox
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-abc hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-abc
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-C hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-C
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-capture hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-capture
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-ref hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-ref
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-clojure hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-clojure
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-mouse hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-mouse
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-ledger hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-ledger
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-ctags hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-ctags
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-entities hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-entities
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-archive hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-archive
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-screen hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-screen
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-haskell hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-haskell
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-asymptote hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-asymptote
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-mhe hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-mhe
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-table hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-table
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-keys hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-keys
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ox-org hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ox-org
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-plot hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-plot
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-awk hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-awk
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-groovy hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-groovy
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-octave hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-octave
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-faces hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-faces
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-colview hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-colview
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-R hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-R
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-timer hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-timer
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-ebnf hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-ebnf
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-mobile hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-mobile
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-fortran hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-fortran
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-shell hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-shell
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-perl hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-perl
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-sqlite hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-sqlite
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-sed hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-sed
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-list hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-list
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-ruby hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-ruby
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-eval hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-eval
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-habit hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-habit
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-clock hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-clock
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ox-html hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ox-html
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-src hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-src
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-lisp hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-lisp
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-ditaa hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-ditaa
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-pcomplete hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-pcomplete
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-lint hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-lint
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-rmail hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-rmail
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ox-latex hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ox-latex
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-sass hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-sass
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-io hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-io
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-tangle hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-tangle
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-calc hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-calc
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-java hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-java
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ox-icalendar hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ox-icalendar
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-eww hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-eww
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ox-md hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ox-md
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ox-beamer hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ox-beamer
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-element hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-element
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-protocol hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-protocol
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-mscgen hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-mscgen
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-gnuplot hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-gnuplot
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-latex hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-latex
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-id hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-id
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-vala hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-vala
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ox-man hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ox-man
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-feed hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-feed
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-lua hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-lua
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-table hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-table
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-ocaml hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-ocaml
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-coq hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-coq
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-picolisp hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-picolisp
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-indent hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-indent
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-lilypond hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-lilypond
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-matlab hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-matlab
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-datetree hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-datetree
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-python hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-python
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-bbdb hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-bbdb
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-makefile hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-makefile
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-duration hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-duration
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-agenda hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-agenda
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-dot hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-dot
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-js hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-js
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ox-publish hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ox-publish
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-inlinetask hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-inlinetask
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-org hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-org
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-core hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-core
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-compat hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-compat
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-docview hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-docview
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ox-odt hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ox-odt
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-plantuml hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-plantuml
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ox-ascii hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ox-ascii
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-loaddefs hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-loaddefs
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-w3m hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-w3m
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-bibtex hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-bibtex
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-info hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-info
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-hledger hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-hledger
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-maxima hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-maxima
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-macro hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-macro
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-sql hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-sql
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-attach hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-attach
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-processing hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-processing
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ox-texinfo hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ox-texinfo
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-irc hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-irc
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-crypt hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-crypt
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-footnote hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-footnote
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/org-install hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/org-install
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-comint hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-comint
/Users/aaronjensen/.emacs.d/elpa/27.0/develop/org-plus-contrib-20190122/ob-shen hides /usr/local/Cellar/emacs-plus/HEAD-12e9221/share/emacs/27.0.50/lisp/org/ob-shen

Features:
(shadow sort mail-extr emacsbug sendmail smex appt diary-lib
diary-loaddefs add-node-modules-path json-mode json-reformat
json-snatcher company-lua smartparens-lua lua-mode alchemist
alchemist-macroexpand alchemist-company alchemist-help
alchemist-complete alchemist-refcard alchemist-phoenix alchemist-compile
alchemist-iex alchemist-message alchemist-hooks alchemist-hex
alchemist-mix alchemist-info alchemist-goto alchemist-scope
alchemist-eval alchemist-interact alchemist-server alchemist-execute
alchemist-report alchemist-test-mode alchemist-project alchemist-file
alchemist-key alchemist-utils flycheck-dialyxir flycheck-credo
smartparens-elixir elixir-mode elixir-format elixir-smie sh-script
smartparens-javascript js org-agenda pp company-emoji company-emoji-list
org-eldoc evil-org org-table ob-C cc-mode cc-fonts cc-guess cc-menus
cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs ob-shell ob-js
ob-ruby org-bullets org-download toc-org typo org-variable-pitch
org-indent image-file org-eww org-rmail org-mhe org-irc org-info
org-gnus nnir gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap
nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range
gnus-win gnus nnheader org-docview doc-view jka-compr image-mode
org-bibtex bibtex org-bbdb org-w3m org-checklist org-inlinetask org-gcal
org-archive smartparens-org ob-async ob-elixir ob-http ob-http-mode
ob-restclient restclient ox-gfm ox-md ox-reveal ox-odt rng-loc rng-uri
rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns
nxml-enc xmltok nxml-util ox-latex ox-icalendar ox-html table ox-ascii
ox-publish ox orgit org-element avl-tree evil-magit git-rebase
forge-list forge-commands forge-semi forge-bitbucket buck forge-gogs
gogs forge-gitea gtea forge-gitlab glab forge-github ghub-graphql treepy
graphql ghub forge-notify forge-revnote forge-pullreq forge-issue
forge-topic forge-post smartparens-markdown markdown-mode forge-repo
forge forge-core forge-db closql emacsql-sqlite emacsql emacsql-compiler
magit-submodule magit-obsolete magit-blame magit-stash magit-bisect
magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit
magit-sequence magit-notes magit-worktree magit-tag magit-merge
magit-branch magit-reset magit-files magit-refs magit-status magit
magit-repos magit-apply magit-wip magit-log which-func magit-diff
smerge-mode magit-core magit-autorevert magit-process magit-margin
magit-mode org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro
org-footnote org-src ob-comint ob-keys org-pcomplete org-list org-faces
org-entities org-version ob-emacs-lisp ob-core ob-eval org-compat
org-macs org-loaddefs cal-menu calendar cal-loaddefs request-deferred
deferred request alert log4e notifications dbus xml gntp company-tng
misearch multi-isearch counsel-projectile executable evil-nerd-commenter
evil-nerd-commenter-operator evil-nerd-commenter-sdk smartparens-html
sgml-mode dom evil-surround vc-git diff-mode spacemacs-purpose-popwin
window-purpose-x imenu-list window-purpose window-purpose-fixes
window-purpose-prefix-overload window-purpose-switch
window-purpose-layout window-purpose-core window-purpose-configuration
window-purpose-utils company-statistics company-posframe posframe
company-files company-keywords company-dabbrev-code company-dabbrev
company-capf overseer pkg-info url-http url url-proxy url-privacy
url-expand url-methods url-history mailcap url-auth url-cookie
url-domsuf url-util url-gw nsm epl auto-compile packed elisp-slime-nav
eros flycheck-package package-lint imenu finder lispyville lispy
lispy-inline avy etags multifile generator edebug backtrace lispy-tags
mode-local nameless eval-sexp-fu goto-addr bug-reference
auto-highlight-symbol dtrt-indent evil-lisp-state flycheck-pos-tip
pos-tip flycheck find-func highlight-numbers parent-mode
highlight-parentheses hideshow rainbow-delimiters smartparens-config
smartparens-text smartparens-ruby smartparens yasnippet-snippets
yasnippet evil-escape elec-pair editorconfig-core
editorconfig-core-handle editorconfig-fnmatch git-gutter-fringe+
fringe-helper git-gutter+ git-commit with-editor magit-git magit-section
magit-utils magit-popup async-bytecomp async crm log-edit message rmc
puny rfc822 mml mml-sec epa gnus-util rmail rmail-loaddefs time-date
mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log face-remap
recentf tree-widget desktop frameset ivy-prescient company-prescient
prescient company wakatime-mode contextual-menubar
evil-collection-integration evil-collection-dired evil-collection-custom
evil-collection init-doom-modeline powerline-separators quiet-emacs
fill-or-unfill init-macos-terminal-copy-paste init-terminal-cursor
evil-terminal-cursor-changer init-org init-magit hl-todo doom-modeline
doom-modeline-segments doom-modeline-env doom-modeline-core shrink-path
eldoc-eval all-the-icons all-the-icons-faces data-material
data-weathericons data-octicons data-fileicons data-faicons
data-alltheicons memoize persistent-soft list-utils pcache eieio-base
font-utils server winner xterm-color spacemacs-whitespace-cleanup
ws-butler winum vi-tilde-fringe unicode-fonts tmux string-inflection
saveplace savehist ruby-test-mode pcre2el rxt re-builder
projectile-rails rake f inflections inf-ruby ruby-mode smie projectile
grep ibuf-ext ibuffer ibuffer-loaddefs popwin persp-mode osx-trash
origami origami-parsers s ivy-hydra google-c-style eyebrowse dash
evil-mc evil-mc-command-execute evil-mc-command-record
evil-mc-cursor-make evil-mc-region evil-mc-cursor-state evil-mc-undo
evil-mc-vars evil-mc-known-commands evil-mc-common evil-anzu anzu
editorconfig noutline outline counsel xdg xref project dired
dired-loaddefs swiper ivy flx delsel colir color ivy-overlay ffap
clean-aindent-mode gh-common marshal fix-word docker-tramp tramp-cache
hybrid-mode evil-evilified-state which-key use-package
use-package-ensure use-package-delight use-package-diminish
use-package-bind-key bind-key use-package-core hydra lv cus-edit
cus-start cus-load evil evil-integration undo-tree diff evil-maps
evil-commands reveal flyspell ispell evil-jumps evil-command-window
evil-types evil-search evil-ex evil-macros evil-repeat evil-states
evil-core evil-common windmove thingatpt rect evil-digraphs diminish
evil-vars bind-map quelpa mm-decode mm-bodies mm-encode mail-parse
rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr lisp-mnt help-fns
radix-tree hl-line xt-mouse autorevert filenotify disp-table wid-edit
night-owl-theme info finder-inf patch-server init-sass init-php
init-html init-evil tramp trampver tramp-compat tramp-loaddefs shell
pcomplete parse-time format-spec ido-vertical-mode ido core-spacemacs
core-use-package-ext core-transient-state core-micro-state core-toggle
core-keybindings core-fonts-support core-themes-support
core-display-init core-jump core-release-management core-custom-settings
core-configuration-layer eieio-compat core-progress-bar
core-spacemacs-buffer core-funcs ht cl warnings package let-alist
cl-extra help-mode url-handlers url-parse auth-source cl-seq
password-cache json map url-vars seq eieio byte-opt compile comint
ansi-color ring bytecomp byte-compile cconv eieio-core eieio-loaddefs
epg epg-config core-command-line pcase core-debug edmacro kmacro derived
cl-macs gv profiler easymenu core-hooks page-break-lines easy-mmode
core-env load-env-vars rx cl-loaddefs cl-lib core-dotspacemacs advice
core-emacs-backports subr-x core-dumper tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win
ucs-normalize mule-util term/common-win tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process
emacs)

Memory information:
((conses 16 1354216 652995)
 (symbols 48 86324 1)
 (strings 32 301411 125769)
 (string-bytes 1 9617238)
 (vectors 16 134429)
 (vector-slots 8 2827779 378344)
 (floats 8 1660 3016)
 (intervals 56 34858 4773)
 (buffers 992 77))

bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode

[Aaron Jensen]

It appears that the hang happens when (expand-file-name
default-directory) is hit within auto-revert-notify-add-watch for the
tramp buffer: /sudo:root@myhost.local

I wonder if it's essentially trying to recursively make that tramp
connection or something along those lines?

Here's the *Messages* buffer:

Tramp: Opening connection for root@myhost.local using sudo...
Tramp: Sending command ‘exec env SHELL=/bin/sh sudo -u root -s -H -p
P""a""s""s""w""o""r""d"":’
Tramp: Waiting for prompts from remote shell...
Tramp: Sending Password
expand-file-name: #("/sudo:root@myhost.local:" 6 10 (tramp-default t)
11 26 (tramp-default t))
Quit
Tramp: Waiting for prompts from remote shell...failed
Tramp: Opening connection for root@aaron-mbt.local using sudo...failed
Quit [15 times]

You can see where the expand-file-name happens. I believe that's where
it hangs. Spamming C-g gets out of it.

I have no idea what the right fix is for this, hopefully someone with
more tramp or auto-revert familiarity has an idea.

Thanks,

Aaron

bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode

[Aaron Jensen]

On Sun, Jan 27, 2019 at 6:34 AM Aaron Jensen <aaronjensen@gmail.com> wrote:
>
> It appears that the hang happens when (expand-file-name
> default-directory) is hit within auto-revert-notify-add-watch for the
> tramp buffer: /sudo:root@myhost.local

For now, I am working around this with:

(add-to-list 'global-auto-revert-ignore-modes 'fundamental-mode)

Though that doesn't seem like it should be necessary.

Aaron

bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode

[Michael Albinus]

Aaron Jensen <aaronjensen@gmail.com> writes:

Hi Aaron,

>> It appears that the hang happens when (expand-file-name
>> default-directory) is hit within auto-revert-notify-add-watch for the
>> tramp buffer: /sudo:root@myhost.local
>
> For now, I am working around this with:
>
> (add-to-list 'global-auto-revert-ignore-modes 'fundamental-mode)
>
> Though that doesn't seem like it should be necessary.

For the records, I've seen the bug report, and I could reproduce
it. Since I'm in a transition phase with Tramp, reworking
accept-process-output usage, it will take some days until I could
handle. Don't despair :-)

> Aaron

Best regards, Michael.

bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode

[Michael Albinus]

Michael Albinus <michael.albinus@gmx.de> writes:

Hi Aaron,

>>> It appears that the hang happens when (expand-file-name
>>> default-directory) is hit within auto-revert-notify-add-watch for the
>>> tramp buffer: /sudo:root@myhost.local

> For the records, I've seen the bug report, and I could reproduce
> it. Since I'm in a transition phase with Tramp, reworking
> accept-process-output usage, it will take some days until I could
> handle. Don't despair :-)

Finally, I found the time to dig into this. I've pushed a fix to master
(disable `global-auto-revert-mode' temporarily). Could you, pls, recheck?

>> Aaron

Best regards, Michael.

bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode

[Michael Albinus]

[-- Attachment #1: Type: text/plain, Size: 508 bytes --]

Aaron Jensen <aaronjensen@gmail.com> writes:

Hi Aaron,

[Pls keep the Cc, for the archives]

> I think that not-yet-connected tramp buffers need to be excluded from
> garm entirely, if that is possible.

Good idea. I've appended a patch, which reverts the last change from
tramp.el, and implements your proposal in autorevert.el. This is also
better, because Tramp as library shouldn't care about auto-revert.

Could you, pls, check whether this works for you?

> Thanks,
>
> Aaron

Best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 2191 bytes --]

diff --git a/lisp/autorevert.el b/lisp/autorevert.el
index 16a742a458..150693baf1 100644
--- a/lisp/autorevert.el
+++ b/lisp/autorevert.el
@@ -767,6 +767,16 @@ auto-revert-buffers
 		    (buffer-list)
 		  auto-revert-buffer-list))
 	  remaining new)
+      ;; Buffers with remote contents shall be reverted only if the
+      ;; connection is established already.
+      (setq bufs (delq nil
+                       (mapcar
+                        (lambda (buf)
+                          (with-current-buffer buf
+                            (and (or (not (file-remote-p default-directory))
+                                     (file-remote-p default-directory nil t))
+                                 buf)))
+                        bufs)))
       ;; Partition `bufs' into two halves depending on whether or not
       ;; the buffers are in `auto-revert-remaining-buffers'.  The two
       ;; halves are then re-joined with the "remaining" buffers at the
diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
index 82d2e5a4d3..d000bbe3d6 100644
--- a/lisp/net/tramp.el
+++ b/lisp/net/tramp.el
@@ -4060,23 +4060,17 @@ tramp-process-actions
   (save-restriction
     (with-tramp-progress-reporter
 	proc 3 "Waiting for prompts from remote shell"
-      ;; `global-auto-revert-mode' could activate remote operations
-      ;; while we aren't ready.  We disable it temporarily.
-      (let ((garm (bound-and-true-p global-auto-revert-mode))
-	    exit)
-	(when garm (global-auto-revert-mode -1))
-	(unwind-protect
-	    (if timeout
-		(with-timeout (timeout (setq exit 'timeout))
-		  (while (not exit)
-		    (setq exit
-			  (catch 'tramp-action
-			    (tramp-process-one-action proc vec actions)))))
+      (let (exit)
+	(if timeout
+	    (with-timeout (timeout (setq exit 'timeout))
 	      (while (not exit)
 		(setq exit
 		      (catch 'tramp-action
 			(tramp-process-one-action proc vec actions)))))
-	  (when garm (global-auto-revert-mode)))
+	  (while (not exit)
+	    (setq exit
+		  (catch 'tramp-action
+		    (tramp-process-one-action proc vec actions)))))
 	(with-current-buffer (tramp-get-connection-buffer vec)
 	  (widen)
 	  (tramp-message vec 6 "\n%s" (buffer-string)))

bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode

[Aaron Jensen]

On Tue, Feb 5, 2019 at 4:51 AM Michael Albinus <michael.albinus@gmx.de> wrote:
>
> [Pls keep the Cc, for the archives]

Sorry, clicked the wrong button, thank you for the reminder.

> > I think that not-yet-connected tramp buffers need to be excluded from
> > garm entirely, if that is possible.
>
> Good idea. I've appended a patch, which reverts the last change from
> tramp.el, and implements your proposal in autorevert.el. This is also
> better, because Tramp as library shouldn't care about auto-revert.
>
> Could you, pls, check whether this works for you?

It works brilliantly as far as I can tell in both emacs -Q and my config.

Is there any cost to an extra loop over all buffers and doing
with-current-buffer?

I wonder if a change to auto-revert-active-p would be better than
looping through all of the buffers and with-current-buffering them
again. I don't know if that's semantically wrong for that function.

Another option is putting a check in auto-revert-notify-add-watch,
since that already has checks to ensure the file is okay to be
watched:

          (or auto-revert-notify-watch-descriptor
              (and (file-remote-p default-directory)
                   (not (file-remote-p default-directory nil t)))
              (string-match auto-revert-notify-exclude-dir-regexp
                            (expand-file-name default-directory))
              (file-symlink-p (or buffer-file-name default-directory)))

With that in place, even if I enable auto-revert-remote-files I don't
experience the hang.

Thanks,

Aaron

bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode

[Michael Albinus]

Aaron Jensen <aaronjensen@gmail.com> writes:

Hi Aaron,

> Is there any cost to an extra loop over all buffers and doing
> with-current-buffer?

There is cost, but not too much. `file-remote-p' doesn't go remote, and
it is fast:

(let ((default-directory "/sudo::"))
  (benchmark 1000 (with-temp-buffer (file-remote-p default-directory))))
=> Elapsed time: 0.000060s

> I wonder if a change to auto-revert-active-p would be better than
> looping through all of the buffers and with-current-buffering them
> again. I don't know if that's semantically wrong for that function.

I've played with this idea as well. But the call is much too late for
our purposes (somewhere in the middle of auto-revert-buffers)

> Another option is putting a check in auto-revert-notify-add-watch,
> since that already has checks to ensure the file is okay to be
> watched:
>
>           (or auto-revert-notify-watch-descriptor
>               (and (file-remote-p default-directory)
>                    (not (file-remote-p default-directory nil t)))
>               (string-match auto-revert-notify-exclude-dir-regexp
>                             (expand-file-name default-directory))
>               (file-symlink-p (or buffer-file-name default-directory)))
>
> With that in place, even if I enable auto-revert-remote-files I don't
> experience the hang.

Yes, I've played with this also. auto-revert-notify-add-watch comes in
place when file notification is used. That's not the case, always.

So I tend to push my patch, if nobody complains. Let's sleep over this :-)

> Thanks,
>
> Aaron

Best regards, Michael.

bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode

[Aaron Jensen]

On Tue, Feb 5, 2019 at 9:59 AM Michael Albinus <michael.albinus@gmx.de> wrote:

> Yes, I've played with this also. auto-revert-notify-add-watch comes in
> place when file notification is used. That's not the case, always.

Right, and I think the hang only occurs when that is the case as far
as I can tell. Or were you able to reproduce the hang with file
notification disabled?

> So I tend to push my patch, if nobody complains. Let's sleep over this :-)

It works for me, so I'd be happy with it.

Cheers,

Aaron

bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode

[Michael Albinus]

Aaron Jensen <aaronjensen@gmail.com> writes:

Hi Aaron,

>> Yes, I've played with this also. auto-revert-notify-add-watch comes in
>> place when file notification is used. That's not the case, always.
>
> Right, and I think the hang only occurs when that is the case as far
> as I can tell. Or were you able to reproduce the hang with file
> notification disabled?

No, I haven't tried. But auto-revert-notify-add-watch is called after
auto-revert-active-p, so it's not sufficient to test it such late.

> Cheers,
>
> Aaron

Best regards, Michael.

bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode

[Aaron Jensen]

On Tue, Feb 5, 2019 at 11:22 AM Michael Albinus <michael.albinus@gmx.de> wrote:
>
> No, I haven't tried. But auto-revert-notify-add-watch is called after
> auto-revert-active-p, so it's not sufficient to test it such late.

Not sufficient for what, exactly? Testing it only in
auto-revert-notify-add-watch prevents the hang for me. The only thing
it wouldn't prevent is auto-revert-handler getting called, but that
doesn't seem to have any negative impact as far as I could tell, but I
could be missing an edge case.

Aaron

bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode

[Michael Albinus]

Aaron Jensen <aaronjensen@gmail.com> writes:

>> No, I haven't tried. But auto-revert-notify-add-watch is called after
>> auto-revert-active-p, so it's not sufficient to test it such late.
>
> Not sufficient for what, exactly? Testing it only in
> auto-revert-notify-add-watch prevents the hang for me. The only thing
> it wouldn't prevent is auto-revert-handler getting called, but that
> doesn't seem to have any negative impact as far as I could tell, but I
> could be missing an edge case.

As I said earlier, I've tried to add the test in auto-revert-active-p,
and this wasn't successful; the problem still happened.

And auto-revert-notify-add-watch is called only if auto-revert-active-p
returns non-nil.

> Aaron

Best regards, Michael.

bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode

[Aaron Jensen]

On Tue, Feb 5, 2019 at 12:07 PM Michael Albinus <michael.albinus@gmx.de> wrote:
>
> As I said earlier, I've tried to add the test in auto-revert-active-p,
> and this wasn't successful; the problem still happened.

Got it, I misunderstood and couldn't reproduce with this. Since you
saw it happen w/ that I say we go with your patch. Thanks again!

Aaron

bug#34196: 27.0.50; tramp hangs on wrong password with global-auto-revert-mode

[Michael Albinus]

Aaron Jensen <aaronjensen@gmail.com> writes:

> Got it, I misunderstood and couldn't reproduce with this. Since you
> saw it happen w/ that I say we go with your patch. Thanks again!

I've pushed the patch to Emacs master (plus some minor cleanups in
Tramp). Closing the bug.

> Aaron

Best regards, Michael.

bug#34196: Error in auto-revert-buffers: Wrong type argument

[Alex Branham]

Hi Michael -

The fix for this bug seems to cause issues if default-directory is nil
for any buffer. In particular, you get a wrong type argument where
auto-revert-buffers is expecting a string instead of nil.

This change fixes the issue for me:

Thanks,
Alex

diff --git a/lisp/autorevert.el b/lisp/autorevert.el
index 150693baf1..318b10d4a8 100644
--- a/lisp/autorevert.el
+++ b/lisp/autorevert.el
@@ -773,7 +773,8 @@ the timer when no buffers need to be checked."
                        (mapcar
                         (lambda (buf)
                           (with-current-buffer buf
-                            (and (or (not (file-remote-p default-directory))
+                            (and default-directory
+                                 (or (not (file-remote-p default-directory))
                                      (file-remote-p default-directory nil t))
                                  buf)))
                         bufs)))

bug#34196: Error in auto-revert-buffers: Wrong type argument

[Michael Albinus]

Alex Branham <alex.branham@gmail.com> writes:

> Hi Michael -

Hi Alex,

> The fix for this bug seems to cause issues if default-directory is nil
> for any buffer. In particular, you get a wrong type argument where
> auto-revert-buffers is expecting a string instead of nil.

Thanks for the report. We could apply your patch of course, but I'm
curious: `default-directory' shall always be set. So I would like to
know where the error comes from.

Could you, pls, set `debug-on-error' to t, and rerun the test? There
should be a backtrace, which might tell us more.

> Thanks,
> Alex

Best regards, Michael.

bug#34196: Error in auto-revert-buffers: Wrong type argument

[Alex Branham]

On Wed 13 Feb 2019 at 17:09, Michael Albinus <michael.albinus@gmx.de> wrote:

> Thanks for the report. We could apply your patch of course, but I'm
> curious: `default-directory' shall always be set. So I would like to
> know where the error comes from.
>
> Could you, pls, set `debug-on-error' to t, and rerun the test? There
> should be a backtrace, which might tell us more.

I'm not really sure when/how/why default-directory becomes nil. It seems
to happen in non-file-visiting buffers (e.g. *scratch*, *Backtrace*, any
comint buffer, etc) from time to time. I know "from time to time" is
vague; I've had a hard time tracking it down.

I'm using EXWM (not sure if that has anything at all to do with it) and
it seems like it happens when my screen turns off after a period of
inactivity. I'm not really sure how/why Emacs would know about that
though, so perhaps it's totally unrelated.

Thanks,
Alex

bug#34196: Error in auto-revert-buffers: Wrong type argument

[Michael Albinus]

Alex Branham <alex.branham@gmail.com> writes:

Hi Alex,

> I'm not really sure when/how/why default-directory becomes nil. It seems
> to happen in non-file-visiting buffers (e.g. *scratch*, *Backtrace*, any
> comint buffer, etc) from time to time. I know "from time to time" is
> vague; I've had a hard time tracking it down.
>
> I'm using EXWM (not sure if that has anything at all to do with it) and
> it seems like it happens when my screen turns off after a period of
> inactivity. I'm not really sure how/why Emacs would know about that
> though, so perhaps it's totally unrelated.

I see your point. However, if you keep the debug-on-error setting, the
problem will appear next time, and we can analyze the timestamp.

> Thanks,
> Alex

Best regards, Michael.