From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#31546: 27.0.50; macOS child frames with no mode-line mouse click problem Date: Thu, 24 May 2018 03:53:54 -0700 Message-ID: References: <5B03C5DD.2000304@gmx.at> <5B03D77C.80606@gmx.at> <20180522193353.GC35196@breton.holly.idiocy.org> <20180522194441.GE35196@breton.holly.idiocy.org> <5B050BEA.4000804@gmx.at> <20180523213124.GC36578@breton.holly.idiocy.org> <5B06679A.2020407@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000005a7375056cf17892" X-Trace: blaine.gmane.org 1527159191 972 195.159.176.226 (24 May 2018 10:53:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 24 May 2018 10:53:11 +0000 (UTC) Cc: 31546@debbugs.gnu.org, Alan Third To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 24 12:53:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLnrl-00007L-GT for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 May 2018 12:53:05 +0200 Original-Received: from localhost ([::1]:37747 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLnts-0003wi-Mx for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 May 2018 06:55:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLnti-0003vL-JY for bug-gnu-emacs@gnu.org; Thu, 24 May 2018 06:55:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLnte-0000rO-Nk for bug-gnu-emacs@gnu.org; Thu, 24 May 2018 06:55:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38120) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fLnte-0000rA-Hx for bug-gnu-emacs@gnu.org; Thu, 24 May 2018 06:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fLnte-0002Lx-2H for bug-gnu-emacs@gnu.org; Thu, 24 May 2018 06:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 May 2018 10:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31546 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31546-submit@debbugs.gnu.org id=B31546.15271592548986 (code B ref 31546); Thu, 24 May 2018 10:55:02 +0000 Original-Received: (at 31546) by debbugs.gnu.org; 24 May 2018 10:54:14 +0000 Original-Received: from localhost ([127.0.0.1]:46017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLnsr-0002Ks-PE for submit@debbugs.gnu.org; Thu, 24 May 2018 06:54:13 -0400 Original-Received: from mail-qt0-f173.google.com ([209.85.216.173]:45305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLnsp-0002Ka-6l for 31546@debbugs.gnu.org; Thu, 24 May 2018 06:54:13 -0400 Original-Received: by mail-qt0-f173.google.com with SMTP id j42-v6so1349772qtj.12 for <31546@debbugs.gnu.org>; Thu, 24 May 2018 03:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+TP1YS7ZemN7HRetGgUWiU9IDfbdXUyBFJJf2g5lPEU=; b=qVU1zSL4VHDSLcUUYU2pexwq1UgV9ZwxmbAG3Q2p3gv1YdrVwmQ1MFIt8BIhNDsIiX zNLsm3Knlk7X3qCVz3vBk4jxOGwznZu75PuXrXn40N3dLQ96ZUKsaa5R05C6Q0IlHdu7 EH4NPO3BiwAD76SQe5eM3km04m5namEU7UyKxHhytCNgqoScDixbWPr+gCFpBHBeyILy +EXvHZ4RguVkWjEkSCmqd6h1aa7rhaSEZXURzkM6kuQWQewY/x9BalVXp1ZUzZSjkhrB X5Bcn8SufVd9rL5JMp2qHmfji8KNIGGEJYiN4PRV5WzT6GpnY8ZrP3dQQ012Sp/nyDqK lXIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+TP1YS7ZemN7HRetGgUWiU9IDfbdXUyBFJJf2g5lPEU=; b=uTkBp4BbkV5Thv2fwpJ6+i28VUrBf/cPoSQJCIgyISbVUnvigLtL24Sa+7IKfCoaKH E5rwLJmmyVt3cqsSl0xdezn+fOw35yvEhd211DzweFRH35Rew24+3q3HM8AqN/+7EYoU tbr9RlATaxiP2Iel4bztjwEm3JesUatBy62b2GWisbSHg98dIdvMOXVanzyZi38JDWkn Uj+VQcHEY4OXQzpFuw/hyc7opwoZNqjL0H4Aa32jhBPxN2PvxHfrXNGKCEZnsjodb/xX tMv94Z/HJGrRSgu6UsMMyBJtESCa6swxsthFW935gmZBIqlFHW9VEFtJfmnHBlRynwAD yXjQ== X-Gm-Message-State: ALKqPwcpXkHmjfyzRkC3d6qIAyygWJlAgoa7RjBHUzDwk+kwyf1N/5bw qUb68cBQVEGmWtPuxumGuG2dg+XQ53P/TK6H9EU= X-Google-Smtp-Source: ADUXVKLLwspUJ00N4uWxJhzW8EX2PqZ5jvLQwdg8Zs0G8oQ/bcgM41WkeQ/EMWrNDcZGcx3lBGKLeEUdLgQPRQqW+sI= X-Received: by 2002:ac8:3788:: with SMTP id d8-v6mr6525195qtc.61.1527159245654; Thu, 24 May 2018 03:54:05 -0700 (PDT) In-Reply-To: <5B06679A.2020407@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146470 Archived-At: --0000000000005a7375056cf17892 Content-Type: text/plain; charset="UTF-8" > > I do not know what the command is that is scrolling the child frame. It > > does not appear in view-lossage. > And C-h k does not give any clue either? Ah, C-h k does give a clue, thank you! at that spot runs the command mouse-drag-region at that spot runs the command mouse-set-point The window selected in posn-set-point is the window in the child frame, which is the window that scrolls (and that I do not want to scroll). But, the thing doing the scrolling is 'mouse-drag-region', which calls 'mouse-drag-track', which calculates the bottom of the window incorrectly if it does not have a mode-line. The attached patch fixes this, which fixes my originally reported problem. Given that it impacts a use of child-frames and it's relatively minor I'd propose that it gets applied to emacs 26 (probably after 26.1 release?) if it's acceptable. Thanks, --0000000000005a7375056cf17892 Content-Type: application/octet-stream; name="0001-Prevent-errant-scroll-on-mouse-click-Bug-31546.patch" Content-Disposition: attachment; filename="0001-Prevent-errant-scroll-on-mouse-click-Bug-31546.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jhkf0wbf0 RnJvbSBhYWM5ZWIzNjlhZjM4MmY0MTk3ZDFhYzlkMWVmYWYzZTM4NDEyNmE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYXJvbiBKZW5zZW4gPGFhcm9uamVuc2VuQGdtYWlsLmNvbT4K RGF0ZTogVGh1LCAyNCBNYXkgMjAxOCAwMzo0NTowMyAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFBy ZXZlbnQgZXJyYW50IHNjcm9sbCBvbiBtb3VzZSBjbGljayAoQnVnIzMxNTQ2KQoKKiBsaXNwL21v dXNlLmVsIChtb3VzZS1kcmFnLXRyYWNrKTogT25seSBhY2NvdW50IGZvciBtb2RlLWxpbmUgaGVp Z2h0CiAgaWYgYG1vZGUtbGluZS1mb3JtYXQnIGlzIG5vbi1uaWwuCi0tLQogbGlzcC9tb3VzZS5l bCB8IDMgKystCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p CgpkaWZmIC0tZ2l0IGEvbGlzcC9tb3VzZS5lbCBiL2xpc3AvbW91c2UuZWwKaW5kZXggOTVhYWRh OWIxNS4uNmE0NTExOGRlMCAxMDA2NDQKLS0tIGEvbGlzcC9tb3VzZS5lbAorKysgYi9saXNwL21v dXNlLmVsCkBAIC0xMjE5LDcgKzEyMTksOCBAQCBtb3VzZS1kcmFnLXRyYWNrCiAJIChib3VuZHMg KHdpbmRvdy1lZGdlcyBzdGFydC13aW5kb3cpKQogCSAobWFrZS1jdXJzb3ItbGluZS1mdWxseS12 aXNpYmxlIG5pbCkKIAkgKHRvcCAobnRoIDEgYm91bmRzKSkKLQkgKGJvdHRvbSAoaWYgKHdpbmRv dy1taW5pYnVmZmVyLXAgc3RhcnQtd2luZG93KQorCSAoYm90dG9tIChpZiAob3IgKHdpbmRvdy1t aW5pYnVmZmVyLXAgc3RhcnQtd2luZG93KQorICAgICAgICAgICAgICAgICAgICAgICAgIChub3Qg bW9kZS1saW5lLWZvcm1hdCkpCiAJCSAgICAgKG50aCAzIGJvdW5kcykKIAkJICAgOzsgRG9uJ3Qg Y291bnQgdGhlIG1vZGUgbGluZS4KIAkJICAgKDEtIChudGggMyBib3VuZHMpKSkpCi0tIAoyLjE3 LjAKCg== --0000000000005a7375056cf17892--