bug#31853: 27.0.50; binding case-fold-search is slow when there are many buffers

[Aaron Jensen <aaronjensen@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

On Sat, Jun 16, 2018 at 12:53 AM Eli Zaretskii <eliz@gnu.org> wrote:
> In https://debbugs.gnu.org/cgi/bugreport.cgi?bug=18522#201 I proposed
> a change to set-default that would use FOR_EACH_LIVE_BUFFER.  Could
> you see if that change helps in your case?

So far so good. I'll try it out for a few more days and see if it
stays fast. The patch I'm trying is attached if anyone else wants to
give it a go or check to ensure I didn't do something wrong in it.

[-- Attachment #2: 0001-Test.patch --]
[-- Type: application/octet-stream, Size: 905 bytes --]

From 6b1884635a4bac85fe2a9a04d685cc80dc84a909 Mon Sep 17 00:00:00 2001
From: Aaron Jensen <aaronjensen@gmail.com>
Date: Sat, 16 Jun 2018 01:13:21 -0700
Subject: [PATCH] Test

---
 src/data.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/data.c b/src/data.c
index 49c3dd834b..1133dc02da 100644
--- a/src/data.c
+++ b/src/data.c
@@ -1710,11 +1710,12 @@ set_default_internal (Lisp_Object symbol, Lisp_Object value,
 	       set it in the buffers that don't nominally have a local value.  */
 	    if (idx > 0)
 	      {
+                Lisp_Object tail, buf;
 		struct buffer *b;
 
-		FOR_EACH_BUFFER (b)
-		  if (!PER_BUFFER_VALUE_P (b, idx))
-		    set_per_buffer_value (b, offset, value);
+		FOR_EACH_LIVE_BUFFER (tail, buf)
+		  if (!PER_BUFFER_VALUE_P (XBUFFER (buf), idx))
+		    set_per_buffer_value (XBUFFER (buf), offset, value);
 	      }
 	  }
 	else
-- 
2.17.1