From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#28442: 26.0.50; [PATCH] Save and restore frame pixel size with desktop-save-mode Date: Fri, 15 Dec 2017 10:30:43 -0500 Message-ID: References: <5A167CC1.5090609@gmx.at> <20171123204114.GA3884@breton.holly.idiocy.org> <5A17DFE6.5000005@gmx.at> <5A1A96A4.5000509@gmx.at> <5A1BD14F.4060907@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a114fd6dc28ddf6056062afea" X-Trace: blaine.gmane.org 1513351878 18410 195.159.176.226 (15 Dec 2017 15:31:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 15 Dec 2017 15:31:18 +0000 (UTC) Cc: 28442@debbugs.gnu.org To: martin rudalics , Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 15 16:31:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePrx8-00045V-3h for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Dec 2017 16:31:10 +0100 Original-Received: from localhost ([::1]:47135 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePrxC-000383-4b for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Dec 2017 10:31:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePrx3-00037w-Vb for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2017 10:31:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePrx0-0004qq-NZ for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2017 10:31:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55501) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ePrx0-0004qX-ID for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2017 10:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ePrx0-0007AX-Bs for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2017 10:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Dec 2017 15:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28442 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28442-submit@debbugs.gnu.org id=B28442.151335185327542 (code B ref 28442); Fri, 15 Dec 2017 15:31:02 +0000 Original-Received: (at 28442) by debbugs.gnu.org; 15 Dec 2017 15:30:53 +0000 Original-Received: from localhost ([127.0.0.1]:35949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePrwr-0007A9-Ad for submit@debbugs.gnu.org; Fri, 15 Dec 2017 10:30:53 -0500 Original-Received: from mail-qk0-f174.google.com ([209.85.220.174]:36381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePrwo-00079x-VO for 28442@debbugs.gnu.org; Fri, 15 Dec 2017 10:30:51 -0500 Original-Received: by mail-qk0-f174.google.com with SMTP id 8so10771607qkj.3 for <28442@debbugs.gnu.org>; Fri, 15 Dec 2017 07:30:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=wyRe/1LbV0p7C1Xz0kCPUJ7BNVuEQi1uFBXVQHtzFfg=; b=frdNGsNMPO1ORQSxLtoCIzuQRH9K9gPBrG3Kv5x8Lh56x4WYhfLMxykYY6Ff4XA30O 00umNb0H9xP4lTocs1NFLFkRDAS+XFEoARdDEBg/bzNhHiNpirwMGzcLeLWHq47rXoTl J+bDQthqjqujWthT4NPGbdpeiMSKbXQkMn4Fei9tGIvfXe6Ad2JZzmUSrqaDc5bKm5cv oJ7pPrz3Opdji7xVCxrqCUZOI/UVFXAcPHzWI6flyjYy+UZSEANBcw1UDe+GBbyk+ebu ROsiCf2KlAo8PmnfzCkML8r6iMloRj0wO1mrSLI6vBlt4pMsUpz7sIkO9thDVUJgJzFg l6bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=wyRe/1LbV0p7C1Xz0kCPUJ7BNVuEQi1uFBXVQHtzFfg=; b=efpLx2YDwMQOY51RzqJHQKkQSpKJTsUl48ZpF5Oqkez3xwe5R21yCwPsb+aivOWOG5 Bkn41GkXlLUGFEQqp7OOMuvrttAyjQDMyGRtr1/6PbW0skzQQwgG7im2qJ1llU4wLvui bOimk5o/ui4cCx5jxAvpT4EUdsfbo5AWeuf2YluoM3aB/e2PhqfMRysXIx1yfVNVQ9Q5 VpyccCtPPq0TPjLyOuu2AyCpOZDaeaeSwsP47eMP+FXa6CJUsxuO4b3gfX7XPe8Yul0K 3s5a9804q8k01EiSzvRMHmO9MBQdcd+ci7YZ1MxzWOR2NDa7gvzL9a5KcMoMExtzW5bm 0xeQ== X-Gm-Message-State: AKGB3mKAUd204+MThTGcybuTJOpLeEZag0s5kEDWFynx38fiNkbnowsf +VfVPh8luTbrOrkAQY7Mz4B+Tre2EpLvSZuUPKU= X-Google-Smtp-Source: ACJfBouer8lJPNJzD4RC/7J1um2yYU9pVp+XvtzhAzIVQfQ6c3ekZ2pq53wbPe0JSaBL6oAMSHck5y7pWwTrFNu5LoQ= X-Received: by 10.55.165.213 with SMTP id o204mr20788019qke.314.1513351845302; Fri, 15 Dec 2017 07:30:45 -0800 (PST) Original-Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Fri, 15 Dec 2017 10:30:43 -0500 In-Reply-To: X-Mailer: Airmail (467) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141117 Archived-At: --001a114fd6dc28ddf6056062afea Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable FYI, my copyright assignment has been completed. Let me know if there=E2=80= =99s anything else needed on this patch. Thanks, Aaron On November 27, 2017 at 8:52:09 AM, Aaron Jensen (aaronjensen@gmail.com) wrote: On November 27, 2017 at 12:48:27 AM, martin rudalics (rudalics@gmx.at (mailto:rudalics@gmx.at)) wrote: > > How=E2=80=99s this? > > Elegant, in particular the `frameset--restore-frame' part. Eli will > decide whether we can put this on the release branch. In either case > we'll have to wait until your paperwork is complete. And please send > diffs as attachments, one of our MUAs has decided to truncate some of > the lines. Thanks, I've attached it. > Anyway, since I'm not using desktop please confirm the following: When > `desktop-read' runs and your init file contains a non-nil customization > for `frame-resize-pixelwise', the size hints are set correctly to 1 for > each frame restored. Unfortunately, I=E2=80=99m on macOS so I=E2=80=99m not sure that the size h= ints come into play. That said, it works on macOS. If you=E2=80=99d like to test on your machine, this is a relatively non-int= rusive config that should only remember frame positions: (setq desktop-globals-to-save '() desktop-files-not-to-save ".*" desktop-buffers-not-to-save ".*" desktop-save t) (when (and (window-system) (not (boundp 'desktop-has-read))) (setq desktop-has-read t) (desktop-save-mode) (desktop-read)) > Thank you very much, martin No problem, thank you for your guidance. Aaron --001a114fd6dc28ddf6056062afea Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable = FYI, my copyright as= signment has been completed. Let me know if there=E2=80=99s anything else n= eeded on this patch.

= Thanks,

Aaron

On November 27, 2017 at 8:5= 2:09 AM, Aaron Jensen (aaronjensen= @gmail.com) wrote:

On November 27, 2017 at 12:48:27 AM, martin rudalic= s (rudalics@gmx.at(mailto:rudalics@gmx.at)) wrote:

> > How=E2=80=99s this?
> =20
> Elegant, in particular the `frameset--restore-frame' part. Eli= will
> decide whether we can put this on the release branch. In either ca= se
> we'll have to wait until your paperwork is complete. And pleas= e send
> diffs as attachments, one of our MUAs has decided to truncate some= of
> the lines.

Thanks, I've attached it.

> Anyway, since I'm not using desktop please confirm the followi= ng: When
> `desktop-read' runs and your init file contains a non-nil cust= omization
> for `frame-resize-pixelwise', the size hints are set correctly= to 1 for
> each frame restored.

Unfortunately, I=E2=80=99m on macOS so I=E2=80=99m not sure that the si= ze hints come into play. That said, it works on macOS.

If you=E2=80=99d like to test on your machine, this is a relatively non= -intrusive config that should only remember frame positions:

=C2=A0 (setq desktop-globals-to-save '()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 desktop-files-not-to-save ".*"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 desktop-buffers-not-to-save ".*"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 desktop-save t)
=C2=A0 (when (and (window-system)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(not (boundp 'deskt= op-has-read)))
=C2=A0 =C2=A0 (setq desktop-has-read t)
=C2=A0 =C2=A0 (desktop-save-mode)
=C2=A0 =C2=A0 (desktop-read))

=C2=A0
> Thank you very much, martin

No problem, thank you for your guidance.

Aaron
--001a114fd6dc28ddf6056062afea--