bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen <aaronjensen@gmail.com>]

On Tue, Sep 19, 2017 at 2:44 PM, Aaron Jensen <aaronjensen@gmail.com> wrote:
> Oops, yeah, the repro was wrong, I typed that line by hand instead of copy/pasting. Sorry about that. On 10.12, with the correct line, do you reproduce it still? Or was the bad line causing the issue for you?
>
> If you can reproduce on 10.12, it may be a recent regression because I hadn’t ever noticed it and I’ve been using it on 10.12 for a month or two now at least.

Some additional information:

A bug does reproduce on 10.12 for me as well, but not exactly the
same. On 10.12, it does look like the screenshot I originally
included, but does not have the mouse clicking issue. I'm not sure
why. It only does this if on the initial frame with that repro file.

The difference between the behavior on 10.12 and 10.13, however, is
that on 10.13, the area outside of the scrollbar/modeline does not
receive mouse events. If you click on that area of the window, the
click passes through to the window behind Emacs. On 10.12, it properly
receives events. This does seem to work fine on frames created anew
with undecorated as long as the below patch is applied.

Also, there looks like there was an issue with creating a new
undecorated frame, it was not resizable but should be:

---------------

diff --git a/src/nsterm.m b/src/nsterm.m
index a41d6be204..b433092d24 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -7207,9 +7207,9 @@ - (instancetype) initFrameFromEmacs: (struct frame *)f

   win = [[EmacsWindow alloc]
             initWithContentRect: r
-                      styleMask: (FRAME_UNDECORATED (f)
+                      styleMask: ((FRAME_UNDECORATED (f)
                                   ? FRAME_UNDECORATED_FLAGS
-                                  : FRAME_DECORATED_FLAGS
+                                  : FRAME_DECORATED_FLAGS)
 #ifdef NS_IMPL_COCOA
                                   | NSWindowStyleMaskResizable
                                   | NSWindowStyleMaskMiniaturizable

----------------


Also, I'm getting occasional build failures on my 10.12 machine on
emacs-26. Any idea what would cause this:

ln -f emacs bootstrap-emacs

make -C ../nextstep all

rm -rf /private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app

rm -rf /private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app

../build-aux/install-sh -c -d
/private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app

make -C ../src emacs

../build-aux/install-sh -c -d
/private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app

mkdir: /private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app:
File exists

( cd ./Cocoa/Emacs.base ; tar cfh - . ) | \

          ( cd /private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app
; umask 022; tar xf - )

( cd ./Cocoa/Emacs.base ; tar cfh - . ) | \

          ( cd /private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app
; umask 022; tar xf - )

./Contents/PkgInfo: Can't create 'Contents/PkgInfo'

./Contents/Resources/Credits.html: Can't create
'Contents/Resources/Credits.html'

./Contents/Resources/Emacs.icns: Can't create 'Contents/Resources/Emacs.icns'

./Contents/Resources/English.lproj/InfoPlist.strings: Can't create
'Contents/Resources/English.lproj/InfoPlist.strings'

tar: Error exit delayed from previous errors.

tar: Error exit delayed from previous errors.

make[2]: *** [/private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app/Contents/Info.plist]
Error 1

make[2]: *** Waiting for unfinished jobs....

make[2]: *** [/private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app]
Error 1

make[3]: Circular bootstrap-emacs <- temacs dependency dropped.

make -C ../admin/unidata all EMACS="../../src/bootstrap-emacs"

make -C ../admin/charsets all

make -C ../admin/unidata charscript.el

make -C ../admin/unidata all EMACS="../../src/bootstrap-emacs"

make[4]: Nothing to be done for `charscript.el'.

make -C ../admin/charsets cp51932.el

make[4]: Nothing to be done for `all'.

make[4]: Nothing to be done for `all'.

make -C ../admin/charsets eucjp-ms.el

make[4]: Nothing to be done for `cp51932.el'.

make[4]: Nothing to be done for `eucjp-ms.el'.

make[4]: Nothing to be done for `all'.

make[1]: *** [ns-app] Error 2

make: *** [src] Error 2